improves styles for budget investments advanced filters

app/assets/stylesheets/admin.scss

@@ -9,7 +9,7 @@
 // 07. Legislation
 // 08. CMS
 // 09. Map
-// 10. Budget phases
+// 10. Budgets
 //
 
 // 01. Global styles
@@ -1034,8 +1034,33 @@ table {
   height: 0;
 }
 
-// 10. Budget phases
+// 10. Budgets
 // -----------------
+
+.advanced-filters {
+  margin: $line-height 0;
+
+  @include breakpoint(medium) {
+    margin: $line-height / 2 0 0;
+  }
+}
+
+.advanced-filters-content {
+  background: $highlight;
+  clear: both;
+  padding: $line-height / 2;
+  margin: $line-height 0;
+
+  .filter {
+    display: inline-block;
+    margin: 0 $line-height / 2;
+  }
+
+  .button {
+    margin-top: $line-height / 2;
+  }
+}
+
 .budget-phase-enabled {
   font-weight: bold;
   padding-left: rem-calc(20);

app/views/admin/budget_investments/_advanced_filters.html.erb

@@ -1,27 +1,44 @@
-<div id="advanced-filters" class="callout primary">
+<%= link_to "#advanced_filters_content",
+            data: {toggle: "advanced_filters"},
+            class: "advanced-filters float-right" do %>
+  <%= t("admin.budget_investments.index.advanced_filters") %>
+<% end %>
+
+<div id="advanced_filters" class="row expanded advanced-filters-content hide" data-toggler=".hide">
   <%= form_tag(admin_budget_budget_investments_path(budget: @budget,
                                                     filter: params[:filter],
                                                     second_filter: params[:second_filter],
                                                     max_per_heading: params[:max_per_heading],
                                                     page: 1), method: :get, remote: true, enforce_utf8: false) do %>
-
+    <div class="small-12 medium-8 large-10 column">
+      <span class="filter">
         <%= check_box_tag :second_filter, "feasible" %>
         <%= t("#{i18n_namespace}.filters.feasible") %>
+      </span>
 
+      <span class="filter">
         <%= check_box_tag :second_filter, "selected" %>
         <%= t("#{i18n_namespace}.filters.selected") %>
+      </span>
 
+      <span class="filter">
         <%= check_box_tag :second_filter, "undecided" %>
         <%= t("#{i18n_namespace}.filters.undecided") %>
+      </span>
 
+      <span class="filter">
         <%= check_box_tag :second_filter, "unfeasible" %>
         <%= t("#{i18n_namespace}.filters.unfeasible") %>
+      </span>
 
-    <div class="large-1">
+      <span class="filter">
+        <strong><%= t("#{i18n_namespace}.filters.max_per_heading") %></strong>
         <%= text_field_tag :max_per_heading %>
-      <%= t("#{i18n_namespace}.filters.max_per_heading") %>
+      </span>
     </div>
 
-    <%= submit_tag t("#{i18n_namespace}.filters.button"), class: "button small float-right" %>
+    <div class="small-12 medium-4 large-2 column">
+      <%= submit_tag t("#{i18n_namespace}.filters.button"), class: "button expanded" %>
+    </div>
   <% end %>
 </div>

app/views/admin/budget_investments/index.html.erb

@@ -1,7 +1,6 @@
 <h2 class="inline-block"><%= @budget.name %> - <%= t("admin.budget_investments.index.title") %></h2>
 
-<div class="row margin">
+<%= form_tag(admin_budget_budget_investments_path(budget: @budget), method: :get, enforce_utf8: false) do %>
-  <%= form_tag(admin_budget_budget_investments_path(budget: @budget), method: :get, enforce_utf8: false) do %>
   <div class="small-12 medium-3 column">
     <%= select_tag :administrator_id,
                    options_for_select(admin_select_options, params[:administrator_id]),
@@ -33,8 +32,7 @@
                      label: false,
                      class: "js-submit-on-change" } %>
   </div>
-  <% end %>
+<% end %>
-</div>
 
 <%= render "advanced_filters", i18n_namespace: "admin.budget_investments.index" %>
 

config/locales/en/admin.yml

@@ -137,6 +137,7 @@ en:
         administrator_filter_all: All administrators
         valuator_filter_all: All valuators
         tags_filter_all: All tags
+        advanced_filters: Advanced filters
         filters:
           all: All
           without_admin: Without assigned admin

config/locales/es/admin.yml

@@ -137,6 +137,7 @@ es:
         administrator_filter_all: Todos los administradores
         valuator_filter_all: Todos los evaluadores
         tags_filter_all: Todas las etiquetas
+        advanced_filters: Filtros avanzados
         filters:
           all: Todos
           without_admin: Sin administrador