From acbd1b02396e3919daeb601f00d2ddda79ebe748 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Mon, 12 Jul 2021 03:19:34 +0200
Subject: [PATCH] Simplify code to reset attachment fields

Since elements are created and destroyed, we don't have to do any kind
of "reset" before destroying or creating them. We would have to do so if
we were just hiding the elements in order to show them again later, but
that's not the case.
---
 app/assets/javascripts/documentable.js | 5 -----
 app/assets/javascripts/imageable.js    | 9 ---------
 2 files changed, 14 deletions(-)

diff --git a/app/assets/javascripts/documentable.js b/app/assets/javascripts/documentable.js
index 1a7cf33ff..53057ff79 100644
--- a/app/assets/javascripts/documentable.js
+++ b/app/assets/javascripts/documentable.js
@@ -134,11 +134,6 @@
           "_method": "delete"
         },
         complete: function() {
-          $(data.cachedAttachmentField).val("");
-          $(data.addAttachmentLabel).show();
-          App.Documentable.clearFilename(data);
-          App.Documentable.clearInputErrors(data);
-          App.Documentable.clearProgressBar(data);
           App.Documentable.unlockUploads();
           $(data.wrapper).find(".attachment-actions").addClass("small-12").removeClass("small-6 float-right");
           $(data.wrapper).find(".attachment-actions .action-remove").addClass("small-3").removeClass("small-12");
diff --git a/app/assets/javascripts/imageable.js b/app/assets/javascripts/imageable.js
index 5b784f475..62b3b9731 100644
--- a/app/assets/javascripts/imageable.js
+++ b/app/assets/javascripts/imageable.js
@@ -8,9 +8,6 @@
       $("#nested-image").on("cocoon:after-remove", function() {
         $("#new_image_link").removeClass("hide");
       });
-      $("#nested-image").on("cocoon:before-insert", function() {
-        $(".js-image-attachment").closest(".image").remove();
-      });
       $("#nested-image").on("cocoon:after-insert", function(e, nested_image) {
         var input;
         $("#new_image_link").addClass("hide");
@@ -137,12 +134,6 @@
           "_method": "delete"
         },
         complete: function() {
-          $(data.cachedAttachmentField).val("");
-          $(data.addAttachmentLabel).show();
-          App.Imageable.clearFilename(data);
-          App.Imageable.clearInputErrors(data);
-          App.Imageable.clearProgressBar(data);
-          App.Imageable.clearPreview(data);
           $("#new_image_link").removeClass("hide");
           $(data.wrapper).find(".attachment-actions").addClass("small-12").removeClass("small-6 float-right");
           $(data.wrapper).find(".attachment-actions .action-remove").addClass("small-3").removeClass("small-12");