avoids queries when creating a notification

2016-01-08 12:35:23 +01:00
parent de51bb0f79
commit ab74bd58fa
1 changed files with 3 additions and 3 deletions
--- a/app/controllers/comments_controller.rb
+++ b/app/controllers/comments_controller.rb
@@ -65,11 +65,11 @@ class CommentsController < ApplicationController

    def add_notification(comment)
      if comment.reply?
-        author = comment.parent.author
+        notifiable = comment.parent
      else
-        author = comment.commentable.author
+        notifiable = comment.commentable
      end
-      author.notifications.create!(notifiable: comment) unless comment.made_by? author
+      Notification.create!(user_id: notifiable.author_id, notifiable: comment) unless comment.author_id == notifiable.author_id
   end

 end