From 6d55a0712d2f5454e39a5ebb279c6fcfd31d089d Mon Sep 17 00:00:00 2001 From: Bertocq Date: Wed, 31 Jan 2018 02:15:40 +0100 Subject: [PATCH 1/3] Remove no longer usable investments rake task --- lib/tasks/investments.rake | 12 ------------ 1 file changed, 12 deletions(-) delete mode 100644 lib/tasks/investments.rake diff --git a/lib/tasks/investments.rake b/lib/tasks/investments.rake deleted file mode 100644 index f9619b5ed..000000000 --- a/lib/tasks/investments.rake +++ /dev/null @@ -1,12 +0,0 @@ -namespace :investments do - namespace :internal_comments do - desc "Migrate internal_comments textarea to a first comment on internal thread" - task migrate_to_thread: :environment do - comments_author_id = Administrator.first.user.id - Budget::Investment.where.not(internal_comments: [nil, '']).find_each do |investment| - Comment.create(commentable: investment, user_id: comments_author_id, - body: investment.internal_comments, valuation: true) - end - end - end -end From a360cf4fbcf2122ac8f66616356450fc43ad67f0 Mon Sep 17 00:00:00 2001 From: Bertocq Date: Wed, 31 Jan 2018 02:16:27 +0100 Subject: [PATCH 2/3] Remove deprecated internal_comments column from Investments --- ...0180131011426_remove_internal_comments_from_investment.rb | 5 +++++ db/schema.rb | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 db/migrate/20180131011426_remove_internal_comments_from_investment.rb diff --git a/db/migrate/20180131011426_remove_internal_comments_from_investment.rb b/db/migrate/20180131011426_remove_internal_comments_from_investment.rb new file mode 100644 index 000000000..b104e2bae --- /dev/null +++ b/db/migrate/20180131011426_remove_internal_comments_from_investment.rb @@ -0,0 +1,5 @@ +class RemoveInternalCommentsFromInvestment < ActiveRecord::Migration + def change + remove_column :budget_investments, :internal_comments + end +end diff --git a/db/schema.rb b/db/schema.rb index 612ca8e1e..a32417cc1 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -136,7 +136,6 @@ ActiveRecord::Schema.define(version: 20180220211105) do t.string "feasibility", limit: 15, default: "undecided" t.text "price_explanation" t.text "unfeasibility_explanation" - t.text "internal_comments" t.boolean "valuation_finished", default: false t.integer "valuator_assignments_count", default: 0 t.integer "price_first_year", limit: 8 From 04316a446040eda911d621b908c40ac9e97379c8 Mon Sep 17 00:00:00 2001 From: Bertocq Date: Fri, 9 Mar 2018 12:27:04 +0100 Subject: [PATCH 3/3] Remove internal_comments usage in migration script Internal comments on migration script from SpendingProposal to Investments are no longer in use, so removal is best option. --- lib/migrate_spending_proposals_to_investments.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/migrate_spending_proposals_to_investments.rb b/lib/migrate_spending_proposals_to_investments.rb index 6df75d3f7..908be8cc5 100644 --- a/lib/migrate_spending_proposals_to_investments.rb +++ b/lib/migrate_spending_proposals_to_investments.rb @@ -32,7 +32,6 @@ class MigrateSpendingProposalsToInvestments external_url: sp.external_url, price: sp.price, price_explanation: sp.price_explanation, - internal_comments: sp.internal_comments, duration: sp.time_scope, feasibility: feasibility, unfeasibility_explanation: sp.feasible_explanation,