From a5e4fb13b471fcb3632110692b32ce365bc6bae3 Mon Sep 17 00:00:00 2001 From: taitus Date: Wed, 13 Dec 2023 14:39:55 +0100 Subject: [PATCH] Unify errors on create comments --- .../comments/budget_investments_spec.rb | 9 ------- spec/system/comments/debates_spec.rb | 9 ------- .../comments/legislation_annotations_spec.rb | 9 ------- .../comments/legislation_questions_spec.rb | 9 ------- spec/system/comments/polls_spec.rb | 9 ------- spec/system/comments/proposals_spec.rb | 9 ------- spec/system/comments/topics_spec.rb | 24 ------------------- spec/system/comments_spec.rb | 23 ++++++++++++++++++ 8 files changed, 23 insertions(+), 78 deletions(-) diff --git a/spec/system/comments/budget_investments_spec.rb b/spec/system/comments/budget_investments_spec.rb index ab4e4da85..d832b9dec 100644 --- a/spec/system/comments/budget_investments_spec.rb +++ b/spec/system/comments/budget_investments_spec.rb @@ -220,15 +220,6 @@ describe "Commenting Budget::Investments" do end end - scenario "Errors on create" do - login_as(user) - visit budget_investment_path(investment.budget, investment) - - click_button "Publish comment" - - expect(page).to have_content "Can't be blank" - end - scenario "Reply" do citizen = create(:user, username: "Ana") manuela = create(:user, username: "Manuela") diff --git a/spec/system/comments/debates_spec.rb b/spec/system/comments/debates_spec.rb index 82daad555..7e30e78a0 100644 --- a/spec/system/comments/debates_spec.rb +++ b/spec/system/comments/debates_spec.rb @@ -220,15 +220,6 @@ describe "Commenting debates" do end end - scenario "Errors on create" do - login_as(user) - visit debate_path(debate) - - click_button "Publish comment" - - expect(page).to have_content "Can't be blank" - end - describe "Hide" do scenario "Without replies" do create(:comment, commentable: debate, user: user, body: "This was a mistake") diff --git a/spec/system/comments/legislation_annotations_spec.rb b/spec/system/comments/legislation_annotations_spec.rb index d2c1b60a2..4841aab1c 100644 --- a/spec/system/comments/legislation_annotations_spec.rb +++ b/spec/system/comments/legislation_annotations_spec.rb @@ -214,15 +214,6 @@ describe "Commenting legislation questions" do end end - scenario "Errors on create" do - login_as(user) - visit polymorphic_path(annotation) - - click_button "Publish comment" - - expect(page).to have_content "Can't be blank" - end - scenario "Reply" do citizen = create(:user, username: "Ana") manuela = create(:user, username: "Manuela") diff --git a/spec/system/comments/legislation_questions_spec.rb b/spec/system/comments/legislation_questions_spec.rb index 1836d1bd6..911d8d783 100644 --- a/spec/system/comments/legislation_questions_spec.rb +++ b/spec/system/comments/legislation_questions_spec.rb @@ -209,15 +209,6 @@ describe "Commenting legislation questions" do end end - scenario "Errors on create" do - login_as(user) - visit legislation_process_question_path(question.process, question) - - click_button "Publish answer" - - expect(page).to have_content "Can't be blank" - end - scenario "Reply" do citizen = create(:user, username: "Ana") manuela = create(:user, :level_two, username: "Manuela") diff --git a/spec/system/comments/polls_spec.rb b/spec/system/comments/polls_spec.rb index 3c8fb54ce..66e762818 100644 --- a/spec/system/comments/polls_spec.rb +++ b/spec/system/comments/polls_spec.rb @@ -201,15 +201,6 @@ describe "Commenting polls" do end end - scenario "Errors on create" do - login_as(user) - visit poll_path(poll) - - click_button "Publish comment" - - expect(page).to have_content "Can't be blank" - end - scenario "Reply" do citizen = create(:user, username: "Ana") manuela = create(:user, username: "Manuela") diff --git a/spec/system/comments/proposals_spec.rb b/spec/system/comments/proposals_spec.rb index de5e2c24c..b27281346 100644 --- a/spec/system/comments/proposals_spec.rb +++ b/spec/system/comments/proposals_spec.rb @@ -206,15 +206,6 @@ describe "Commenting proposals" do end end - scenario "Errors on create" do - login_as(user) - visit proposal_path(proposal) - - click_button "Publish comment" - - expect(page).to have_content "Can't be blank" - end - scenario "Reply" do citizen = create(:user, username: "Ana") manuela = create(:user, username: "Manuela") diff --git a/spec/system/comments/topics_spec.rb b/spec/system/comments/topics_spec.rb index 4e47f71e7..eec55ff6b 100644 --- a/spec/system/comments/topics_spec.rb +++ b/spec/system/comments/topics_spec.rb @@ -221,18 +221,6 @@ describe "Commenting topics from proposals" do end end - scenario "Errors on create" do - community = proposal.community - topic = create(:topic, community: community) - - login_as(user) - visit community_topic_path(community, topic) - - click_button "Publish comment" - - expect(page).to have_content "Can't be blank" - end - scenario "Reply" do community = proposal.community topic = create(:topic, community: community) @@ -754,18 +742,6 @@ describe "Commenting topics from budget investments" do end end - scenario "Errors on create" do - community = investment.community - topic = create(:topic, community: community) - - login_as(user) - visit community_topic_path(community, topic) - - click_button "Publish comment" - - expect(page).to have_content "Can't be blank" - end - scenario "Reply" do community = investment.community topic = create(:topic, community: community) diff --git a/spec/system/comments_spec.rb b/spec/system/comments_spec.rb index 7a8f3a099..753d5ffec 100644 --- a/spec/system/comments_spec.rb +++ b/spec/system/comments_spec.rb @@ -14,6 +14,13 @@ describe "Comments" do ].sample } let(:resource) { create(factory) } + let(:user) do + if factory == :legislation_question + create(:user, :level_two) + else + create(:user) + end + end let(:fill_text) do if factory == :legislation_question "Leave your answer" @@ -21,6 +28,13 @@ describe "Comments" do "Leave your comment" end end + let(:button_text) do + if factory == :legislation_question + "Publish answer" + else + "Publish comment" + end + end describe "Not logged user" do scenario "can not see comments forms" do @@ -35,4 +49,13 @@ describe "Comments" do end end end + + scenario "Errors on create" do + login_as(user) + visit polymorphic_path(resource) + + click_button button_text + + expect(page).to have_content "Can't be blank" + end end