consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use buttons instead of links to hide content

Browse Source 
We're continuing to replace links with buttons, for the reasons
explained in commit 5311daadf.

Since we're using the admin action component, we can also simplify the
logic handling the confirmation message.

In order to avoid duplicate IDs when generating buttons to block the
same author more than once in a page, we're including the record dom_id
in the ID of the button to block an author.
This commit is contained in:
Javi Martín
2021-12-02 20:48:43 +01:00
parent f1389b2409
commit a5c66c7281
14 changed files with 79 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/system/admin/activity_spec.rb
View File

@@ -14,7 +14,7 @@ describe "Admin activity" do
visit proposal_path(proposal)
within("#proposal_#{proposal.id}") do
accept_confirm("Are you sure? Hide \"#{proposal.title}\"") { click_link "Hide" }
accept_confirm("Are you sure? Hide \"#{proposal.title}\"") { click_button "Hide" }
end
expect(page).to have_css("#proposal_#{proposal.id}.faded")
@@ -82,7 +82,7 @@ describe "Admin activity" do
visit debate_path(debate)
within("#debate_#{debate.id}") do
accept_confirm("Are you sure? Hide \"#{debate.title}\"") { click_link "Hide" }
accept_confirm("Are you sure? Hide \"#{debate.title}\"") { click_button "Hide" }
end
expect(page).to have_css("#debate_#{debate.id}.faded")
@@ -150,7 +150,7 @@ describe "Admin activity" do
visit debate_path(debate)
within("#comment_#{comment.id}") do
accept_confirm("Are you sure? Hide \"#{comment.body}\"") { click_link "Hide" }
accept_confirm("Are you sure? Hide \"#{comment.body}\"") { click_button "Hide" }
expect(page).to have_css(".faded")
end
@@ -217,7 +217,7 @@ describe "Admin activity" do
visit proposal_path(proposal)
within("#proposal_#{proposal.id}") do
accept_confirm("Are you sure? Block author \"#{proposal.author.name}\"") { click_link "Block author" }
accept_confirm("Are you sure? Block author \"#{proposal.author.name}\"") { click_button "Block author" }
expect(page).to have_current_path(proposals_path)
end

2
spec/system/admin/hidden_comments_spec.rb
View File

@@ -13,7 +13,7 @@ describe "Admin hidden comments", :admin do
visit proposal_path(proposal)
within("#proposal_#{proposal.id}") do
accept_confirm("Are you sure? Block author \"#{proposal.author.name}\"") { click_link "Block author" }
accept_confirm("Are you sure? Block author \"#{proposal.author.name}\"") { click_button "Block author" }
end
expect(page).to have_current_path proposals_path