Merge pull request #1539 from consul/budgets-unselected

Do not display voting button for unselected investments

app/models/budget/investment.rb

@@ -216,7 +216,7 @@ class Budget
     end
 
     def should_show_ballots?
-      budget.balloting?
+      budget.balloting? && selected?
     end
 
     def should_show_price?

spec/features/budgets/investments_spec.rb

@@ -652,6 +652,24 @@ feature 'Budget Investments' do
       expect(page).to have_current_path(expected_path)
     end
 
+    scenario "Do not display vote button for unselected investments in index" do
+      investment = create(:budget_investment, :unselected, heading: heading)
+
+      visit budget_investments_path(budget_id: budget.id, heading_id: heading.id, filter: "unselected")
+
+      expect(page).to have_content investment.title
+      expect(page).to_not have_link("Vote")
+    end
+
+    scenario "Do not display vote button for unselected investments in show" do
+      investment = create(:budget_investment, :unselected, heading: heading)
+
+      visit budget_investment_path(budget, investment)
+
+      expect(page).to have_content investment.title
+      expect(page).to_not have_link("Vote")
+    end
+
     scenario "Reclassification" do
       user = create(:user, :level_two)
       investment = create(:budget_investment, :selected, heading: heading)

spec/models/budget/investment_spec.rb

@@ -163,17 +163,24 @@ describe Budget::Investment do
   end
 
   describe "#should_show_ballots?" do
-    it "returns true in balloting phase" do
+    it "returns true in balloting phase for selected investments" do
       budget = create(:budget, phase: "balloting")
-      investment = create(:budget_investment, budget: budget)
+      investment = create(:budget_investment, :selected, budget: budget)
 
       expect(investment.should_show_ballots?).to eq(true)
     end
 
+    it "returns false for unselected investments" do
+      budget = create(:budget, phase: "balloting")
+      investment = create(:budget_investment, :unselected, budget: budget)
+
+      expect(investment.should_show_ballots?).to eq(false)
+    end
+
     it "returns false in any other phase" do
       Budget::PHASES.reject {|phase| phase == "balloting"}.each do |phase|
         budget = create(:budget, phase: phase)
-        investment = create(:budget_investment, budget: budget)
+        investment = create(:budget_investment, :selected, budget: budget)
 
         expect(investment.should_show_ballots?).to eq(false)
       end