Split some system tests checking the database
As mentioned in commits likea586ba806,a7664ad81,006128da5,b41fbfa52andc480cdd91, accessing the database after starting the browser with the `visit` method sometimes results in database corruption and failing tests on our CI due to the process running the test accessing the database after the process running the browser has started. IMHO this is also a bad practice for system tests, since these tests should be checking what users experience. In these cases, however, I haven't been able to test the user experience. For example, it looks like failed census calls for unregistered users aren't displayed anywhere and can only be accessed by manually checking the database. Similarly, there's no interface showing that all the options from a poll have been deleted (which makes sense, since we only display options in the context of their poll) or a place showing the responsible name for a proposal. So we're splitting the tests in two, with the controller test running the database checks.
This commit is contained in:
@@ -0,0 +1,16 @@
|
||||
require "rails_helper"
|
||||
|
||||
describe Admin::AdminNotificationsController, :admin do
|
||||
describe "POST deliver" do
|
||||
it "sends notifications to every recipient" do
|
||||
2.times { create(:user) }
|
||||
notification = create(:admin_notification, segment_recipient: :all_users)
|
||||
|
||||
post :deliver, params: { id: notification }
|
||||
|
||||
User.find_each do |user|
|
||||
expect(user.notifications.count).to eq 1
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
Reference in New Issue
Block a user