Validate inclusion of document type in allowed document types

* Add custom message for inclusion validation to include the allowed values.
* Force user to choose document_type from select lik the one shown at verification form.
* Convert stored document_type to a human readable text
This commit is contained in:
Senén Rodero Rodríguez
2019-10-17 16:05:40 +02:00
parent a2f5317ae1
commit a150f2161e
11 changed files with 38 additions and 22 deletions

View File

@@ -49,7 +49,7 @@ describe LocalCensusRecords::Import do
local_census_record = LocalCensusRecord.find_by(document_number: "X11556678")
expect(local_census_record).not_to be_nil
expect(local_census_record.document_type).to eq("NIE")
expect(local_census_record.document_type).to eq("2")
expect(local_census_record.document_number).to eq("X11556678")
expect(local_census_record.date_of_birth).to eq(Date.parse("07/08/1987"))
expect(local_census_record.postal_code).to eq("7008")
@@ -69,11 +69,11 @@ describe LocalCensusRecords::Import do
import.save!
invalid_records_document_types = [nil, "DNI", "Passport", "NIE"]
invalid_records_document_numbers = ["44556678T", nil, "22556678T", "X11556678"]
invalid_records_document_types = [nil, "1", "2", "3", "DNI"]
invalid_records_document_numbers = ["44556678T", nil, "22556678T", "X11556678", "Z11556678"]
invalid_records_date_of_births = [Date.parse("07/08/1984"), Date.parse("07/08/1985"), nil,
Date.parse("07/08/1987")]
invalid_records_postal_codes = ["7008", "7009", "7010", nil]
Date.parse("07/08/1987"), Date.parse("07/08/1987")]
invalid_records_postal_codes = ["7008", "7009", "7010", nil, "7011"]
expect(import.invalid_records.map(&:document_type))
.to eq(invalid_records_document_types)
expect(import.invalid_records.map(&:document_number))