From a14cf4f7004a7ac15f96b4522e15cf8d528877dd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Fri, 9 Jul 2021 17:47:17 +0200
Subject: [PATCH] Simplify padding rules for SDG selector

Now the padding is only applied in two places (administration forms) so
we can apply it just there instead of applying it everywhere and then
removing it in most places. We're using the `column` class here because
it's what's used in the rest of the fields of these forms and because we
haven't defined (yet) general margin/padding rules for the
administration views.
---
 app/assets/stylesheets/budgets/investments/form.scss      | 5 -----
 app/assets/stylesheets/debates/form.scss                  | 5 -----
 app/assets/stylesheets/proposals/form.scss                | 5 -----
 app/assets/stylesheets/sdg/related_list_selector.scss     | 1 -
 app/assets/stylesheets/sdg_management/relations/edit.scss | 6 ------
 app/views/admin/legislation/processes/_form.html.erb      | 4 +++-
 app/views/admin/poll/polls/_form.html.erb                 | 4 +++-
 7 files changed, 6 insertions(+), 24 deletions(-)
 delete mode 100644 app/assets/stylesheets/sdg_management/relations/edit.scss

diff --git a/app/assets/stylesheets/budgets/investments/form.scss b/app/assets/stylesheets/budgets/investments/form.scss
index 6d84a466d..af84d9ec9 100644
--- a/app/assets/stylesheets/budgets/investments/form.scss
+++ b/app/assets/stylesheets/budgets/investments/form.scss
@@ -35,11 +35,6 @@
     @include grid-column-gutter;
   }
 
-  .sdg-related-list-selector {
-    padding-left: 0;
-    padding-right: 0;
-  }
-
   [type="submit"] {
     @include regular-button;
     font-size: map-get($button-sizes, large);
diff --git a/app/assets/stylesheets/debates/form.scss b/app/assets/stylesheets/debates/form.scss
index 3945c2686..ddc1df0c7 100644
--- a/app/assets/stylesheets/debates/form.scss
+++ b/app/assets/stylesheets/debates/form.scss
@@ -5,9 +5,4 @@
     @include grid-row-nest;
     @include grid-column-gutter;
   }
-
-  .sdg-related-list-selector {
-    padding-left: 0;
-    padding-right: 0;
-  }
 }
diff --git a/app/assets/stylesheets/proposals/form.scss b/app/assets/stylesheets/proposals/form.scss
index df5d1d880..b666de98e 100644
--- a/app/assets/stylesheets/proposals/form.scss
+++ b/app/assets/stylesheets/proposals/form.scss
@@ -5,10 +5,5 @@
     @include grid-row-nest;
     @include grid-column-gutter;
   }
-
-  .sdg-related-list-selector {
-    padding-left: 0;
-    padding-right: 0;
-  }
 }
 
diff --git a/app/assets/stylesheets/sdg/related_list_selector.scss b/app/assets/stylesheets/sdg/related_list_selector.scss
index 7b32edaf7..cf97da3f7 100644
--- a/app/assets/stylesheets/sdg/related_list_selector.scss
+++ b/app/assets/stylesheets/sdg/related_list_selector.scss
@@ -1,5 +1,4 @@
 .sdg-related-list-selector {
-  @include grid-column-gutter;
   clear: both;
 
   > legend {
diff --git a/app/assets/stylesheets/sdg_management/relations/edit.scss b/app/assets/stylesheets/sdg_management/relations/edit.scss
deleted file mode 100644
index a719b4336..000000000
--- a/app/assets/stylesheets/sdg_management/relations/edit.scss
+++ /dev/null
@@ -1,6 +0,0 @@
-.sdg-relations-edit {
-
-  .sdg-related-list-selector {
-    padding: 0;
-  }
-}
diff --git a/app/views/admin/legislation/processes/_form.html.erb b/app/views/admin/legislation/processes/_form.html.erb
index 1ecfec53d..98ab0e51c 100644
--- a/app/views/admin/legislation/processes/_form.html.erb
+++ b/app/views/admin/legislation/processes/_form.html.erb
@@ -187,7 +187,9 @@
   </div>
 
   <div class="row">
-    <%= render SDG::RelatedListSelectorComponent.new(f) %>
+    <div class="small-12 column">
+      <%= render SDG::RelatedListSelectorComponent.new(f) %>
+    </div>
   </div>
 
   <div class="row">
diff --git a/app/views/admin/poll/polls/_form.html.erb b/app/views/admin/poll/polls/_form.html.erb
index cb542612d..b3ce9eaf3 100644
--- a/app/views/admin/poll/polls/_form.html.erb
+++ b/app/views/admin/poll/polls/_form.html.erb
@@ -56,7 +56,9 @@
   </div>
 
   <div class="row">
-    <%= render SDG::RelatedListSelectorComponent.new(f) %>
+    <div class="small-12 column">
+      <%= render SDG::RelatedListSelectorComponent.new(f) %>
+    </div>
   </div>
 
   <div class="row">