Apply Rails/SafeNavigation rubocop rule

This commit is contained in:
Javi Martín
2019-06-22 23:00:33 +02:00
parent daa86ca3fc
commit 9fe8c47528
39 changed files with 52 additions and 53 deletions

View File

@@ -9,7 +9,7 @@ class Valuation::BaseController < ApplicationController
private
def verify_valuator
raise CanCan::AccessDenied unless current_user.try(:valuator?) || current_user.try(:administrator?)
raise CanCan::AccessDenied unless current_user&.valuator? || current_user&.administrator?
end
end

View File

@@ -73,8 +73,7 @@ class Valuation::BudgetInvestmentsController < Valuation::BaseController
end
def heading_filters
investments = @budget.investments.by_valuator(current_user.valuator.try(:id))
.visible_to_valuators.distinct
investments = @budget.investments.by_valuator(current_user.valuator&.id).visible_to_valuators.distinct
investment_headings = Budget::Heading.where(id: investments.pluck(:heading_id)).sort_by(&:name)
all_headings_filter = [