From 9f394c6c612cbc43ea5b81b84b6dc433fcf6400e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 9 Mar 2021 14:25:56 +0100 Subject: [PATCH] Do not require Pronto when running the application Pronto is an external tool which is use to check code conventions and is not needed to run the application, just like rubocop or scss-lint. Loading it caused a couple of issues. First, it loaded BetterHtml, and we had to disable it in order to avoid crashes in the development environment. Second, it loaded ruby-progressbar, which loads the ProgressBar class, which conflicts with our own ProgressBar class. This made the application crash whenever the ProgressBar class was used. --- Gemfile | 10 +++++----- config/initializers/better_html.rb | 5 ----- 2 files changed, 5 insertions(+), 10 deletions(-) delete mode 100644 config/initializers/better_html.rb diff --git a/Gemfile b/Gemfile index 68bdd66fd..ad7a5a6e8 100644 --- a/Gemfile +++ b/Gemfile @@ -102,11 +102,11 @@ group :development do gem "erb_lint", "~> 0.0.35", require: false gem "github_changelog_generator", "~> 1.15.2" gem "mdl", "~> 0.11.0", require: false - gem "pronto", "~> 0.11.0" - gem "pronto-erb_lint", "~> 0.1.5" - gem "pronto-eslint", "~> 0.11.0" - gem "pronto-rubocop", "~> 0.11.0" - gem "pronto-scss", "~> 0.11.0" + gem "pronto", "~> 0.11.0", require: false + gem "pronto-erb_lint", "~> 0.1.5", require: false + gem "pronto-eslint", "~> 0.11.0", require: false + gem "pronto-rubocop", "~> 0.11.0", require: false + gem "pronto-scss", "~> 0.11.0", require: false gem "rubocop", "~> 0.91.0", require: false gem "rubocop-performance", "~> 1.7.1", require: false gem "rubocop-rails", "~> 2.6.0", require: false diff --git a/config/initializers/better_html.rb b/config/initializers/better_html.rb deleted file mode 100644 index 5948f7319..000000000 --- a/config/initializers/better_html.rb +++ /dev/null @@ -1,5 +0,0 @@ -if Rails.env.development? - BetterHtml.configure do |config| - config.template_exclusion_filter = proc { |filename| true } - end -end