From 9df201780d5f4ff021e5e34e4d08a3ece4231f9b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Mon, 17 Sep 2018 17:23:11 +0200
Subject: [PATCH] Extract proposals table into a partial

---
 .../legislation/proposals/_proposals.html.erb | 38 +++++++++++++++++
 .../legislation/proposals/index.html.erb      | 41 +------------------
 2 files changed, 39 insertions(+), 40 deletions(-)
 create mode 100644 app/views/admin/legislation/proposals/_proposals.html.erb

diff --git a/app/views/admin/legislation/proposals/_proposals.html.erb b/app/views/admin/legislation/proposals/_proposals.html.erb
new file mode 100644
index 000000000..cc2de04ce
--- /dev/null
+++ b/app/views/admin/legislation/proposals/_proposals.html.erb
@@ -0,0 +1,38 @@
+<% if proposals.any? %>
+  <h3><%= page_entries_info proposals %></h3>
+
+  <%= render 'shared/wide_order_selector', i18n_namespace: "admin.legislation.processes.proposals" %>
+
+  <table class="stack" id="proposals_table">
+    <thead>
+      <tr>
+        <th class="text-center"><%= t("admin.legislation.proposals.index.id") %></th>
+        <th><%= t("admin.legislation.proposals.index.title") %></th>
+        <th class="text-center"><%= t("admin.legislation.proposals.index.supports") %></th>
+        <th><%= t("admin.legislation.proposals.index.selected") %></th>
+      </tr>
+    </thead>
+
+    <tbody>
+      <% proposals.each do |proposal| %>
+        <tr id="<%= dom_id(proposal) %>">
+          <td class="text-center"><%= proposal.id %></td>
+          <td><%= proposal.title %></td>
+          <td class="text-center"><%= proposal.cached_votes_up %></td>
+          <td>
+            <% if proposal.selected?
+                 button_text = t("admin.legislation.proposals.index.selected")
+                 clas = 'button expanded'
+               else
+                 button_text = t("admin.legislation.proposals.index.select")
+                 clas = 'button hollow expanded'
+               end %>
+            <%= link_to button_text, admin_legislation_process_proposal_path(@process, proposal), method: 'PUT', class: clas %>
+          </td>
+        </tr>
+      <% end %>
+    </tbody>
+  </table>
+
+  <%= paginate proposals %>
+<% end %>
diff --git a/app/views/admin/legislation/proposals/index.html.erb b/app/views/admin/legislation/proposals/index.html.erb
index d5f4c39fe..d8dd407a5 100644
--- a/app/views/admin/legislation/proposals/index.html.erb
+++ b/app/views/admin/legislation/proposals/index.html.erb
@@ -11,44 +11,5 @@
   <%= render 'admin/legislation/processes/subnav', process: @process, active: 'proposals' %>
 
   <%= render 'form' %>
-
-<% if @proposals.any? %>
-  <h3><%= page_entries_info @proposals %></h3>
-
-  <%= render 'shared/wide_order_selector', i18n_namespace: "admin.legislation.processes.proposals" %>
-
-  <table class="stack" id="proposals_table">
-    <thead>
-      <tr>
-        <th class="text-center"><%= t("admin.legislation.proposals.index.id") %></th>
-        <th><%= t("admin.legislation.proposals.index.title") %></th>
-        <th class="text-center"><%= t("admin.legislation.proposals.index.supports") %></th>
-        <th><%= t("admin.legislation.proposals.index.selected") %></th>
-      </tr>
-    </thead>
-
-    <tbody>
-      <% @proposals.each do |proposal| %>
-        <tr id="<%= dom_id(proposal) %>">
-          <td class="text-center"><%= proposal.id %></td>
-          <td><%= proposal.title %></td>
-          <td class="text-center"><%= proposal.cached_votes_up %></td>
-          <td>
-            <% if proposal.selected?
-                 button_text = t("admin.legislation.proposals.index.selected")
-                 clas = 'button expanded'
-               else
-                 button_text = t("admin.legislation.proposals.index.select")
-                 clas = 'button hollow expanded'
-               end %>
-            <%= link_to button_text, admin_legislation_process_proposal_path(@process, proposal), method: 'PUT', class: clas %>
-          </td>
-        </tr>
-      <% end %>
-    </tbody>
-  </table>
-
-  <%= paginate @proposals %>
-<% end %>
-
+  <%= render 'proposals', proposals: @proposals %>
 </div>