consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #4538 from andyjdavis/notificationTranslation

Browse Source 
replace the word message with notification on proposal notification s…
This commit is contained in:
Javi Martín
2021-08-17 14:04:47 +02:00
committed by GitHub
parent 8991d93bd1 4dbc027e53
commit 9c8ee576a2
5 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
config/locales/en/general.yml
View File

@@ -523,7 +523,7 @@ en:
comments: Comments
latest_comments: Latest messages
messages:
send_notification: Send message to proposal followers
send_notification: Send notification to proposal followers
previous_notifications: See previous notifications
polls:
index:
@@ -658,9 +658,9 @@ en:
voted: "You have voted %{answer}"
proposal_notifications:
new:
title: "Send message"
submit_button: "Send message"
info_about_receivers: "This message will be sent to <strong>%{count} people</strong> and it will be visible in %{proposal_page}.<br> Messages are not sent immediately, users will receive periodically an email with all proposal notifications."
title: "Send notification"
submit_button: "Send notification"
info_about_receivers: "This notification will be sent to <strong>%{count} people</strong> and it will be visible in %{proposal_page}.<br> Notifications are not sent immediately, users will periodically receive an email with all proposal notifications."
proposal_page: "the proposal's page"
show:
back: "Go back to my content"

8
config/locales/es/general.yml
View File

@@ -523,7 +523,7 @@ es:
comments: Comentarios
latest_comments: Últimos mensajes
messages:
send_notification: Enviar mensaje a los que siguen la propuesta
send_notification: Enviar notificación a los que siguen la propuesta
previous_notifications: Ver notificaciones anteriores
polls:
index:
@@ -658,9 +658,9 @@ es:
voted: "Has votado %{answer}"
proposal_notifications:
new:
title: "Enviar mensaje"
submit_button: "Enviar mensaje"
info_about_receivers: "Este mensaje se enviará a <strong>%{count} usuarios</strong> y se publicará en %{proposal_page}.<br> El mensaje no se enviará inmediatamente, los usuarios recibirán periódicamente un email con todas las notificaciones de propuestas."
title: "Enviar notificación"
submit_button: "Enviar notificación"
info_about_receivers: "Esta notificación se enviará a <strong>%{count} usuarios</strong> y se publicará en %{proposal_page}.<br> Las notificaciones no se enviarán inmediatamente, los usuarios recibirán periódicamente un email con todas las notificaciones de propuestas."
proposal_page: "la página de la propuesta"
show:
back: "Volver a mi contenido"

4
spec/support/common_actions/notifications.rb
View File

@@ -39,11 +39,11 @@ module Notifications
click_link "Message to users"
end
click_link "Send message to proposal followers"
click_link "Send notification to proposal followers"
fill_in "proposal_notification_title", with: "Thanks for supporting proposal: #{proposal.title}"
fill_in "proposal_notification_body", with: "Please share it with others! #{proposal.summary}"
click_button "Send message"
click_button "Send notification"
expect(page).to have_content "Your message has been sent correctly."
Notification.last

4
spec/system/dashboard/dashboard_spec.rb
View File

@@ -356,13 +356,13 @@ describe "Proposal's dashboard" do
click_link "Message to users"
end
expect(page).to have_link("Send message to proposal followers")
expect(page).to have_link("Send notification to proposal followers")
expect(page).to have_link("See previous notifications")
end
scenario "Dashboard has a link to send message to proposal supporters" do
visit messages_proposal_dashboard_path(proposal)
click_link("Send message to proposal followers")
click_link("Send notification to proposal followers")
fill_in "Title", with: "Thank you for supporting my proposal"
fill_in "Message", with: "Please share it with others!"

10
spec/system/proposal_notifications_spec.rb
View File

@@ -14,7 +14,7 @@ describe "Proposal Notifications" do
click_link "Message to users"
end
click_link "Send message to proposal followers"
click_link "Send notification to proposal followers"
fill_in "proposal_notification_title", with: "Thank you for supporting my proposal"
fill_in "proposal_notification_body", with: "Please share it with "\
@@ -104,7 +104,7 @@ describe "Proposal Notifications" do
login_as(author)
visit new_proposal_notification_path(proposal_id: proposal.id)
expect(page).to have_content "This message will be sent to 7 people and it will "\
expect(page).to have_content "This notification will be sent to 7 people and it will "\
"be visible in the proposal's page"
expect(page).to have_link("the proposal's page", href: proposal_path(proposal,
anchor: "comments"))
@@ -120,7 +120,7 @@ describe "Proposal Notifications" do
login_as(author)
visit new_proposal_notification_path(proposal_id: proposal.id)
expect(page).to have_content "This message will be sent to 7 people and it will "\
expect(page).to have_content "This notification will be sent to 7 people and it will "\
"be visible in the proposal's page"
expect(page).to have_link("the proposal's page", href: proposal_path(proposal,
anchor: "comments"))
@@ -135,7 +135,7 @@ describe "Proposal Notifications" do
login_as(author)
visit new_proposal_notification_path(proposal_id: proposal.id)
expect(page).to have_content "This message will be sent to 1 people and it will "\
expect(page).to have_content "This notification will be sent to 1 people and it will "\
"be visible in the proposal's page"
expect(page).to have_link("the proposal's page", href: proposal_path(proposal,
anchor: "comments"))
@@ -159,7 +159,7 @@ describe "Proposal Notifications" do
click_link "Message to users"
end
expect(page).to have_link "Send message to proposal followers"
expect(page).to have_link "Send notification to proposal followers"
end
scenario "Accessing form directly" do