Avoid side-effects when removing username message
In the registration form, after changing the username, we were removing the message about whether a username was available. However, we were also removing every `<small>` tag on the page. This affected the demo branch, where we add a `<small>` tag on every page. So we're now removing a specific element instead.
This commit is contained in:
@@ -5,12 +5,16 @@
|
||||
var clearUsernameMessage, showUsernameMessage, usernameInput, validateUsername;
|
||||
usernameInput = $("form#new_user[action=\"/users\"] input#user_username");
|
||||
clearUsernameMessage = function() {
|
||||
$("small").remove();
|
||||
$("form#new_user .username-message").remove();
|
||||
};
|
||||
showUsernameMessage = function(response) {
|
||||
var klass;
|
||||
klass = response.available ? "no-error" : "error";
|
||||
usernameInput.after($("<small class=\"" + klass + "\" style=\"margin-top: -16px;\">" + response.message + "</small>"));
|
||||
usernameInput.after($(
|
||||
"<small class=\"username-message " + klass + "\" style=\"margin-top: -16px;\">" +
|
||||
response.message +
|
||||
"</small>"
|
||||
));
|
||||
};
|
||||
validateUsername = function(username) {
|
||||
var request;
|
||||
|
||||
Reference in New Issue
Block a user