From 9a625fe59fe313d370aaff64639aa048a35d4b23 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Wed, 12 Jan 2022 15:32:31 +0100
Subject: [PATCH] Remove redundant "participation not allowed" code

Very similar code is present in the `votes.js` file. Since the only
elements with the `js-participation-not-allowed` class also matched the
`div.supports div.participation-not-allowed` selector, for these
elements the events were executed twice.

So we can get rid of the `js-participation` class alongside all the
JavaScript code referencing it.
---
 app/assets/javascripts/allow_participation.js     | 15 ---------------
 app/assets/javascripts/application.js             |  2 --
 .../budgets/investments/ballot_component.html.erb |  4 ++--
 .../budgets/investments/votes_component.html.erb  |  4 ++--
 .../budgets/investments/_investment.html.erb      |  2 +-
 5 files changed, 5 insertions(+), 22 deletions(-)
 delete mode 100644 app/assets/javascripts/allow_participation.js

diff --git a/app/assets/javascripts/allow_participation.js b/app/assets/javascripts/allow_participation.js
deleted file mode 100644
index b6223a47c..000000000
--- a/app/assets/javascripts/allow_participation.js
+++ /dev/null
@@ -1,15 +0,0 @@
-(function() {
-  "use strict";
-  App.AllowParticipation = {
-    initialize: function() {
-      $(document).on({
-        "mouseenter focus": function() {
-          $(this).find(".js-participation-not-allowed").show();
-        },
-        mouseleave: function() {
-          $(this).find(".js-participation-not-allowed").hide();
-        }
-      }, ".js-participation");
-    }
-  };
-}).call(this);
diff --git a/app/assets/javascripts/application.js b/app/assets/javascripts/application.js
index 71b2ac9ce..0521eac84 100644
--- a/app/assets/javascripts/application.js
+++ b/app/assets/javascripts/application.js
@@ -66,7 +66,6 @@
 //= require tags
 //= require users
 //= require votes
-//= require allow_participation
 //= require advanced_search
 //= require registration_form
 //= require suggest
@@ -124,7 +123,6 @@ var initialize_modules = function() {
   App.Comments.initialize();
   App.Users.initialize();
   App.Votes.initialize();
-  App.AllowParticipation.initialize();
   App.Tags.initialize();
   App.FoundationExtras.initialize();
   App.LocationChanger.initialize();
diff --git a/app/components/budgets/investments/ballot_component.html.erb b/app/components/budgets/investments/ballot_component.html.erb
index 0bf6ee56a..4d3868666 100644
--- a/app/components/budgets/investments/ballot_component.html.erb
+++ b/app/components/budgets/investments/ballot_component.html.erb
@@ -1,4 +1,4 @@
-<div class="js-participation supports ballot">
+<div class="supports ballot">
   <% if voted? %>
     <div class="remove supported">
       <span class="icon-check-circle"
@@ -36,7 +36,7 @@
   <% end %>
 
   <% if reason.present? && !voted? %>
-    <div class="js-participation-not-allowed participation-not-allowed" style="display:none">
+    <div class="participation-not-allowed" style="display:none">
       <p>
         <small>
           <%= sanitize(t("budgets.ballots.reasons_for_not_balloting.#{reason}",
diff --git a/app/components/budgets/investments/votes_component.html.erb b/app/components/budgets/investments/votes_component.html.erb
index 941b619b4..ef88aed4f 100644
--- a/app/components/budgets/investments/votes_component.html.erb
+++ b/app/components/budgets/investments/votes_component.html.erb
@@ -1,4 +1,4 @@
-<div class="supports js-participation">
+<div class="supports">
 
   <span class="total-supports <%= "no-button" unless voting_allowed? || user_voted_for? %>">
     <%= t("budgets.investments.investment.supports", count: investment.total_votes) %>
@@ -36,7 +36,7 @@
 
   <% if reason.present? && !user_voted_for? %>
     <div tabindex="0">
-      <div class="js-participation-not-allowed participation-not-allowed" style="display:none" aria-hidden="false">
+      <div class="participation-not-allowed" style="display:none" aria-hidden="false">
         <p>
           <small>
             <%= sanitize(t("votes.budget_investments.#{reason}",
diff --git a/app/views/budgets/investments/_investment.html.erb b/app/views/budgets/investments/_investment.html.erb
index ce342c8a2..fea6b4241 100644
--- a/app/views/budgets/investments/_investment.html.erb
+++ b/app/views/budgets/investments/_investment.html.erb
@@ -39,7 +39,7 @@
         <% elsif investment.should_show_vote_count? %>
           <div id="<%= dom_id(investment) %>_votes"
                class="small-12 medium-3 column text-center">
-            <div class="supports js-participation">
+            <div class="supports">
               <span class="total-supports no-button">
                 <%= t("budgets.investments.investment.supports",
                     count: investment.total_votes) %>