From 9a093d5f8a86953c12785bc60e560e88cec2ab52 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Wed, 7 Nov 2018 11:24:32 +0100
Subject: [PATCH] Use `let` instead of instance variables

---
 .../budget_investment_milestones_spec.rb      | 24 +++++++++----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/spec/features/admin/budget_investment_milestones_spec.rb b/spec/features/admin/budget_investment_milestones_spec.rb
index eaae5a55e..28b05ff03 100644
--- a/spec/features/admin/budget_investment_milestones_spec.rb
+++ b/spec/features/admin/budget_investment_milestones_spec.rb
@@ -5,10 +5,10 @@ feature 'Admin budget investment milestones' do
   background do
     admin = create(:administrator)
     login_as(admin.user)
-
-    @investment = create(:budget_investment)
   end
 
+  let!(:investment) { create(:budget_investment) }
+
   it_behaves_like "translatable",
                   "milestone",
                   "edit_admin_budget_budget_investment_milestone_path",
@@ -16,11 +16,11 @@ feature 'Admin budget investment milestones' do
 
   context "Index" do
     scenario 'Displaying milestones' do
-      milestone = create(:milestone, milestoneable: @investment)
+      milestone = create(:milestone, milestoneable: investment)
       create(:image, imageable: milestone)
       document = create(:document, documentable: milestone)
 
-      visit admin_budget_budget_investment_path(@investment.budget, @investment)
+      visit admin_budget_budget_investment_path(investment.budget, investment)
 
       expect(page).to have_content("Milestone")
       expect(page).to have_content(milestone.title)
@@ -32,7 +32,7 @@ feature 'Admin budget investment milestones' do
     end
 
     scenario 'Displaying no_milestones text' do
-      visit admin_budget_budget_investment_path(@investment.budget, @investment)
+      visit admin_budget_budget_investment_path(investment.budget, investment)
 
       expect(page).to have_content("Milestone")
       expect(page).to have_content("Don't have defined milestones")
@@ -42,7 +42,7 @@ feature 'Admin budget investment milestones' do
   context "New" do
     scenario "Add milestone" do
       status = create(:milestone_status)
-      visit admin_budget_budget_investment_path(@investment.budget, @investment)
+      visit admin_budget_budget_investment_path(investment.budget, investment)
 
       click_link 'Create new milestone'
 
@@ -58,14 +58,14 @@ feature 'Admin budget investment milestones' do
     end
 
     scenario "Status select is disabled if there are no statuses available" do
-      visit admin_budget_budget_investment_path(@investment.budget, @investment)
+      visit admin_budget_budget_investment_path(investment.budget, investment)
 
       click_link 'Create new milestone'
       expect(find("#milestone_status_id").disabled?).to be true
     end
 
     scenario "Show validation errors on milestone form" do
-      visit admin_budget_budget_investment_path(@investment.budget, @investment)
+      visit admin_budget_budget_investment_path(investment.budget, investment)
 
       click_link 'Create new milestone'
 
@@ -82,11 +82,11 @@ feature 'Admin budget investment milestones' do
 
   context "Edit" do
     scenario "Change title, description and document names" do
-      milestone = create(:milestone, milestoneable: @investment)
+      milestone = create(:milestone, milestoneable: investment)
       create(:image, imageable: milestone)
       document = create(:document, documentable: milestone)
 
-      visit admin_budget_budget_investment_path(@investment.budget, @investment)
+      visit admin_budget_budget_investment_path(investment.budget, investment)
       expect(page).to have_link document.title
 
       click_link milestone.title
@@ -108,9 +108,9 @@ feature 'Admin budget investment milestones' do
 
   context "Delete" do
     scenario "Remove milestone" do
-      milestone = create(:milestone, milestoneable: @investment, title: "Title will it remove")
+      milestone = create(:milestone, milestoneable: investment, title: "Title will it remove")
 
-      visit admin_budget_budget_investment_path(@investment.budget, @investment)
+      visit admin_budget_budget_investment_path(investment.budget, investment)
 
       click_link "Delete milestone"