From 95958b2080cad072cb58bab8bf94395cda3cfd56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sun, 15 Oct 2023 14:47:53 +0200 Subject: [PATCH] Remove title attribute in fields to accept terms Not sure why we introduced these titles in commit 9dce52a69. The title attributes contained the same text as the label, which IMHO made them useless. --- app/components/budgets/investments/form_component.html.erb | 1 - app/components/debates/form_component.html.erb | 1 - app/components/proposals/form_component.html.erb | 1 - app/views/legislation/proposals/_form.html.erb | 1 - app/views/organizations/registrations/new.html.erb | 1 - app/views/users/registrations/new.html.erb | 1 - app/views/verification/residence/new.html.erb | 1 - config/locales/en/devise_views.yml | 1 - config/locales/en/general.yml | 1 - config/locales/en/verification.yml | 1 - config/locales/es/devise_views.yml | 1 - config/locales/es/general.yml | 1 - config/locales/es/verification.yml | 1 - 13 files changed, 13 deletions(-) diff --git a/app/components/budgets/investments/form_component.html.erb b/app/components/budgets/investments/form_component.html.erb index 7e0c52280..25a886bd8 100644 --- a/app/components/budgets/investments/form_component.html.erb +++ b/app/components/budgets/investments/form_component.html.erb @@ -90,7 +90,6 @@ <% unless current_user.manager? || investment.persisted? %>
<%= f.check_box :terms_of_service, - title: t("form.accept_terms_title"), label: t("form.accept_terms", policy: link_to(t("form.policy"), "/privacy", target: "_blank"), conditions: link_to(t("form.conditions"), "/conditions", target: "_blank")) %> diff --git a/app/components/debates/form_component.html.erb b/app/components/debates/form_component.html.erb index e0f14ef06..5df529206 100644 --- a/app/components/debates/form_component.html.erb +++ b/app/components/debates/form_component.html.erb @@ -42,7 +42,6 @@ <% if debate.new_record? %>
<%= f.check_box :terms_of_service, - title: t("form.accept_terms_title"), label: t("form.accept_terms", policy: link_to(t("form.policy"), "/privacy", target: "_blank"), conditions: link_to(t("form.conditions"), "/conditions", target: "_blank")) %> diff --git a/app/components/proposals/form_component.html.erb b/app/components/proposals/form_component.html.erb index 7884aa270..b77eba8a7 100644 --- a/app/components/proposals/form_component.html.erb +++ b/app/components/proposals/form_component.html.erb @@ -97,7 +97,6 @@ <% if proposal.new_record? %>
<%= f.check_box :terms_of_service, - title: t("form.accept_terms_title"), label: t("form.accept_terms", policy: link_to(t("form.policy"), "/privacy", target: "_blank"), conditions: link_to(t("form.conditions"), "/conditions", target: "_blank")) %> diff --git a/app/views/legislation/proposals/_form.html.erb b/app/views/legislation/proposals/_form.html.erb index 03e905aee..179d1bb4b 100644 --- a/app/views/legislation/proposals/_form.html.erb +++ b/app/views/legislation/proposals/_form.html.erb @@ -63,7 +63,6 @@
<% if @proposal.new_record? %> <%= f.check_box :terms_of_service, - title: t("form.accept_terms_title"), label: t("form.accept_terms", policy: link_to(t("form.policy"), "/privacy", target: "_blank"), conditions: link_to(t("form.conditions"), "/conditions", target: "_blank")) %> diff --git a/app/views/organizations/registrations/new.html.erb b/app/views/organizations/registrations/new.html.erb index b36fba601..a850766e2 100644 --- a/app/views/organizations/registrations/new.html.erb +++ b/app/views/organizations/registrations/new.html.erb @@ -25,7 +25,6 @@ label: t("devise_views.organizations.registrations.new.password_confirmation_label") %> <%= f.check_box :terms_of_service, - title: t("devise_views.users.registrations.new.terms_title"), label: t("devise_views.users.registrations.new.terms", terms: link_to(t("devise_views.users.registrations.new.terms_link"), "/conditions", diff --git a/app/views/users/registrations/new.html.erb b/app/views/users/registrations/new.html.erb index 0afca1696..cdb376fb7 100644 --- a/app/views/users/registrations/new.html.erb +++ b/app/views/users/registrations/new.html.erb @@ -35,7 +35,6 @@ <% end %> <%= f.check_box :terms_of_service, - title: t("devise_views.users.registrations.new.terms_title"), label: t("devise_views.users.registrations.new.terms", terms: link_to(t("devise_views.users.registrations.new.terms_link"), "/conditions", diff --git a/app/views/verification/residence/new.html.erb b/app/views/verification/residence/new.html.erb index b528598f9..1dbcee3e3 100644 --- a/app/views/verification/residence/new.html.erb +++ b/app/views/verification/residence/new.html.erb @@ -69,7 +69,6 @@
<%= f.check_box :terms_of_service, - title: t("verification.residence.new.accept_terms_text_title"), label: t("verification.residence.new.accept_terms_text", terms_url: link_to(t("verification.residence.new.terms"), page_path("census_terms"), diff --git a/config/locales/en/devise_views.yml b/config/locales/en/devise_views.yml index 7e184e028..85e95184f 100644 --- a/config/locales/en/devise_views.yml +++ b/config/locales/en/devise_views.yml @@ -103,7 +103,6 @@ en: submit: Register terms: By registering you accept the %{terms} terms_link: terms and conditions of use - terms_title: By registering you accept the terms and conditions of use title: Register username_is_available: Username available username_is_not_available: Username already in use diff --git a/config/locales/en/general.yml b/config/locales/en/general.yml index 0be47b5a9..4f58a19c3 100644 --- a/config/locales/en/general.yml +++ b/config/locales/en/general.yml @@ -143,7 +143,6 @@ en: poll_ended: "Cannot be changed if voting has already ended" form: accept_terms: I agree to the %{policy} and the %{conditions} - accept_terms_title: I agree to the Privacy Policy and the Terms and conditions of use conditions: Terms and conditions of use debate: Debate direct_message: private message diff --git a/config/locales/en/verification.yml b/config/locales/en/verification.yml index 7b6ac56ee..7e6d33f79 100644 --- a/config/locales/en/verification.yml +++ b/config/locales/en/verification.yml @@ -46,7 +46,6 @@ en: success: Residence verified new: accept_terms_text: I accept %{terms_url} of the Census - accept_terms_text_title: I accept the terms and conditions of access of the Census document_number: Document number document_number_help_title: Help document_number_help_text: "DNI: 12345678A
Passport: AAA000001
Residence card: X1234567P" diff --git a/config/locales/es/devise_views.yml b/config/locales/es/devise_views.yml index da16e7421..5e3d5a40e 100644 --- a/config/locales/es/devise_views.yml +++ b/config/locales/es/devise_views.yml @@ -103,7 +103,6 @@ es: submit: Registrarse terms: Al registrarte aceptas las %{terms} terms_link: condiciones de uso - terms_title: Al registrarte aceptas las condiciones de uso title: Registrarse username_is_available: Nombre de usuario disponible username_is_not_available: Nombre de usuario ya existente diff --git a/config/locales/es/general.yml b/config/locales/es/general.yml index e40c5b43d..dd2380dbd 100644 --- a/config/locales/es/general.yml +++ b/config/locales/es/general.yml @@ -143,7 +143,6 @@ es: poll_ended: "No puede ser cambiada si la votación ha acabado" form: accept_terms: Acepto la %{policy} y las %{conditions} - accept_terms_title: Acepto la Política de privacidad y las Condiciones de uso conditions: Condiciones de uso debate: el debate direct_message: el mensaje privado diff --git a/config/locales/es/verification.yml b/config/locales/es/verification.yml index 4f52a3d5a..75d909f11 100644 --- a/config/locales/es/verification.yml +++ b/config/locales/es/verification.yml @@ -46,7 +46,6 @@ es: success: Residencia verificada new: accept_terms_text: Acepto %{terms_url} al Padrón - accept_terms_text_title: Acepto los términos de acceso al Padrón document_number: Número de documento document_number_help_title: Ayuda document_number_help_text: "DNI: 12345678A
Pasaporte: AAA000001
Tarjeta de residencia: X1234567P"