From 94ccae91a45273007e0b312117dbfe1f18d0edfa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= Date: Tue, 15 Sep 2015 14:59:07 +0200 Subject: [PATCH] refactors helper method --- app/helpers/votes_helper.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/helpers/votes_helper.rb b/app/helpers/votes_helper.rb index c4c3d76a1..dc1df0396 100644 --- a/app/helpers/votes_helper.rb +++ b/app/helpers/votes_helper.rb @@ -1,11 +1,15 @@ module VotesHelper + def debate_percentage_of_likes(debate) + debate.likes.percent_of(debate.total_votes) + end + def votes_percentage(vote, debate) return "0%" if debate.total_votes == 0 if vote == 'likes' - debate.likes.percent_of(debate.total_votes).to_s + "%" + debate_percentage_of_likes(debate).to_s + "%" elsif vote == 'dislikes' - (100 - debate.likes.percent_of(debate.total_votes)).to_s + "%" + (100 - debate_percentage_of_likes(debate)).to_s + "%" end end