consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #4555 from consul/flaky_recount_spec

Browse Source 
Fix flaky poll recount spec
This commit is contained in:
Javi Martín
2021-06-22 18:30:14 +02:00
committed by GitHub
parent 83ed54dff5 5f747122c5
commit 918276ec70
3 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spec/models/poll/partial_result_spec.rb
View File

@@ -39,19 +39,23 @@ describe Poll::PartialResult do
expect(partial_result.officer_assignment_id_log).to eq("") expect(partial_result.officer_assignment_id_log).to eq("")
partial_result.amount = 33 partial_result.amount = 33
partial_result.officer_assignment = create(:poll_officer_assignment, id: 10) first_assignment = create(:poll_officer_assignment)
partial_result.officer_assignment = first_assignment
partial_result.save! partial_result.save!
partial_result.amount = 32 partial_result.amount = 32
partial_result.officer_assignment = create(:poll_officer_assignment, id: 20) second_assignment = create(:poll_officer_assignment)
partial_result.officer_assignment = second_assignment
partial_result.save! partial_result.save!
partial_result.amount = 34 partial_result.amount = 34
partial_result.officer_assignment = create(:poll_officer_assignment, id: 30) partial_result.officer_assignment = create(:poll_officer_assignment)
partial_result.save! partial_result.save!
expect(partial_result.amount_log).to eq(":33:32") expect(partial_result.amount_log).to eq(":33:32")
expect(partial_result.officer_assignment_id_log).to eq(":10:20") expect(partial_result.officer_assignment_id_log).to eq(
":#{first_assignment.id}:#{second_assignment.id}"
)
end end
it "updates author_id if amount changes" do it "updates author_id if amount changes" do

12
spec/models/poll/recount_spec.rb
View File

@@ -58,19 +58,23 @@ describe Poll::Recount do
expect(poll_recount.officer_assignment_id_log).to eq("") expect(poll_recount.officer_assignment_id_log).to eq("")
poll_recount.white_amount = 33 poll_recount.white_amount = 33
poll_recount.officer_assignment = create(:poll_officer_assignment, id: 101) second_assignment = create(:poll_officer_assignment)
poll_recount.officer_assignment = second_assignment
poll_recount.save! poll_recount.save!
poll_recount.white_amount = 32 poll_recount.white_amount = 32
poll_recount.officer_assignment = create(:poll_officer_assignment, id: 102) third_assignment = create(:poll_officer_assignment)
poll_recount.officer_assignment = third_assignment
poll_recount.save! poll_recount.save!
poll_recount.white_amount = 34 poll_recount.white_amount = 34
poll_recount.officer_assignment = create(:poll_officer_assignment, id: 103) poll_recount.officer_assignment = create(:poll_officer_assignment)
poll_recount.save! poll_recount.save!
expect(poll_recount.white_amount_log).to eq(":0:33:32") expect(poll_recount.white_amount_log).to eq(":0:33:32")
expect(poll_recount.officer_assignment_id_log).to eq(":#{officer_assignment.id}:101:102") expect(poll_recount.officer_assignment_id_log).to eq(
":#{officer_assignment.id}:#{second_assignment.id}:#{third_assignment.id}"
)
end end
it "updates author_id if amount changes" do it "updates author_id if amount changes" do

2
spec/system/officing/voters_spec.rb
View File

@@ -160,7 +160,7 @@ describe "Voters" do
end end
scenario "Store officer and booth information" do scenario "Store officer and booth information" do
create(:user, :in_census, id: rand(9999999)) create(:user, :in_census)
poll1 = create(:poll, name: "¿Quieres que XYZ sea aprobado?") poll1 = create(:poll, name: "¿Quieres que XYZ sea aprobado?")
poll2 = create(:poll, name: "Pregunta de votación de prueba") poll2 = create(:poll, name: "Pregunta de votación de prueba")