Redirect to referer after destroying an image
The same way we do for documents. This way we avoid a possible unprotected redirect.
This commit is contained in:
17
spec/controllers/images_controller_spec.rb
Normal file
17
spec/controllers/images_controller_spec.rb
Normal file
@@ -0,0 +1,17 @@
|
||||
require "rails_helper"
|
||||
|
||||
describe ImagesController do
|
||||
let(:user) { create(:user) }
|
||||
before { sign_in user }
|
||||
|
||||
describe "DELETE destroy" do
|
||||
it "redirects to the referer URL" do
|
||||
image = create(:image, imageable: create(:proposal, author: user))
|
||||
request.env["HTTP_REFERER"] = "/proposals"
|
||||
|
||||
delete :destroy, params: { id: image, from: "http://evil.dev" }
|
||||
|
||||
expect(response).to redirect_to "/proposals"
|
||||
end
|
||||
end
|
||||
end
|
||||
Reference in New Issue
Block a user