consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix duplicate support_title I18n key

Browse Source 
The key was declared twice and so the first one ("Support this project")
was overwritten.

We're grouping all keys related to the investment list together in order
to reduce the chances of this issue happening again (or, at least, in
this part of the code).
This commit is contained in:
Javi Martín
2021-06-12 13:20:39 +02:00
parent 59ee3d1215
commit 8b1e48b4ea
5 changed files with 20 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/components/budgets/investment_component.html.erb
View File

@@ -8,12 +8,12 @@
<% if investment.should_show_vote_count? || investment.should_show_price? %>
<div class="supports-and-price">
<% if investment.should_show_vote_count? %>
<span class="supports-title"><%= t("budgets.investments.investment.support_title") %></span>
<span class="supports-title"><%= t("budgets.investments_list.investment.supports") %></span>
<strong><%= investment.total_votes %></strong>
<% end %>
<% if investment.should_show_price? %>
<span class="price-title"><%= t("budgets.investments.investment.price_title") %></span>
<span class="price-title"><%= t("budgets.investments_list.investment.price") %></span>
<strong><%= investment.formatted_price %></strong>
<% end %>
</div>
@@ -26,7 +26,7 @@
<%= render Budgets::Investments::InfoComponent.new(investment) %>
<%= link_to namespaced_budget_investment_path(investment), class: "read-more" do %>
<small><%= t("budgets.investments.index.read_more") %></small>
<small><%= t("budgets.investments_list.investment.read_more") %></small>
<% end %>
<% end %>
</div>

4
app/components/budgets/investments_list_component.html.erb
View File

@@ -1,7 +1,7 @@
<% if investments.any? %>
<section class="investments-list">
<header>
<h2><%= t("budgets.show.investments_list") %></h2>
<h2><%= t("budgets.investments_list.title") %></h2>
</header>
<% investments.each do |investment| %>
@@ -13,7 +13,7 @@
<% unless budget.informing? %>
<div class="row margin-top">
<div class="small-12 medium-6 large-4 small-centered column margin-top">
<%= link_to t("budgets.show.see_all_investments"),
<%= link_to t("budgets.investments_list.see_all"),
budget_investments_path(budget),
class: "button expanded" %>
</div>