consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add and apply rules for multi-line hashes

Browse Source 
For the HashAlignment rule, we're using the default `key` style (keys
are aligned and values aren't) instead of the `table` style (both keys
and values are aligned) because, even if we used both in the
application, we used the `key` style a lot more. Furthermore, the
`table` style looks strange in places where there are both very long and
very short keys and sometimes we weren't even consistent with the
`table` style, aligning some keys without aligning other keys.

Ideally we could align hashes to "either key or table", so developers
can decide whether keeping the symmetry of the code is worth it in a
case-per-case basis, but Rubocop doesn't allow this option.
This commit is contained in:
Javi Martín
2023-07-01 16:17:33 +02:00
parent 97aca0cf95
commit 8b13daad95
130 changed files with 676 additions and 592 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
spec/models/poll/poll_spec.rb
View File

@@ -104,45 +104,52 @@ describe Poll do
it "is valid when overlapping but different proposals" do
other_proposal = create(:proposal)
_other_poll = create(:poll, related: other_proposal, starts_at: poll.starts_at,
ends_at: poll.ends_at)
_other_poll = create(:poll, related: other_proposal,
starts_at: poll.starts_at,
ends_at: poll.ends_at)
expect(poll).to be_valid
end
it "is valid when same proposal but not overlapping" do
_other_poll = create(:poll, related: proposal, starts_at: poll.ends_at + 1.day,
ends_at: poll.ends_at + 8.days)
_other_poll = create(:poll, related: proposal,
starts_at: poll.ends_at + 1.day,
ends_at: poll.ends_at + 8.days)
expect(poll).to be_valid
end
it "is not valid when overlaps from the beginning" do
_other_poll = create(:poll, related: proposal, starts_at: poll.starts_at - 8.days,
ends_at: poll.starts_at)
_other_poll = create(:poll, related: proposal,
starts_at: poll.starts_at - 8.days,
ends_at: poll.starts_at)
expect(poll).not_to be_valid
end
it "is not valid when overlaps from the end" do
_other_poll = create(:poll, related: proposal, starts_at: poll.ends_at,
ends_at: poll.ends_at + 8.days)
_other_poll = create(:poll, related: proposal,
starts_at: poll.ends_at,
ends_at: poll.ends_at + 8.days)
expect(poll).not_to be_valid
end
it "is not valid when overlaps with same interval" do
_other_poll = create(:poll, related: proposal, starts_at: poll.starts_at,
ends_at: poll.ends_at)
_other_poll = create(:poll, related: proposal,
starts_at: poll.starts_at,
ends_at: poll.ends_at)
expect(poll).not_to be_valid
end
it "is not valid when overlaps with interval contained" do
_other_poll = create(:poll, related: proposal, starts_at: poll.starts_at + 1.day,
ends_at: poll.ends_at - 1.day)
_other_poll = create(:poll, related: proposal,
starts_at: poll.starts_at + 1.day,
ends_at: poll.ends_at - 1.day)
expect(poll).not_to be_valid
end
it "is not valid when overlaps with interval containing" do
_other_poll = create(:poll, related: proposal, starts_at: poll.starts_at - 8.days,
ends_at: poll.ends_at + 8.days)
_other_poll = create(:poll, related: proposal,
starts_at: poll.starts_at - 8.days,
ends_at: poll.ends_at + 8.days)
expect(poll).not_to be_valid
end
end