From 879cc2571fe449f8addef8ecd575b6c03628208e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sun, 30 Jun 2019 02:13:51 +0200 Subject: [PATCH] Use different names for variable and parameter Using the same name means from that point the name doesn't refer to the original parameter, which might be confusing when reading the method. --- app/assets/javascripts/documentable.js.coffee | 8 ++++---- app/assets/javascripts/imageable.js.coffee | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/app/assets/javascripts/documentable.js.coffee b/app/assets/javascripts/documentable.js.coffee index dd7f8c516..4ef23aba5 100644 --- a/app/assets/javascripts/documentable.js.coffee +++ b/app/assets/javascripts/documentable.js.coffee @@ -28,10 +28,10 @@ App.Documentable = formData: null add: (e, data) -> - data = App.Documentable.buildFileUploadData(e, data) - App.Documentable.clearProgressBar(data) - App.Documentable.setProgressBar(data, "uploading") - data.submit() + upload_data = App.Documentable.buildFileUploadData(e, data) + App.Documentable.clearProgressBar(upload_data) + App.Documentable.setProgressBar(upload_data, "uploading") + upload_data.submit() change: (e, data) -> data.files.forEach (file) -> diff --git a/app/assets/javascripts/imageable.js.coffee b/app/assets/javascripts/imageable.js.coffee index 5610395f6..37c50b8b2 100644 --- a/app/assets/javascripts/imageable.js.coffee +++ b/app/assets/javascripts/imageable.js.coffee @@ -29,10 +29,10 @@ App.Imageable = formData: null add: (e, data) -> - data = App.Imageable.buildFileUploadData(e, data) - App.Imageable.clearProgressBar(data) - App.Imageable.setProgressBar(data, "uploading") - data.submit() + upload_data = App.Imageable.buildFileUploadData(e, data) + App.Imageable.clearProgressBar(upload_data) + App.Imageable.setProgressBar(upload_data, "uploading") + upload_data.submit() change: (e, data) -> data.files.forEach (file) ->