consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify code setting marker data in maps

Browse Source 
We were probably setting them separately to avoid having blank data
attributes in the HTML. However, when a data attribute is `nil`, Rails
doesn't write it in the HTML in the first place.
This commit is contained in:
Javi Martín
2023-03-07 18:45:15 +01:00
parent e00aa807b9
commit 84fff2e9fb
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/components/shared/map_location_component.rb
View File

@@ -44,7 +44,7 @@ class Shared::MapLocationComponent < ApplicationComponent
end end
def data def data
options = { {
map: "", map: "",
map_center_latitude: latitude, map_center_latitude: latitude,
map_center_longitude: longitude, map_center_longitude: longitude,
@@ -56,10 +56,9 @@ class Shared::MapLocationComponent < ApplicationComponent
latitude_input_selector: "##{map_location_input_id(parent_class, "latitude")}", latitude_input_selector: "##{map_location_input_id(parent_class, "latitude")}",
longitude_input_selector: "##{map_location_input_id(parent_class, "longitude")}", longitude_input_selector: "##{map_location_input_id(parent_class, "longitude")}",
zoom_input_selector: "##{map_location_input_id(parent_class, "zoom")}", zoom_input_selector: "##{map_location_input_id(parent_class, "zoom")}",
marker_investments_coordinates: investments_coordinates marker_investments_coordinates: investments_coordinates,
marker_latitude: map_location.latitude.presence,
marker_longitude: map_location.longitude.presence
} }
options[:marker_latitude] = map_location.latitude if map_location.latitude.present?
options[:marker_longitude] = map_location.longitude if map_location.longitude.present?
options
end end
end end