From 84bec1241f3ea0e74640b5a80b9aad8c08730466 Mon Sep 17 00:00:00 2001 From: taitus Date: Tue, 19 Nov 2024 15:15:57 +0100 Subject: [PATCH] Remove redundant "loading-bar.errors" In the imageable_attach_new_file method used in this tests the: > expect(page).to have_css ".loading-bar.errors" is already being checked. Therefore, to leave only the line: > imageable_attach_new_file(file_fixture("logo_header.png"), false) in the test, since there is another test that verifies it, I think we can remove the test altogether. --- spec/system/nested_imageable_spec.rb | 6 ------ 1 file changed, 6 deletions(-) diff --git a/spec/system/nested_imageable_spec.rb b/spec/system/nested_imageable_spec.rb index 2675088cc..22a027fa5 100644 --- a/spec/system/nested_imageable_spec.rb +++ b/spec/system/nested_imageable_spec.rb @@ -81,12 +81,6 @@ describe "Nested imageable" do end end - scenario "Should update loading bar style after invalid file upload" do - imageable_attach_new_file(file_fixture("logo_header.png"), false) - - expect(page).to have_css ".loading-bar.errors" - end - scenario "Should update image cached_attachment field after valid file upload" do click_link "Add image"