+
+ <%= render "shared/stats/links", stats: @stats %>
-
-
-
<%= t("polls.show.stats.total_participation") %>
+
+ <%= render "shared/stats/participation", stats: @stats %>
-
- <%= t("polls.show.stats.total_votes") %>
- <%= @stats[:total_participants] %>
-
+
+
<%= t("stats.advanced") %>
-
-
-
- | <%= t("polls.show.stats.votes") %> |
- <%= t("polls.show.stats.web") %> |
- <%= t("polls.show.stats.booth") %> |
- <%= t("polls.show.stats.total") %> |
-
-
-
-
- | <%= t("polls.show.stats.valid") %> |
-
- <%= @stats[:total_web_valid] %>
- (<%= @stats[:valid_percentage_web].round(2) %>%)
- |
-
- <%= @stats[:total_booth_valid] %>
- (<%= @stats[:valid_percentage_booth].round(2) %>%)
- |
-
- <%= @stats[:total_valid_votes] %>
- (<%= @stats[:total_valid_percentage].round(2) %>%)
- |
-
-
- | <%= t("polls.show.stats.white") %> |
-
- <%= @stats[:total_web_white] %>
- (<%= @stats[:white_percentage_web].round(2) %>%)
- |
-
- <%= @stats[:total_booth_white] %>
- (<%= @stats[:white_percentage_booth].round(2) %>%)
- |
- <%= @stats[:total_white_votes] %>
- (<%= @stats[:total_white_percentage].round(2) %>%)
- |
-
-
- | <%= t("polls.show.stats.null_votes") %> |
-
- <%= @stats[:total_web_null] %>
- (<%= @stats[:null_percentage_web].round(2) %>%)
- |
-
- <%= @stats[:total_booth_null] %>
- (<%= @stats[:null_percentage_booth].round(2) %>%)
- |
-
- <%= @stats[:total_null_votes] %>
- (<%= @stats[:total_null_percentage].round(2) %>%)
- |
-
-
- | <%= t("polls.show.stats.total") %> |
-
- <%= @stats[:total_participants_web] %>
- (<%= @stats[:total_participants_web_percentage].round(2) %>%)
- |
-
- <%= @stats[:total_participants_booth] %>
- (<%= @stats[:total_participants_booth_percentage].round(2) %>%)
- |
- <%= @stats[:total_participants] %> |
-
-
-
+
+
<%= t("stats.polls.by_channel") %>
+
+ <% @stats.channels.each do |channel| %>
+ <%= number_with_info_tags(
+ @stats.send("total_participants_#{channel}"),
+ t("stats.polls.#{channel}_percentage",
+ percentage: number_to_stats_percentage(@stats.send(:"total_participants_#{channel}_percentage"))
+ ),
+ html_class: channel
+ ) %>
+ <% end %>
+
+
+
+
<%= t("stats.polls.vote_by_channel") %>
+
+
+
+
+ | <%= t("polls.show.stats.votes") %> |
+ <% @stats.channels.each do |channel| %>
+ <%= t("polls.show.stats.#{channel}") %> |
+ <% end %>
+ <%= t("polls.show.stats.total") %> |
+
+
+
+
+ | <%= t("polls.show.stats.valid") %> |
+
+ <% @stats.channels.each do |channel| %>
+
+ <%= @stats.send(:"total_#{channel}_valid") %>
+ (<%= @stats.send(:"valid_percentage_#{channel}").round(2) %>%)
+ |
+ <% end %>
+
+
+ <%= @stats.total_valid_votes %>
+ (<%= @stats.total_valid_percentage.round(2) %>%)
+ |
+
+
+
+ | <%= t("polls.show.stats.white") %> |
+
+ <% @stats.channels.each do |channel| %>
+
+ <%= @stats.send(:"total_#{channel}_white") %>
+ (<%= @stats.send(:"white_percentage_#{channel}").round(2) %>%)
+ |
+ <% end %>
+
+ <%= @stats.total_white_votes %>
+ (<%= @stats.total_white_percentage.round(2) %>%)
+ |
+
+
+ | <%= t("polls.show.stats.null_votes") %> |
+
+ <% @stats.channels.each do |channel| %>
+
+ <%= @stats.send(:"total_#{channel}_null") %>
+ (<%= @stats.send(:"null_percentage_#{channel}").round(2) %>%)
+ |
+ <% end %>
+
+
+ <%= @stats.total_null_votes %>
+ (<%= @stats.total_null_percentage.round(2) %>%)
+ |
+
+
+ | <%= t("polls.show.stats.total") %> |
+
+ <% @stats.channels.each do |channel| %>
+
+ <%= @stats.send(:"total_participants_#{channel}") %>
+ (<%= @stats.send(:"total_participants_#{channel}_percentage").round(2) %>%)
+ |
+ <% end %>
+
+ <%= @stats.total_participants %> |
+
+
+
+
+
+
+
+ <%= t("stats.no_demographic_data", count: @stats.total_no_demographic_data) %>
+
+
+
diff --git a/app/views/shared/stats/_age.html.erb b/app/views/shared/stats/_age.html.erb
new file mode 100644
index 000000000..5114c8b8c
--- /dev/null
+++ b/app/views/shared/stats/_age.html.erb
@@ -0,0 +1,28 @@
+
+
<%= t("stats.by_age") %>
+
+
+
+
+ | <%= t("stats.age") %> |
+ <%= t("stats.total") %> |
+
+
+
+
+ <% stats.participants_by_age.values.each do |group| %>
+
+ | <%= group[:range] %> |
+
+
+ <%= "#{group[:count]} (#{number_to_stats_percentage(group[:percentage])})" %>
+
+
+
+
+ |
+
+ <% end %>
+
+
+
diff --git a/app/views/shared/stats/_gender.html.erb b/app/views/shared/stats/_gender.html.erb
new file mode 100644
index 000000000..7c34acce7
--- /dev/null
+++ b/app/views/shared/stats/_gender.html.erb
@@ -0,0 +1,15 @@
+
+
<%= t("stats.by_gender") %>
+
+ <%= number_with_info_tags(
+ stats.total_male_participants,
+ t("stats.men_percentage", percentage: number_to_stats_percentage(stats.male_percentage)),
+ html_class: "participants male"
+ ) %>
+
+ <%= number_with_info_tags(
+ stats.total_female_participants,
+ t("stats.women_percentage", percentage: number_to_stats_percentage(stats.female_percentage)),
+ html_class: "participants female"
+ ) %>
+
diff --git a/app/views/shared/stats/_geozone.html.erb b/app/views/shared/stats/_geozone.html.erb
new file mode 100644
index 000000000..62828dc73
--- /dev/null
+++ b/app/views/shared/stats/_geozone.html.erb
@@ -0,0 +1,21 @@
+
+
<%= t("stats.by_geozone") %>
+
+
+
+
+ | <%= t("stats.geozone") %> |
+ <%= t("stats.total") %> |
+
+
+
+
+ <% stats.participants_by_geozone.each do |geozone, participants| %>
+
+ | <%= geozone %> |
+ <%= "#{participants[:count]} (#{number_to_stats_percentage(participants[:percentage])})" %> |
+
+ <% end %>
+
+
+
diff --git a/app/views/shared/stats/_links.html.erb b/app/views/shared/stats/_links.html.erb
new file mode 100644
index 000000000..8e869c45a
--- /dev/null
+++ b/app/views/shared/stats/_links.html.erb
@@ -0,0 +1,12 @@
+
<%= link_to t("stats.title"), "#participation_statistics" %>
+
diff --git a/app/views/shared/stats/_participation.html.erb b/app/views/shared/stats/_participation.html.erb
new file mode 100644
index 000000000..d15123dc2
--- /dev/null
+++ b/app/views/shared/stats/_participation.html.erb
@@ -0,0 +1,17 @@
+
+
<%= t("stats.title") %>
+
+
+
<%= t("stats.total_participants") %>
+
+ <%= number_with_info_tags(
+ stats.total_participants,
+ "",
+ html_class: "participants total-participants"
+ ) %>
+
+
+ <% stats.participations.each do |participation| %>
+ <%= render "shared/stats/#{participation}", stats: stats %>
+ <% end %>
+
diff --git a/config/i18n-tasks.yml b/config/i18n-tasks.yml
index 251efb113..736f12c0d 100644
--- a/config/i18n-tasks.yml
+++ b/config/i18n-tasks.yml
@@ -45,6 +45,7 @@ data:
- config/locales/%{locale}/user_groups.yml
- config/locales/%{locale}/i18n.yml
- config/locales/%{locale}/milestones.yml
+ - config/locales/%{locale}/stats.yml
# Locale files to write new keys to, based on a list of key pattern => file rules. Matched from top to bottom:
# `i18n-tasks normalize -p` will force move the keys according to these rules
@@ -193,6 +194,7 @@ ignore_unused:
- "admin.site_customization.pages.page.status_*"
- "admin.legislation.processes.process.*"
- "legislation.processes.index.*"
+ - "stats.budgets.participants_*_phase"
- "votes.budget_investments.different_heading_assigned*"
- "*.form.map_skip_checkbox"
# - "{devise,kaminari,will_paginate}.*"
diff --git a/config/locales/en/budgets.yml b/config/locales/en/budgets.yml
index 8616539fc..d7bd7235d 100644
--- a/config/locales/en/budgets.yml
+++ b/config/locales/en/budgets.yml
@@ -191,35 +191,3 @@ en:
dates_range_invalid: "Start date can't be equal or later than End date"
prev_phase_dates_invalid: "Start date must be later than the start date of the previous enabled phase (%{phase_name})"
next_phase_dates_invalid: "End date must be earlier than the end date of the next enabled phase (%{phase_name})"
- stats:
- title: Participation stats
- link: Stats
- page_title: "%{budget} - Participation stats"
- total_participants: Total Participants
- total_budget_investments: Total Proposed Investments
- total_selected_investments: Proposals on final phase
- total_unfeasible_investments: Unfeasible proposals
- total_participants_support_phase: Support phase
- total_participants_web: Vote phase web participants
- total_participants_booths: Vote phase booth participants
- participants: Participants
- supports: Supports
- by_gender: "Participants by gender"
- total_male_participants: Mens
- total_female_participants: Women
- by_age: "Participants by age groups"
- age: Age
- total: Total
- more_than: More than
- years: years
- by_heading: "Participants by heading"
- heading: Heading
- investments_sent_html: "Investment proposals sent"
- participants_support_phase: Participants support phase
- participants_voting_phase: Participants voting phase
- participants_total: Total Participants
- percent_total_participants_html: "%
Total
Participants"
- percent_heading_census_html: "%
Heading
Census"
- no_demographic_data: "* There is no demographic data for %{total} participants."
- participatory_disclaimer: "** The numbers of total participation refer to persons that created, supported or voted investment proposals."
- heading_disclaimer: "*** Data about headings refer to the heading where each user voted, not necessarily the one that person is registered on."
diff --git a/config/locales/en/general.yml b/config/locales/en/general.yml
index 66661512d..6a2ac8b28 100644
--- a/config/locales/en/general.yml
+++ b/config/locales/en/general.yml
@@ -650,15 +650,14 @@ en:
stats_menu: "Participation statistics"
results_menu: "Poll results"
stats:
- title: "Participation data"
- total_participation: "Total participation"
total_votes: "Total amount of given votes"
votes: "VOTES"
web: "WEB"
+ mail: "MAIL"
booth: "BOOTH"
total: "TOTAL"
valid: "Valid"
- white: "White votes"
+ white: "Fully blank"
null_votes: "Invalid"
results:
title: "Questions"
diff --git a/config/locales/en/stats.yml b/config/locales/en/stats.yml
new file mode 100644
index 000000000..0c0b41f70
--- /dev/null
+++ b/config/locales/en/stats.yml
@@ -0,0 +1,43 @@
+en:
+ stats:
+ title: "Participation data"
+ advanced: "Advanced statistics"
+ total_participants: "Participants"
+ by_gender: "Participants by gender"
+ by_age: "Participants by age"
+ by_geozone: "Participants by district"
+ men_percentage: "%{percentage} Men"
+ women_percentage: "%{percentage} Women"
+ age: "Age"
+ age_more_than: "%{start} years old and older"
+ age_range: "%{start} - %{finish} years old"
+ total: "Total"
+ geozone: "District"
+ no_demographic_data:
+ zero: ""
+ one: "* There is no demographic data for 1 participant."
+ other: "* There is no demographic data for %{count} participants."
+ budgets:
+ link: "Stats"
+ page_title: "%{budget} - Participation stats"
+ total_investments: "Total investment projects"
+ total_selected_investments: "Projects in final voting phase"
+ total_unfeasible_investments: "Unfeasible projects"
+ by_phase: "Participants by phase"
+ by_heading: "Participants by phase and heading"
+ total: "Total"
+ heading: "Heading"
+ investments_sent_html: "Investment proposals sent"
+ participants_support_phase: "Participants support phase"
+ participants_vote_phase: "Participants voting phase"
+ participants_every_phase: "Total participants"
+ percent_total_participants: "% Total participants"
+ percent_heading_census: "% Heading census"
+ participatory_disclaimer: "** The numbers of total participants refer to persons that created, supported or voted investment proposals."
+ heading_disclaimer: "*** Data about headings refer to the heading where each user voted, not necessarily the one that person is registered on."
+ polls:
+ by_channel: "Participants by channel"
+ vote_by_channel: "Vote type by channel"
+ web_percentage: "%{percentage} Web"
+ booth_percentage: "%{percentage} Booths"
+ letter_percentage: "%{percentage} Mail"
diff --git a/config/locales/es/budgets.yml b/config/locales/es/budgets.yml
index cc849d1c6..982149b5a 100644
--- a/config/locales/es/budgets.yml
+++ b/config/locales/es/budgets.yml
@@ -191,35 +191,3 @@ es:
dates_range_invalid: "La fecha de comienzo no puede ser igual o superior a la de finalización"
prev_phase_dates_invalid: "La fecha de inicio debe ser posterior a la fecha de inicio de la anterior fase habilitada (%{phase_name})"
next_phase_dates_invalid: "La fecha de fin debe ser anterior a la fecha de fin de la siguiente fase habilitada (%{phase_name})"
- stats:
- title: Estadísticas de participación
- link: Estadísticas
- page_title: "%{budget} - Estadísticas de participación"
- total_participants: Total participantes
- total_budget_investments: Total propuestas enviadas
- total_selected_investments: Propuestas en la fase final
- total_unfeasible_investments: Propuestas inviables
- total_participants_support_phase: Fase de apoyos
- total_participants_web: Participantes web en votación final
- total_participants_booths: Participantes en urnas votación final
- participants: Participantes
- supports: Apoyos
- total: Total
- by_gender: "Participación por género"
- total_male_participants: Hombres
- total_female_participants: Mujeres
- by_age: "Participación por grupos de edad"
- age: Edad
- more_than: Más de
- years: años
- by_heading: "Participación por distritos"
- heading: Distrito
- investments_sent_html: "Propuestas
enviadas"
- participants_support_phase: Participación fase apoyos
- participants_voting_phase: Participación fase votación
- participants_total: Participación total
- percent_total_participants_html: "%
Total
Participantes"
- percent_heading_census_html: "%
Censo
Distrito"
- no_demographic_data: "* No se dispone de los datos demográficos de %{total} participantes."
- participatory_disclaimer: "** Las cifras de participación total se refieren a personas que han creado, apoyado o votado propuestas."
- heading_disclaimer: "*** Los datos de distrito se refieren al distrito en el que el usuario ha votado, no necesariamente en el que está empadronado."
diff --git a/config/locales/es/general.yml b/config/locales/es/general.yml
index 414ab4ddf..f479bb7dd 100644
--- a/config/locales/es/general.yml
+++ b/config/locales/es/general.yml
@@ -650,15 +650,14 @@ es:
stats_menu: "Estadísticas de participación"
results_menu: "Resultados de la votación"
stats:
- title: "Datos de participación"
- total_participation: "Participación total"
total_votes: "Nº total de votos emitidos"
votes: "VOTOS"
web: "WEB"
booth: "URNAS"
+ mail: "CORREO"
total: "TOTAL"
valid: "Válidos"
- white: "En blanco"
+ white: "Totalmente en blanco"
null_votes: "Nulos"
results:
title: "Preguntas"
diff --git a/config/locales/es/stats.yml b/config/locales/es/stats.yml
new file mode 100644
index 000000000..2b1670378
--- /dev/null
+++ b/config/locales/es/stats.yml
@@ -0,0 +1,43 @@
+es:
+ stats:
+ title: "Estadísticas de participación"
+ advanced: "Estadísticas avanzadas"
+ total_participants: "Participantes"
+ by_gender: "Participantes por género"
+ by_age: "Participantes por grupos de edad"
+ by_geozone: "Participantes por distritos"
+ men_percentage: "%{percentage} Hombres"
+ women_percentage: "%{percentage} Mujeres"
+ age: "Edad"
+ age_more_than: "De %{start} y más años"
+ age_range: "De %{start} a %{finish} años"
+ total: "Total"
+ geozone: "Distrito"
+ no_demographic_data:
+ zero: ""
+ one: "* No se dispone de los datos demográficos de 1 participante."
+ other: "* No se dispone de los datos demográficos de %{count} participantes."
+ budgets:
+ link: "Estadísticas"
+ page_title: "%{budget} - Estadísticas de participación"
+ total_investments: "Total proyectos de gasto"
+ total_selected_investments: "Proyectos en la fase final"
+ total_unfeasible_investments: "Proyectos inviables"
+ by_phase: "Participantes por fases"
+ by_heading: "Participantes por distritos y fase"
+ total: "Total"
+ heading: "Distrito"
+ investments_sent_html: "Propuestas
enviadas"
+ participants_support_phase: Participantes fase apoyos
+ participants_vote_phase: Participantes fase votación
+ participants_every_phase: Total de participantes
+ percent_total_participants: "% Total participantes"
+ percent_heading_census: "% Censo distrito"
+ participatory_disclaimer: "** Las cifras de total de participantes se refieren a personas que han creado, apoyado o votado propuestas."
+ heading_disclaimer: "*** Los datos de distrito se refieren al distrito en el que el usuario ha votado, no necesariamente en el que está empadronado."
+ polls:
+ by_channel: "Participantes por medio"
+ vote_by_channel: "Votos emitidos por medio"
+ web_percentage: "%{percentage} Web"
+ booth_percentage: "%{percentage} Urnas"
+ letter_percentage: "%{percentage} Correo"
diff --git a/config/schedule.rb b/config/schedule.rb
index 25d5bf0c9..353190e5a 100644
--- a/config/schedule.rb
+++ b/config/schedule.rb
@@ -27,6 +27,10 @@ every 1.day, at: "5:00 am" do
rake "-s sitemap:refresh"
end
+every 2.hours do
+ rake "-s stats:generate"
+end
+
# Temporally not send dashboard's notifications
# every 1.day, at: "7:00 am" do
# rake "dashboards:send_notifications"
diff --git a/db/migrate/20190408133956_create_stats_versions.rb b/db/migrate/20190408133956_create_stats_versions.rb
new file mode 100644
index 000000000..155731fbd
--- /dev/null
+++ b/db/migrate/20190408133956_create_stats_versions.rb
@@ -0,0 +1,8 @@
+class CreateStatsVersions < ActiveRecord::Migration[4.2]
+ def change
+ create_table :stats_versions do |t|
+ t.references :process, polymorphic: true, index: true
+ t.timestamps null: false
+ end
+ end
+end
diff --git a/db/schema.rb b/db/schema.rb
index 409978b43..1b3fc0471 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -1334,6 +1334,14 @@ ActiveRecord::Schema.define(version: 20190411090023) do
t.index ["tsv"], name: "index_spending_proposals_on_tsv", using: :gin
end
+ create_table "stats_versions", force: :cascade do |t|
+ t.string "process_type"
+ t.integer "process_id"
+ t.datetime "created_at", null: false
+ t.datetime "updated_at", null: false
+ t.index ["process_type", "process_id"], name: "index_stats_versions_on_process_type_and_process_id", using: :btree
+ end
+
create_table "taggings", force: :cascade do |t|
t.integer "tag_id"
t.integer "taggable_id"
diff --git a/lib/geozone_stats.rb b/lib/geozone_stats.rb
new file mode 100644
index 000000000..6b7971610
--- /dev/null
+++ b/lib/geozone_stats.rb
@@ -0,0 +1,24 @@
+class GeozoneStats
+ attr_reader :geozone, :participants
+
+ def initialize(geozone, participants)
+ @geozone = geozone
+ @participants = participants
+ end
+
+ def geozone_participants
+ participants.where(geozone: geozone)
+ end
+
+ def name
+ geozone.name
+ end
+
+ def count
+ geozone_participants.count
+ end
+
+ def percentage
+ PercentageCalculator.calculate(count, participants.count)
+ end
+end
diff --git a/lib/percentage_calculator.rb b/lib/percentage_calculator.rb
new file mode 100644
index 000000000..bb8f3d355
--- /dev/null
+++ b/lib/percentage_calculator.rb
@@ -0,0 +1,7 @@
+module PercentageCalculator
+ def self.calculate(fraction, total)
+ return 0.0 if total.zero?
+
+ (fraction * 100.0 / total).round(3)
+ end
+end
diff --git a/lib/tasks/stats.rake b/lib/tasks/stats.rake
new file mode 100644
index 000000000..a454d88cd
--- /dev/null
+++ b/lib/tasks/stats.rake
@@ -0,0 +1,24 @@
+namespace :stats do
+ desc "Generates stats which are not cached yet"
+ task generate: :environment do
+ Budget.find_each do |budget|
+ Budget::Stats.new(budget).generate
+ print "."
+ end
+
+ Poll.find_each do |poll|
+ Poll::Stats.new(poll).generate
+ print "."
+ end
+ end
+
+ desc "Expires stats cache"
+ task expire_cache: :environment do
+ [Budget, Poll].each do |model_class|
+ model_class.find_each { |record| record.find_or_create_stats_version.touch }
+ end
+ end
+
+ desc "Deletes stats cache and generates it again"
+ task regenerate: [:expire_cache, :generate]
+end
diff --git a/spec/factories/budgets.rb b/spec/factories/budgets.rb
index b53bd8b56..0d9faa1ee 100644
--- a/spec/factories/budgets.rb
+++ b/spec/factories/budgets.rb
@@ -74,13 +74,15 @@ FactoryBot.define do
end
factory :budget_heading, class: "Budget::Heading" do
- association :group, factory: :budget_group
sequence(:name) { |n| "Heading #{n}" }
price 1000000
population 1234
latitude "40.416775"
longitude "-3.703790"
+ transient { budget nil }
+ group { association :budget_group, budget: budget || association(:budget) }
+
trait :drafting_budget do
association :group, factory: [:budget_group, :drafting_budget]
end
@@ -88,7 +90,7 @@ FactoryBot.define do
factory :budget_investment, class: "Budget::Investment" do
sequence(:title) { |n| "Budget Investment #{n} title" }
- association :heading, factory: :budget_heading
+ heading { association :budget_heading, budget: budget }
association :author, factory: :user
description "Spend money on this"
price 10
@@ -189,8 +191,13 @@ FactoryBot.define do
end
factory :budget_ballot_line, class: "Budget::Ballot::Line" do
- association :ballot, factory: :budget_ballot
association :investment, factory: :budget_investment
+
+ transient { user nil }
+
+ ballot do
+ association :budget_ballot, budget: investment.budget.reload, user: user || association(:user)
+ end
end
factory :budget_reclassified_vote, class: "Budget::ReclassifiedVote" do
diff --git a/spec/factories/polls.rb b/spec/factories/polls.rb
index 5a23e2630..b7a532d82 100644
--- a/spec/factories/polls.rb
+++ b/spec/factories/polls.rb
@@ -88,10 +88,13 @@ FactoryBot.define do
end
factory :poll_voter, class: "Poll::Voter" do
- poll
association :user, :level_two
from_web
+ transient { budget nil }
+
+ poll { budget&.poll || association(:poll, budget: budget) }
+
trait :from_web do
origin "web"
token SecureRandom.hex(32)
diff --git a/spec/features/budgets/stats_spec.rb b/spec/features/budgets/stats_spec.rb
index ce1982cdf..6318b1cea 100644
--- a/spec/features/budgets/stats_spec.rb
+++ b/spec/features/budgets/stats_spec.rb
@@ -8,25 +8,16 @@ feature "Stats" do
describe "Show" do
- it "is not accessible to normal users if phase is not 'finished'" do
- budget.update(phase: "reviewing_ballots")
+ it "is not accessible if supports phase is not finished" do
+ budget.update(phase: "selecting")
visit budget_stats_path(budget.id)
expect(page).to have_content "You do not have permission to carry out the action "\
"'read_stats' on budget."
end
- it "is accessible to normal users if phase is 'finished'" do
- budget.update(phase: "finished")
-
- visit budget_stats_path(budget.id)
- expect(page).to have_content "Stats"
- end
-
- it "is accessible to administrators when budget has phase 'reviewing_ballots'" do
- budget.update(phase: "reviewing_ballots")
-
- login_as(create(:administrator).user)
+ it "is accessible if supports phase is finished" do
+ budget.update(phase: "valuating")
visit budget_stats_path(budget.id)
expect(page).to have_content "Stats"
diff --git a/spec/lib/geozone_stats_spec.rb b/spec/lib/geozone_stats_spec.rb
new file mode 100644
index 000000000..570315406
--- /dev/null
+++ b/spec/lib/geozone_stats_spec.rb
@@ -0,0 +1,44 @@
+require "rails_helper"
+
+describe GeozoneStats do
+ let(:winterfell) { create(:geozone, name: "Winterfell") }
+ let(:riverlands) { create(:geozone, name: "Riverlands") }
+
+ describe "#name" do
+ let(:stats) { GeozoneStats.new(winterfell, []) }
+
+ it "returns the geozone name" do
+ expect(stats.name).to eq "Winterfell"
+ end
+ end
+
+ describe "#count" do
+ before do
+ 2.times { create(:user, geozone: winterfell) }
+ 1.times { create(:user, geozone: riverlands) }
+ end
+
+ let(:winterfell_stats) { GeozoneStats.new(winterfell, User.all) }
+ let(:riverlands_stats) { GeozoneStats.new(riverlands, User.all) }
+
+ it "counts participants from the geozone" do
+ expect(winterfell_stats.count).to eq 2
+ expect(riverlands_stats.count).to eq 1
+ end
+ end
+
+ describe "#percentage" do
+ before do
+ 2.times { create(:user, geozone: winterfell) }
+ 1.times { create(:user, geozone: riverlands) }
+ end
+
+ let(:winterfell_stats) { GeozoneStats.new(winterfell, User.all) }
+ let(:riverlands_stats) { GeozoneStats.new(riverlands, User.all) }
+
+ it "calculates percentage relative to the amount of participants" do
+ expect(winterfell_stats.percentage).to eq 66.667
+ expect(riverlands_stats.percentage).to eq 33.333
+ end
+ end
+end
diff --git a/spec/models/budget/phase_spec.rb b/spec/models/budget/phase_spec.rb
index 81c3c9a63..e88d42b02 100644
--- a/spec/models/budget/phase_spec.rb
+++ b/spec/models/budget/phase_spec.rb
@@ -7,17 +7,8 @@ describe Budget::Phase do
let(:second_phase) { budget.phases.informing }
let(:third_phase) { budget.phases.accepting }
let(:fourth_phase) { budget.phases.reviewing }
- let(:fifth_phase) { budget.phases.selecting }
let(:final_phase) { budget.phases.finished}
- before do
- first_phase.update_attributes(starts_at: Date.current - 3.days, ends_at: Date.current - 1.day)
- second_phase.update_attributes(starts_at: Date.current - 1.days, ends_at: Date.current + 1.day)
- third_phase.update_attributes(starts_at: Date.current + 1.days, ends_at: Date.current + 3.day)
- fourth_phase.update_attributes(starts_at: Date.current + 3.days, ends_at: Date.current + 5.day)
- fifth_phase.update_attributes(starts_at: Date.current + 5.days, ends_at: Date.current + 7.day)
- end
-
describe "validates" do
it "is not valid without a budget" do
expect(build(:budget_phase, budget: nil)).not_to be_valid
diff --git a/spec/models/budget/stats_spec.rb b/spec/models/budget/stats_spec.rb
index 7beafb4e0..b67d23ddf 100644
--- a/spec/models/budget/stats_spec.rb
+++ b/spec/models/budget/stats_spec.rb
@@ -1,212 +1,287 @@
require "rails_helper"
describe Budget::Stats do
+ let(:budget) { create(:budget, :finished) }
+ let(:stats) { Budget::Stats.new(budget) }
+ let(:investment) { create(:budget_investment, :selected, budget: budget) }
- before(:each) do
- @budget = create(:budget)
- @group = create(:budget_group, budget: @budget)
- @heading = create(:budget_heading, group: @group, price: 1000)
+ describe "#participants" do
+ let(:author) { investment.author }
+ let(:author_and_voter) { create(:user, hidden_at: Time.current) }
+ let(:voter) { create(:user) }
+ let(:voter_and_balloter) { create(:user) }
+ let(:balloter) { create(:user, hidden_at: Time.current) }
+ let(:poll_balloter) { create(:user, :level_two) }
+ let(:non_participant) { create(:user, :level_two) }
- @investment1 = create(:budget_investment, :selected, author: create(:user, gender: "female"),
- heading: @heading, price: 200, ballot_lines_count: 900, winner: true)
- @investment2 = create(:budget_investment, :selected, author: create(:user, gender: "female"),
- heading: @heading, price: 300, ballot_lines_count: 800, winner: true)
- @investment3 = create(:budget_investment, :selected, author: create(:user, gender: "female",
- date_of_birth: 40.years.ago), heading: @heading, price: 400,
- ballot_lines_count: 880, winner: true)
- @investment4 = create(:budget_investment, :selected, author: create(:user, gender: "male"),
- heading: @heading, price: 100, ballot_lines_count: 915, winner: true)
- @investment5 = create(:budget_investment, :unfeasible, author: create(:user, gender: "male",
- date_of_birth: 25.years.ago), heading: @heading)
+ before do
+ create(:budget_investment, :selected, budget: budget, author: author_and_voter)
- @support1 = create(:vote, votable: @investment1, voter: create(:user, gender: "male"))
- @support2 = create(:vote, votable: @investment2, voter: create(:user))
+ create(:vote, votable: investment, voter: author_and_voter)
+ create(:vote, votable: investment, voter: voter)
+ create(:vote, votable: investment, voter: voter_and_balloter)
- @budget_ballot1 = create(:budget_ballot, budget: @budget, user: create(:user, gender: "female",
- date_of_birth: 54.years.ago))
- @budget_ballot2 = create(:budget_ballot, budget: @budget, user: create(:user, gender: "female"))
- @budget_ballot3 = create(:budget_ballot, budget: @budget, user: create(:user, gender: "male"))
+ create(:budget_ballot_line, investment: investment, user: balloter)
+ create(:budget_ballot_line, investment: investment, user: voter_and_balloter)
- @budget_ballot_line1 = create(:budget_ballot_line, ballot: @budget_ballot1,
- investment: @investment1)
- @budget_ballot_line2 = create(:budget_ballot_line, ballot: @budget_ballot2,
- investment: @investment2)
- @budget_ballot_line3 = create(:budget_ballot_line, ballot: @budget_ballot3,
- investment: @investment3)
+ create(:poll_voter, :from_booth, user: poll_balloter, budget: budget)
- @poll = create(:poll, budget: @budget)
- @poll_voter = create(:poll_voter, :from_booth, poll: @poll)
-
- @budget_ballot4 = create(:budget_ballot, budget: @budget, physical: true, user: nil)
- @budget_ballot_line4 = create(:budget_ballot_line, ballot: @budget_ballot4,
- investment: @investment4)
-
- @stats = Budget::Stats.new(@budget).generate
- end
-
- context "#total_participants" do
-
- it "returns the number of total participants" do
- expect(@stats[:total_participants]).to be 11
+ create(:poll_voter, :from_booth, user: non_participant, budget: create(:budget))
end
+ it "returns unique participants, including authors and hidden users" do
+ expect(stats.participants).to match_array(
+ [author, author_and_voter, voter, voter_and_balloter, balloter, poll_balloter]
+ )
+ expect(stats.total_participants).to be 6
+ end
end
- context "#total_participants_support_phase" do
-
+ describe "#total_participants_support_phase" do
it "returns the number of total participants in the support phase" do
- expect(@stats[:total_participants_support_phase]).to be 2
+ 2.times { create(:vote, votable: investment) }
+ create(:budget_ballot_line, investment: investment)
+
+ expect(stats.total_participants_support_phase).to be 2
end
+ it "counts a user who is voter and balloter" do
+ voter_and_balloter = create(:user)
+ create(:vote, votable: investment, voter: voter_and_balloter)
+ create(:budget_ballot_line, investment: investment, user: voter_and_balloter)
+
+ expect(stats.total_participants_support_phase).to be 1
+ end
end
- context "#total_participants_vote_phase" do
-
+ describe "#total_participants_vote_phase" do
it "returns the number of total participants in the votes phase" do
- expect(@stats[:total_participants_vote_phase]).to be 4
+ 2.times { create(:budget_ballot_line, investment: investment) }
+ create(:vote, votable: investment)
+
+ expect(stats.total_participants_vote_phase).to be 2
end
- end
+ it "counts a user who is voter and balloter" do
+ voter_and_balloter = create(:user)
+ create(:vote, votable: investment, voter: voter_and_balloter)
+ create(:budget_ballot_line, investment: investment, user: voter_and_balloter)
- context "#total_participants_web" do
-
- it "returns the number of total participants in the votes phase via web" do
- expect(@stats[:total_participants_web]).to be 3
+ expect(stats.total_participants_vote_phase).to be 1
end
- end
+ it "includes balloters and poll balloters" do
+ create(:budget_ballot_line, investment: investment)
+ create(:poll_voter, :from_booth, budget: budget)
- context "#total_participants_booths" do
-
- it "returns the number of total participants in the votes phase in booths" do
- expect(@stats[:total_participants_booths]).to be 1
+ expect(stats.total_participants_vote_phase).to be 2
end
+ it "counts once a user who is balloter and poll balloter" do
+ poller_and_balloter = create(:user, :level_two)
+ create(:budget_ballot_line, investment: investment, user: poller_and_balloter)
+ create(:poll_voter, :from_booth, user: poller_and_balloter, budget: budget)
+
+ expect(stats.total_participants_vote_phase).to be 1
+ end
+
+ it "doesn't count nil user ids" do
+ create(:budget_ballot_line, investment: investment,
+ ballot: create(:budget_ballot, budget: budget, user: nil, physical: true)
+ )
+
+ expect(stats.total_participants_vote_phase).to be 0
+ end
end
- context "#total_budget_investments" do
-
+ describe "#total_budget_investments" do
it "returns the number of total budget investments" do
- expect(@stats[:total_budget_investments]).to be 5
- end
+ 2.times { create(:budget_investment, budget: budget) }
+ create(:budget_investment, budget: create(:budget))
+ expect(stats.total_budget_investments).to be 2
+ end
end
- context "#total_votes" do
-
+ describe "#total_votes" do
it "returns the number of total votes" do
- expect(@stats[:total_votes]).to be 4
- end
+ create(:budget_ballot_line, investment: investment)
+ create(:budget_ballot_line, investment: create(:budget_investment, :selected, budget: budget))
+ expect(stats.total_votes).to be 2
+ end
end
- context "#total_selected_investments" do
-
+ describe "#total_selected_investments" do
it "returns the number of total selected investments" do
- expect(@stats[:total_selected_investments]).to be 4
- end
+ 3.times { create(:budget_investment, :selected, budget: budget) }
+ create(:budget_investment, :selected, budget: create(:budget))
+ create(:budget_investment, :unfeasible, budget: budget)
+ expect(stats.total_selected_investments).to be 3
+ end
end
- context "#total_unfeasible_investments" do
-
+ describe "#total_unfeasible_investments" do
it "returns the number of total unfeasible investments" do
- expect(@stats[:total_unfeasible_investments]).to be 1
- end
+ 3.times { create(:budget_investment, :unfeasible, budget: budget) }
+ create(:budget_investment, :unfeasible, budget: create(:budget))
+ create(:budget_investment, :selected, budget: budget)
+ expect(stats.total_unfeasible_investments).to be 3
+ end
end
- context "#total_male_participants" do
+ describe "Participants by gender" do
+ before do
+ 3.times { create(:user, gender: "male") }
+ 2.times { create(:user, gender: "female") }
+ create(:user, gender: nil)
- it "returns the number of total male participants" do
- expect(@stats[:total_male_participants]).to be 4
+ allow(stats).to receive(:participants).and_return(User.all)
end
- end
-
- context "#total_female_participants" do
-
- it "returns the number of total female participants" do
- expect(@stats[:total_female_participants]).to be 6
+ describe "#total_male_participants" do
+ it "returns the number of total male participants" do
+ expect(stats.total_male_participants).to be 3
+ end
end
- end
-
- context "#total_supports" do
-
- it "returns the number of total supports" do
- expect(@stats[:total_supports]).to be 2
+ describe "#total_female_participants" do
+ it "returns the number of total female participants" do
+ expect(stats.total_female_participants).to be 2
+ end
end
- end
-
- context "#total_unknown_gender_or_age" do
-
- it "returns the number of total unknown participants' gender or age" do
- expect(@stats[:total_unknown_gender_or_age]).to be 1
+ describe "#male_percentage" do
+ it "returns the percentage of male participants" do
+ expect(stats.male_percentage).to be 60.0
+ end
end
+ describe "#female_percentage" do
+ it "returns the percentage of female participants" do
+ expect(stats.female_percentage).to be 40.0
+ end
+ end
end
- context "#age_groups" do
+ describe "#participants_by_age" do
+ before do
+ [21, 22, 23, 23, 34, 42, 43, 44, 50, 51].each do |age|
+ create(:user, date_of_birth: age.years.ago)
+ end
+
+ allow(stats).to receive(:participants).and_return(User.all)
+ end
it "returns the age groups hash" do
- expect(@stats[:age_groups]["16 - 19"]).to be 0
- expect(@stats[:age_groups]["20 - 24"]).to be 7
- expect(@stats[:age_groups]["25 - 29"]).to be 1
- expect(@stats[:age_groups]["30 - 34"]).to be 0
- expect(@stats[:age_groups]["35 - 39"]).to be 1
- expect(@stats[:age_groups]["40 - 44"]).to be 1
- expect(@stats[:age_groups]["45 - 49"]).to be 0
- expect(@stats[:age_groups]["50 - 54"]).to be 1
- expect(@stats[:age_groups]["55 - 59"]).to be 0
- expect(@stats[:age_groups]["60 - 64"]).to be 0
- expect(@stats[:age_groups]["65 - 69"]).to be 0
- expect(@stats[:age_groups]["70 - 140"]).to be 0
+ expect(stats.participants_by_age["16 - 19"][:count]).to be 0
+ expect(stats.participants_by_age["20 - 24"][:count]).to be 4
+ expect(stats.participants_by_age["25 - 29"][:count]).to be 0
+ expect(stats.participants_by_age["30 - 34"][:count]).to be 1
+ expect(stats.participants_by_age["35 - 39"][:count]).to be 0
+ expect(stats.participants_by_age["40 - 44"][:count]).to be 3
+ expect(stats.participants_by_age["45 - 49"][:count]).to be 0
+ expect(stats.participants_by_age["50 - 54"][:count]).to be 2
+ expect(stats.participants_by_age["55 - 59"][:count]).to be 0
+ expect(stats.participants_by_age["60 - 64"][:count]).to be 0
+ expect(stats.participants_by_age["65 - 69"][:count]).to be 0
+ expect(stats.participants_by_age["70 - 74"][:count]).to be 0
end
-
end
- context "#male_percentage" do
-
- it "returns the percentage of male participants" do
- expect(@stats[:male_percentage]).to be 40.0
+ describe "#headings" do
+ before do
+ investment.heading.update_column(:population, 1234)
+ create(:budget_investment, heading: investment.heading)
+ 2.times { create(:vote, votable: investment) }
+ create(:budget_ballot_line, investment: investment)
end
- end
-
- context "#female_percentage" do
-
- it "returns the percentage of female participants" do
- expect(@stats[:female_percentage]).to be 60.0
- end
-
- end
-
- context "#headings" do
-
it "returns headings data" do
- heading_stats = @stats[:headings][@heading.id]
- expect(heading_stats[:total_investments_count]).to be 5
+ heading_stats = stats.headings[investment.heading.id]
+ expect(heading_stats[:total_investments_count]).to be 2
expect(heading_stats[:total_participants_support_phase]).to be 2
- expect(heading_stats[:total_participants_vote_phase]).to be 4
- expect(heading_stats[:total_participants_all_phase]).to be 6
+ expect(heading_stats[:total_participants_vote_phase]).to be 1
+ expect(heading_stats[:total_participants_every_phase]).to be 3
expect(heading_stats[:percentage_participants_support_phase]).to be 100.0
expect(heading_stats[:percentage_district_population_support_phase]).to be 0.162
expect(heading_stats[:percentage_participants_vote_phase]).to be 100.0
- expect(heading_stats[:percentage_district_population_vote_phase]).to be 0.324
- expect(heading_stats[:percentage_participants_all_phase]).to be 100.0
- expect(heading_stats[:percentage_district_population_all_phase]).to be 0.486
-
- expect(heading_stats[:total_investments_count]).to be 5
- expect(heading_stats[:total_participants_support_phase]).to be 2
- expect(heading_stats[:total_participants_vote_phase]).to be 4
- expect(heading_stats[:total_participants_all_phase]).to be 6
- expect(heading_stats[:percentage_participants_support_phase]).to be 100.0
- expect(heading_stats[:percentage_participants_vote_phase]).to be 100.0
- expect(heading_stats[:percentage_participants_all_phase]).to be 100.0
+ expect(heading_stats[:percentage_district_population_vote_phase]).to be 0.081
+ expect(heading_stats[:percentage_participants_every_phase]).to be 100.0
+ expect(heading_stats[:percentage_district_population_every_phase]).to be 0.243
end
-
end
+ describe "#support_phase_finished?" do
+ context "support phase isn't finished" do
+ before { budget.phase = "selecting" }
+
+ it "is false" do
+ expect(stats.support_phase_finished?).to be false
+ end
+ end
+
+ context "support phase is finished" do
+ before { budget.phase = "valuating" }
+
+ it "is false" do
+ expect(stats.support_phase_finished?).to be true
+ end
+ end
+ end
+
+ describe "#vote_phase_finished" do
+ context "support phase isn't finished" do
+ before { budget.phase = "reviewing_ballots" }
+
+ it "is false" do
+ expect(stats.vote_phase_finished?).to be false
+ end
+ end
+
+ context "vote phase is finished" do
+ before { budget.phase = "finished" }
+
+ it "is false" do
+ expect(stats.vote_phase_finished?).to be true
+ end
+ end
+ end
+
+ describe "#all_phases" do
+ context "no phases are finished" do
+ before do
+ allow(stats).to receive(:support_phase_finished?).and_return(false)
+ allow(stats).to receive(:vote_phase_finished?).and_return(false)
+ end
+
+ it "returns an empty array" do
+ expect(stats.all_phases).to eq []
+ end
+ end
+
+ context "one phase is finished" do
+ before do
+ allow(stats).to receive(:support_phase_finished?).and_return(true)
+ allow(stats).to receive(:vote_phase_finished?).and_return(false)
+ end
+
+ it "returns the finished phase" do
+ expect(stats.all_phases).to eq ["support"]
+ end
+ end
+
+ context "all phases are finished" do
+ before do
+ allow(stats).to receive(:support_phase_finished?).and_return(true)
+ allow(stats).to receive(:vote_phase_finished?).and_return(true)
+ end
+
+ it "returns the finished phases and a total phase" do
+ expect(stats.all_phases).to eq ["support", "vote", "every"]
+ end
+ end
+ end
end
diff --git a/spec/models/budget_spec.rb b/spec/models/budget_spec.rb
index da069f558..87063b549 100644
--- a/spec/models/budget_spec.rb
+++ b/spec/models/budget_spec.rb
@@ -97,33 +97,55 @@ describe Budget do
expect(budget).to be_finished
end
- it "balloting_or_later?" do
- budget.phase = "drafting"
- expect(budget).not_to be_balloting_or_later
+ describe "#valuating_or_later?" do
+ it "returns false before valuating" do
+ budget.phase = "selecting"
+ expect(budget).not_to be_valuating_or_later
+ end
- budget.phase = "accepting"
- expect(budget).not_to be_balloting_or_later
+ it "returns true while valuating" do
+ budget.phase = "valuating"
+ expect(budget).to be_valuating_or_later
+ end
- budget.phase = "reviewing"
- expect(budget).not_to be_balloting_or_later
+ it "returns true after valuating" do
+ budget.phase = "publishing_prices"
+ expect(budget).to be_valuating_or_later
+ end
+ end
- budget.phase = "selecting"
- expect(budget).not_to be_balloting_or_later
+ describe "#publishing_prices_or_later?" do
+ it "returns false before publishing prices" do
+ budget.phase = "valuating"
+ expect(budget).not_to be_publishing_prices_or_later
+ end
- budget.phase = "valuating"
- expect(budget).not_to be_balloting_or_later
+ it "returns true while publishing prices" do
+ budget.phase = "publishing_prices"
+ expect(budget).to be_publishing_prices_or_later
+ end
- budget.phase = "publishing_prices"
- expect(budget).not_to be_balloting_or_later
+ it "returns true after publishing prices" do
+ budget.phase = "balloting"
+ expect(budget).to be_publishing_prices_or_later
+ end
+ end
- budget.phase = "balloting"
- expect(budget).to be_balloting_or_later
+ describe "#balloting_or_later?" do
+ it "returns false before balloting" do
+ budget.phase = "publishing_prices"
+ expect(budget).not_to be_balloting_or_later
+ end
- budget.phase = "reviewing_ballots"
- expect(budget).to be_balloting_or_later
+ it "returns true while balloting" do
+ budget.phase = "balloting"
+ expect(budget).to be_balloting_or_later
+ end
- budget.phase = "finished"
- expect(budget).to be_balloting_or_later
+ it "returns true after balloting" do
+ budget.phase = "finished"
+ expect(budget).to be_balloting_or_later
+ end
end
end
diff --git a/spec/models/poll/stats_spec.rb b/spec/models/poll/stats_spec.rb
index b2130a370..8f8b3583d 100644
--- a/spec/models/poll/stats_spec.rb
+++ b/spec/models/poll/stats_spec.rb
@@ -1,44 +1,288 @@
require "rails_helper"
describe Poll::Stats do
+ let(:poll) { create(:poll) }
+ let(:stats) { Poll::Stats.new(poll) }
- describe "#generate" do
- it "generates the correct stats" do
- poll = create(:poll)
- 2.times { create(:poll_voter, :from_web, poll: poll) }
- 3.times { create(:poll_voter, :from_booth, poll: poll) }
- create(:poll_recount, :from_booth, poll: poll,
- white_amount: 1, null_amount: 0, total_amount: 2)
+ describe "#participants" do
+ it "includes hidden users" do
+ create(:poll_voter, poll: poll)
+ create(:poll_voter, poll: poll, user: create(:user, :level_two, hidden_at: Time.current))
- stats = Poll::Stats.new(poll).generate
-
- expect(stats[:total_participants]).to eq(5)
- expect(stats[:total_participants_web]).to eq(2)
- expect(stats[:total_participants_booth]).to eq(3)
- expect(stats[:total_valid_votes]).to eq(4)
- expect(stats[:total_white_votes]).to eq(1)
- expect(stats[:total_null_votes]).to eq(0)
-
- expect(stats[:total_web_valid]).to eq(2)
- expect(stats[:total_web_white]).to eq(0)
- expect(stats[:total_web_null]).to eq(0)
-
- expect(stats[:total_booth_valid]).to eq(2)
- expect(stats[:total_booth_white]).to eq(1)
- expect(stats[:total_booth_null]).to eq(0)
-
- expect(stats[:total_participants_web_percentage]).to eq(40)
- expect(stats[:total_participants_booth_percentage]).to eq(60)
- expect(stats[:valid_percentage_web]).to eq(50)
- expect(stats[:white_percentage_web]).to eq(0)
- expect(stats[:null_percentage_web]).to eq(0)
- expect(stats[:valid_percentage_booth]).to eq(50)
- expect(stats[:white_percentage_booth]).to eq(100)
- expect(stats[:null_percentage_booth]).to eq(0)
- expect(stats[:total_valid_percentage]).to eq(80)
- expect(stats[:total_white_percentage]).to eq(20)
- expect(stats[:total_null_percentage]).to eq(0)
+ expect(stats.participants.count).to eq(2)
end
end
-end
\ No newline at end of file
+ describe "total participants" do
+ before { allow(stats).to receive(:total_web_white).and_return(1) }
+
+ it "supports every channel" do
+ 3.times { create(:poll_voter, :from_web, poll: poll) }
+ create(:poll_recount, :from_booth, poll: poll,
+ total_amount: 8, white_amount: 4, null_amount: 1)
+
+ expect(stats.total_participants_web).to eq(3)
+ expect(stats.total_participants_booth).to eq(13)
+ expect(stats.total_participants).to eq(16)
+ end
+ end
+
+ describe "#total_participants_booth" do
+ it "uses recounts even if there are discrepancies when recounting" do
+ create(:poll_recount, :from_booth, poll: poll, total_amount: 1)
+ 2.times { create(:poll_voter, :from_booth, poll: poll) }
+
+ expect(stats.total_participants_booth).to eq(1)
+ end
+ end
+
+ describe "total participants percentage by channel" do
+ it "is relative to the total amount of participants" do
+ create(:poll_voter, :from_web, poll: poll)
+ create(:poll_recount, :from_booth, poll: poll, total_amount: 5)
+
+ expect(stats.total_participants_web_percentage).to eq(16.667)
+ expect(stats.total_participants_booth_percentage).to eq(83.333)
+ end
+ end
+
+ describe "#total_web_valid" do
+ before { allow(stats).to receive(:total_web_white).and_return(1) }
+
+ it "returns only valid votes" do
+ 3.times { create(:poll_voter, :from_web, poll: poll) }
+
+ expect(stats.total_web_valid).to eq(2)
+ end
+ end
+
+ describe "#total_web_white" do
+ pending "Too complex to test"
+ end
+
+ describe "#total_web_null" do
+ it "returns 0" do
+ expect(stats.total_web_null).to eq(0)
+ end
+ end
+
+ describe "#total_booth_valid" do
+ it "sums the total amounts in the recounts" do
+ create(:poll_recount, :from_booth, poll: poll, total_amount: 3, white_amount: 1)
+ create(:poll_recount, :from_booth, poll: poll, total_amount: 4, null_amount: 2)
+
+ expect(stats.total_booth_valid).to eq(7)
+ end
+ end
+
+ describe "#total_booth_white" do
+ it "sums the white amounts in the recounts" do
+ create(:poll_recount, :from_booth, poll: poll, white_amount: 120, total_amount: 3)
+ create(:poll_recount, :from_booth, poll: poll, white_amount: 203, null_amount: 5)
+
+ expect(stats.total_booth_white).to eq(323)
+ end
+ end
+
+ describe "#total_booth_null" do
+ it "sums the null amounts in the recounts" do
+ create(:poll_recount, :from_booth, poll: poll, null_amount: 125, total_amount: 3)
+ create(:poll_recount, :from_booth, poll: poll, null_amount: 34, white_amount: 5)
+
+ expect(stats.total_booth_null).to eq(159)
+ end
+ end
+
+ describe "valid percentage by channel" do
+ it "is relative to the total amount of valid votes" do
+ create(:poll_recount, :from_booth, poll: poll, total_amount: 2)
+ create(:poll_voter, :from_web, poll: poll)
+
+ expect(stats.valid_percentage_web).to eq(33.333)
+ expect(stats.valid_percentage_booth).to eq(66.667)
+ end
+ end
+
+ describe "white percentage by channel" do
+ before { allow(stats).to receive(:total_web_white).and_return(10) }
+
+ it "is relative to the total amount of white votes" do
+ create(:poll_recount, :from_booth, poll: poll, white_amount: 70)
+
+ expect(stats.white_percentage_web).to eq(12.5)
+ expect(stats.white_percentage_booth).to eq(87.5)
+ end
+ end
+
+ describe "null percentage by channel" do
+ it "only accepts null votes from booth" do
+ create(:poll_recount, :from_booth, poll: poll, null_amount: 70)
+
+ expect(stats.null_percentage_web).to eq(0)
+ expect(stats.null_percentage_booth).to eq(100)
+ end
+ end
+
+ describe "#total_valid_votes" do
+ it "counts valid votes from every channel" do
+ 2.times { create(:poll_voter, :from_web, poll: poll) }
+ create(:poll_recount, :from_booth, poll: poll, total_amount: 3, white_amount: 10)
+ create(:poll_recount, :from_booth, poll: poll, total_amount: 4, null_amount: 20)
+
+ expect(stats.total_valid_votes).to eq(9)
+ end
+ end
+
+ describe "#total_white_votes" do
+ before { allow(stats).to receive(:total_web_white).and_return(9) }
+
+ it "counts white votes on every channel" do
+ create(:poll_recount, :from_booth, poll: poll, white_amount: 12)
+
+ expect(stats.total_white_votes).to eq(21)
+ end
+ end
+
+ describe "#total_null_votes" do
+ it "only accepts null votes from booth" do
+ create(:poll_recount, :from_booth, poll: poll, null_amount: 32)
+
+ expect(stats.total_null_votes).to eq(32)
+ end
+ end
+
+ describe "total percentage by type" do
+ before { allow(stats).to receive(:total_web_white).and_return(1) }
+
+ it "is relative to the total amount of votes" do
+ 3.times { create(:poll_voter, :from_web, poll: poll) }
+ create(:poll_recount, :from_booth, poll: poll,
+ total_amount: 8, white_amount: 5, null_amount: 4)
+
+ expect(stats.total_valid_percentage).to eq(50)
+ expect(stats.total_white_percentage).to eq(30)
+ expect(stats.total_null_percentage).to eq(20)
+ end
+ end
+
+ describe "#participants_by_geozone" do
+ it "groups by geozones in alphabetic order" do
+ %w[Oceania Eurasia Eastasia].each { |name| create(:geozone, name: name) }
+
+ expect(stats.participants_by_geozone.keys).to eq %w[Eastasia Eurasia Oceania]
+ end
+
+ it "calculates percentage relative to total participants" do
+ hobbiton = create(:geozone, name: "Hobbiton")
+ rivendel = create(:geozone, name: "Rivendel")
+
+ 3.times { create :poll_voter, poll: poll, user: create(:user, :level_two, geozone: hobbiton) }
+ 2.times { create :poll_voter, poll: poll, user: create(:user, :level_two, geozone: rivendel) }
+
+ expect(stats.participants_by_geozone["Hobbiton"][:count]).to eq 3
+ expect(stats.participants_by_geozone["Hobbiton"][:percentage]).to eq 60.0
+ expect(stats.participants_by_geozone["Rivendel"][:count]).to eq 2
+ expect(stats.participants_by_geozone["Rivendel"][:percentage]).to eq 40.0
+ end
+ end
+
+ describe "#total_no_demographic_data" do
+ before do
+ create(:poll_voter, :from_web, poll: poll, user: create(:user, :level_two, gender: nil))
+ end
+
+ context "more registered participants than participants in recounts" do
+ before do
+ create(:poll_recount, :from_booth, poll: poll, total_amount: 1)
+ 2.times { create(:poll_voter, :from_booth, poll: poll) }
+ end
+
+ it "returns registered users with no demographic data" do
+ expect(stats.total_no_demographic_data).to eq 1
+ end
+ end
+
+ context "more participants in recounts than registered participants" do
+ before do
+ create(:poll_recount, :from_booth, poll: poll, total_amount: 3)
+ 2.times { create(:poll_voter, :from_booth, poll: poll) }
+ end
+
+ it "returns registered users with no demographic data plus users not registered" do
+ expect(stats.total_no_demographic_data).to eq 2
+ end
+ end
+ end
+
+ describe "#channels" do
+ context "no participants" do
+ it "returns no channels" do
+ expect(stats.channels).to eq []
+ end
+ end
+
+ context "only participants from web" do
+ before { create(:poll_voter, :from_web, poll: poll) }
+
+ it "returns the web channel" do
+ expect(stats.channels).to eq ["web"]
+ end
+ end
+
+ context "only participants from booth" do
+ before do
+ create(:poll_recount, :from_booth, poll: poll, total_amount: 1)
+ end
+
+ it "returns the booth channel" do
+ expect(stats.channels).to eq ["booth"]
+ end
+ end
+
+ context "only participants from letter" do
+ before { create(:poll_voter, origin: "letter", poll: poll) }
+
+ it "returns the web channel" do
+ expect(stats.channels).to eq ["letter"]
+ end
+ end
+
+ context "participants from all channels" do
+ before do
+ create(:poll_voter, :from_web, poll: poll)
+ create(:poll_recount, :from_booth, poll: poll, total_amount: 1)
+ create(:poll_voter, origin: "letter", poll: poll)
+ end
+
+ it "returns all channels" do
+ expect(stats.channels).to eq %w[web booth letter]
+ end
+ end
+ end
+
+ describe "#version", :with_frozen_time do
+ context "record with no stats" do
+ it "returns a string based on the current time" do
+ expect(stats.version).to eq "v#{Time.current.to_i}"
+ end
+
+ it "doesn't overwrite the timestamp when called multiple times" do
+ time = Time.current
+
+ expect(stats.version).to eq "v#{time.to_i}"
+
+ travel_to 2.seconds.from_now do
+ expect(stats.version).to eq "v#{time.to_i}"
+ end
+ end
+ end
+
+ context "record with stats" do
+ before { poll.create_stats_version(updated_at: 1.day.ago) }
+
+ it "returns the version of the existing stats" do
+ expect(stats.version).to eq "v#{1.day.ago.to_i}"
+ end
+ end
+ end
+end
diff --git a/spec/models/statisticable_spec.rb b/spec/models/statisticable_spec.rb
new file mode 100644
index 000000000..3757d3db8
--- /dev/null
+++ b/spec/models/statisticable_spec.rb
@@ -0,0 +1,180 @@
+require "rails_helper"
+
+describe Statisticable do
+ class DummyStats
+ include Statisticable
+
+ def participants
+ User.all
+ end
+ end
+
+ let(:stats) { DummyStats.new(nil) }
+
+ describe "#gender?" do
+ context "No participants" do
+ it "is false" do
+ expect(stats.gender?).to be false
+ end
+ end
+
+ context "All participants have no defined gender" do
+ before { create(:user, gender: nil) }
+
+ it "is false" do
+ expect(stats.gender?).to be false
+ end
+ end
+
+ context "There's a male participant" do
+ before { create(:user, gender: "male") }
+
+ it "is true" do
+ expect(stats.gender?).to be true
+ end
+ end
+
+ context "There's a female participant" do
+ before { create(:user, gender: "female") }
+
+ it "is true" do
+ expect(stats.gender?).to be true
+ end
+ end
+ end
+
+ describe "#age?" do
+ context "No participants" do
+ it "is false" do
+ expect(stats.age?).to be false
+ end
+ end
+
+ context "All participants have no defined age" do
+ before { create(:user, date_of_birth: nil) }
+
+ it "is false" do
+ expect(stats.age?).to be false
+ end
+ end
+
+ context "All participants have impossible ages" do
+ before do
+ create(:user, date_of_birth: 3.seconds.ago)
+ create(:user, date_of_birth: 3000.years.ago)
+ end
+
+ it "is false" do
+ expect(stats.age?).to be false
+ end
+ end
+
+ context "There's a participant with a defined age" do
+ before { create(:user, date_of_birth: 30.years.ago) }
+
+ it "is true" do
+ expect(stats.age?).to be true
+ end
+ end
+ end
+
+ describe "#geozone?" do
+ context "No participants" do
+ it "is false" do
+ expect(stats.geozone?).to be false
+ end
+ end
+
+ context "All participants have no defined geozone" do
+ before { create(:user, geozone: nil) }
+
+ it "is false" do
+ expect(stats.geozone?).to be false
+ end
+ end
+
+ context "There's a participant with a defined geozone" do
+ before { create(:user, geozone: create(:geozone)) }
+
+ it "is true" do
+ expect(stats.geozone?).to be true
+ end
+ end
+ end
+
+ describe "#total_no_demographic_data" do
+ it "returns users with no defined gender" do
+ create(:user, gender: nil)
+
+ expect(stats.total_no_demographic_data).to be 1
+ end
+
+ it "returns users with no defined age" do
+ create(:user, gender: "female", date_of_birth: nil)
+
+ expect(stats.total_no_demographic_data).to be 1
+ end
+
+ it "returns users with no defined geozone" do
+ create(:user, gender: "female", geozone: nil)
+
+ expect(stats.total_no_demographic_data).to be 1
+ end
+
+ it "returns users with no defined gender, age nor geozone" do
+ create(:user, gender: nil, date_of_birth: nil, geozone: nil)
+
+ expect(stats.total_no_demographic_data).to be 1
+ end
+
+ it "doesn't return users with defined gender, age and geozone" do
+ create(:user, gender: "male", date_of_birth: 20.years.ago, geozone: create(:geozone))
+
+ expect(stats.total_no_demographic_data).to be 0
+ end
+ end
+
+ describe "#stats_methods" do
+ it "includes total participants" do
+ expect(stats.stats_methods).to include(:total_participants)
+ end
+
+ context "no gender stats" do
+ before { allow(stats).to receive(:gender?).and_return(false) }
+
+ it "doesn't include gender methods" do
+ expect(stats.stats_methods).not_to include(:total_male_participants)
+ end
+ end
+
+ context "no age stats" do
+ before { allow(stats).to receive(:age?).and_return(false) }
+
+ it "doesn't include age methods" do
+ expect(stats.stats_methods).not_to include(:participants_by_age)
+ end
+ end
+
+ context "no geozone stats" do
+ before { allow(stats).to receive(:geozone?).and_return(false) }
+
+ it "doesn't include age methods" do
+ expect(stats.stats_methods).not_to include(:participants_by_geozone)
+ end
+ end
+
+ context "all gender, age and geozone stats" do
+ before do
+ allow(stats).to receive(:gender?).and_return(true)
+ allow(stats).to receive(:age?).and_return(true)
+ allow(stats).to receive(:geozone?).and_return(true)
+ end
+
+ it "includes all stats methods" do
+ expect(stats.stats_methods).to include(:total_male_participants)
+ expect(stats.stats_methods).to include(:participants_by_age)
+ expect(stats.stats_methods).to include(:participants_by_geozone)
+ end
+ end
+ end
+end
diff --git a/spec/models/stats_version_spec.rb b/spec/models/stats_version_spec.rb
new file mode 100644
index 000000000..eb875ed09
--- /dev/null
+++ b/spec/models/stats_version_spec.rb
@@ -0,0 +1,13 @@
+require "rails_helper"
+
+describe StatsVersion do
+ describe "validations" do
+ it "is valid with a process" do
+ expect(StatsVersion.new(process: Budget.new)).to be_valid
+ end
+
+ it "is not valid without a process" do
+ expect(StatsVersion.new(process: nil)).not_to be_valid
+ end
+ end
+end