consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Changes suggested in PR:

Browse Source 
* Delete all things related to banner images and styles (in code)
* Add a new test to check that the banner is showing correctly
* Update the specs accordingly to match the changes

Update dev_seed to set a random background_color and a font_color for banners (and remove everything about image and style)
Add a rake task to migrate the banner style to backgroun_color and font_color (so that the banners have the same colors than before)
This commit is contained in:
iagirre
2018-01-24 16:23:12 +01:00
committed by Angel Perez
parent 5d1b06a3cb
commit 82cb8d4c52
8 changed files with 75 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/assets/javascripts/banners.js.coffee
View File

@@ -24,21 +24,13 @@ App.Banners =
change: ->
App.Banners.update_banner("#js-banner-description", $(this).val())
$("#banner_style").on
change: ->
App.Banners.update_style("#js-banner-style", $(this).val())
$("#banner_image").on
change: ->
App.Banners.update_style("#js-banner-image", $(this).val())
$("#banner_background_color_picker").on
change: ->
App.Banners.update_background_color("#js-banner-style", "#banner_background_color", $(this).val());
App.Banners.update_background_color("#js-banner-background", "#banner_background_color", $(this).val());
$("#banner_background_color").on
change: ->
App.Banners.update_background_color("#js-banner-style", "#banner_background_color_picker", $(this).val());
App.Banners.update_background_color("#js-banner-background", "#banner_background_color_picker", $(this).val());
$("#banner_font_color_picker").on
change: ->