Merge pull request #3580 from consul/use_find_instead_of_find_by_id

Use find instead of find by

app/controllers/admin/budget_groups_controller.rb

@@ -46,11 +46,11 @@ class Admin::BudgetGroupsController < Admin::BaseController
   private
 
     def load_budget
-      @budget = Budget.includes(:groups).find(params[:budget_id])
+      @budget = Budget.find_by_slug_or_id! params[:budget_id]
     end
 
     def load_group
-      @group = @budget.groups.find(params[:id])
+      @group = @budget.groups.find_by_slug_or_id! params[:id]
     end
 
     def groups_index

app/controllers/admin/budget_headings_controller.rb

@@ -47,15 +47,15 @@ class Admin::BudgetHeadingsController < Admin::BaseController
   private
 
     def load_budget
-      @budget = Budget.includes(:groups).find(params[:budget_id])
+      @budget = Budget.find_by_slug_or_id! params[:budget_id]
     end
 
     def load_group
-      @group = @budget.groups.find(params[:group_id])
+      @group = @budget.groups.find_by_slug_or_id! params[:group_id]
     end
 
     def load_heading
-      @heading = @group.headings.find(params[:id])
+      @heading = @group.headings.find_by_slug_or_id! params[:id]
     end
 
     def headings_index

app/controllers/admin/budget_investments_controller.rb

@@ -87,7 +87,7 @@ class Admin::BudgetInvestmentsController < Admin::BaseController
     end
 
     def load_budget
-      @budget = Budget.includes(:groups).find(params[:budget_id])
+      @budget = Budget.find_by_slug_or_id! params[:budget_id]
     end
 
     def load_investment

app/controllers/admin/budgets_controller.rb

@@ -6,6 +6,7 @@ class Admin::BudgetsController < Admin::BaseController
 
   has_filters %w{open finished}, only: :index
 
+  before_action :load_budget, except: [:index, :new, :create]
   load_and_authorize_resource
 
   def index
@@ -66,4 +67,8 @@ class Admin::BudgetsController < Admin::BaseController
       params.require(:budget).permit(*valid_attributes, *report_attributes, translation_params(Budget))
     end
 
+    def load_budget
+      @budget = Budget.find_by_slug_or_id! params[:id]
+    end
+
 end

app/controllers/budgets/ballot/lines_controller.rb

@@ -37,7 +37,7 @@ module Budgets
         end
 
         def load_budget
-          @budget = Budget.find(params[:budget_id])
+          @budget = Budget.find_by_slug_or_id! params[:budget_id]
         end
 
         def load_ballot

app/controllers/budgets/ballots_controller.rb

@@ -1,6 +1,7 @@
 module Budgets
   class BallotsController < ApplicationController
     before_action :authenticate_user!
+    before_action :load_budget
     load_and_authorize_resource :budget
     before_action :load_ballot
     after_action :store_referer, only: [:show]
@@ -13,6 +14,10 @@ module Budgets
 
     private
 
+      def load_budget
+        @budget = Budget.find_by_slug_or_id! params[:budget_id]
+      end
+
       def load_ballot
         query = Budget::Ballot.where(user: current_user, budget: @budget)
         @ballot = @budget.balloting? ? query.first_or_create : query.first_or_initialize

app/controllers/budgets/groups_controller.rb

@@ -1,5 +1,7 @@
 module Budgets
   class GroupsController < ApplicationController
+    before_action :load_budget
+    before_action :load_group
     load_and_authorize_resource :budget
     load_and_authorize_resource :group, class: "Budget::Group"
 
@@ -9,5 +11,14 @@ module Budgets
     def show
     end
 
+    private
+
+      def load_budget
+        @budget = Budget.find_by_slug_or_id! params[:budget_id]
+      end
+
+      def load_group
+        @group = @budget.groups.find_by_slug_or_id! params[:id]
+      end
   end
 end

app/controllers/budgets/investments_controller.rb

@@ -10,6 +10,7 @@ module Budgets
     PER_PAGE = 10
 
     before_action :authenticate_user!, except: [:index, :show, :json_data]
+    before_action :load_budget, except: :json_data
 
     load_and_authorize_resource :budget, except: :json_data
     load_and_authorize_resource :investment, through: :budget, class: "Budget::Investment",
@@ -136,7 +137,7 @@ module Budgets
 
       def load_heading
         if params[:heading_id].present?
-          @heading = @budget.headings.find(params[:heading_id])
+          @heading = @budget.headings.find_by_slug_or_id! params[:heading_id]
           @assigned_heading = @ballot.try(:heading_for_group, @heading.try(:group))
           load_map
         end
@@ -154,6 +155,10 @@ module Budgets
         TagCloud.new(Budget::Investment, params[:search])
       end
 
+      def load_budget
+        @budget = Budget.find_by_slug_or_id! params[:budget_id]
+      end
+
       def set_view
         @view = (params[:view] == "minimal") ? "minimal" : "default"
       end

app/controllers/budgets/results_controller.rb

@@ -14,15 +14,14 @@ module Budgets
     private
 
       def load_budget
-        @budget = Budget.find_by(id: params[:budget_id])
+        @budget = Budget.find_by_slug_or_id(params[:budget_id]) || Budget.first
       end
 
       def load_heading
-        @heading = if params[:heading_id].present?
+        if @budget.present?
-                     @budget.headings.find(params[:heading_id])
+          headings = @budget.headings
-                   else
+          @heading = headings.find_by_slug_or_id(params[:heading_id]) || headings.first
-                     @budget.headings.first
+        end
-                   end
       end
 
   end

app/controllers/budgets/stats_controller.rb

@@ -13,7 +13,7 @@ module Budgets
     private
 
       def load_budget
-        @budget = Budget.find_by(slug: params[:budget_id]) || Budget.find_by(id: params[:budget_id])
+        @budget = Budget.find_by_slug_or_id! params[:budget_id]
       end
 
   end

app/controllers/budgets_controller.rb

@@ -3,6 +3,7 @@ class BudgetsController < ApplicationController
   include BudgetsHelper
   feature_flag :budgets
 
+  before_action :load_budget, only: :show
   load_and_authorize_resource
   before_action :set_default_budget_filter, only: :show
   has_filters %w[not_unfeasible feasible unfeasible unselected selected winners], only: :show
@@ -19,4 +20,10 @@ class BudgetsController < ApplicationController
     @banners = Banner.in_section("budgets").with_active
   end
 
+  private
+
+    def load_budget
+      @budget = Budget.find_by_slug_or_id! params[:id]
+    end
+
 end

app/controllers/management/budgets/investments_controller.rb

@@ -1,4 +1,5 @@
 class Management::Budgets::InvestmentsController < Management::BaseController
+  before_action :load_budget
 
   load_resource :budget
   load_resource :investment, through: :budget, class: "Budget::Investment"
@@ -60,6 +61,10 @@ class Management::Budgets::InvestmentsController < Management::BaseController
       check_verified_user t("management.budget_investments.alert.unverified_user")
     end
 
+    def load_budget
+      @budget = Budget.find_by_slug_or_id! params[:budget_id]
+    end
+
     def load_categories
       @categories = ActsAsTaggableOn::Tag.category.order(:name)
     end

app/controllers/valuation/budget_investments_controller.rb

@@ -65,7 +65,7 @@ class Valuation::BudgetInvestmentsController < Valuation::BaseController
     end
 
     def load_budget
-      @budget = Budget.find(params[:budget_id])
+      @budget = Budget.find_by_slug_or_id! params[:budget_id]
     end
 
     def load_investment

app/models/budget/investment.rb

@@ -113,7 +113,7 @@ class Budget
     end
 
     def self.scoped_filter(params, current_filter)
-      budget  = Budget.find_by(slug: params[:budget_id]) || Budget.find_by(id: params[:budget_id])
+      budget  = Budget.find_by_slug_or_id params[:budget_id]
       results = Investment.by_budget(budget)
 
       results = results.where("cached_votes_up + physical_votes >= ?",

app/models/concerns/sluggable.rb

@@ -7,6 +7,10 @@ module Sluggable
     def self.find_by_slug_or_id(slug_or_id)
       find_by_slug(slug_or_id) || find_by_id(slug_or_id)
     end
+
+    def self.find_by_slug_or_id!(slug_or_id)
+      find_by_slug(slug_or_id) || find(slug_or_id)
+    end
   end
 
   def generate_slug

spec/controllers/budgets/ballots/lines_controller_spec.rb

@@ -0,0 +1,25 @@
+require "rails_helper"
+
+describe Budgets::Ballot::LinesController do
+
+  describe "#load_budget" do
+
+    it "raises an error if budget slug is not found" do
+      controller.params[:budget_id] = "wrong_budget"
+
+      expect do
+        controller.send(:load_budget)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    it "raises an error if budget id is not found" do
+      controller.params[:budget_id] = 0
+
+      expect do
+        controller.send(:load_budget)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+  end
+
+end

spec/features/admin/budget_groups_spec.rb

@@ -32,6 +32,43 @@ describe "Admin budget groups" do
 
   end
 
+  context "Load" do
+
+    let!(:budget) { create(:budget, slug: "budget_slug") }
+    let!(:group)  { create(:budget_group, slug: "group_slug", budget: budget) }
+
+    scenario "finds budget and group by slug" do
+      visit edit_admin_budget_group_path("budget_slug", "group_slug")
+      expect(page).to have_content(budget.name)
+      expect(page).to have_field "Group name", with: group.name
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit edit_admin_budget_group_path("wrong_budget", group)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit edit_admin_budget_group_path(0, group)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if group slug is not found" do
+      expect do
+        visit edit_admin_budget_group_path(budget, "wrong_group")
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if group id is not found" do
+      expect do
+        visit edit_admin_budget_group_path(budget, 0)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+  end
+
   context "Index" do
 
     scenario "Displaying no groups for budget" do

spec/features/admin/budget_headings_spec.rb

@@ -33,6 +33,56 @@ describe "Admin budget headings" do
 
   end
 
+  context "Load" do
+
+    let!(:budget)  { create(:budget, slug: "budget_slug") }
+    let!(:group)   { create(:budget_group, slug: "group_slug", budget: budget) }
+    let!(:heading) { create(:budget_heading, slug: "heading_slug", group: group) }
+
+    scenario "finds budget, group and heading by slug" do
+      visit edit_admin_budget_group_heading_path("budget_slug", "group_slug", "heading_slug")
+      expect(page).to have_content(budget.name)
+      expect(page).to have_content(group.name)
+      expect(page).to have_field "Heading name", with: heading.name
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit edit_admin_budget_group_heading_path("wrong_budget", group, heading)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit edit_admin_budget_group_heading_path(0, group, heading)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if group slug is not found" do
+      expect do
+        visit edit_admin_budget_group_heading_path(budget, "wrong_group", heading)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if group id is not found" do
+      expect do
+        visit edit_admin_budget_group_heading_path(budget, 0, heading)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if heading slug is not found" do
+      expect do
+        visit edit_admin_budget_group_heading_path(budget, group, "wrong_heading")
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if heading id is not found" do
+      expect do
+        visit edit_admin_budget_group_heading_path(budget, group, 0)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+  end
+
   context "Index" do
 
     scenario "Displaying no headings for group" do

spec/features/admin/budget_investments_spec.rb

@@ -32,6 +32,34 @@ describe "Admin budget investments" do
 
   end
 
+  context "Load" do
+
+    let(:group)      { create(:budget_group, budget: budget) }
+    let(:heading)    { create(:budget_heading, group: group) }
+    let!(:investment) { create(:budget_investment, heading: heading) }
+
+    before { budget.update(slug: "budget_slug") }
+
+    scenario "finds investments using budget slug" do
+      visit admin_budget_budget_investments_path("budget_slug")
+
+      expect(page).to have_link investment.title
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit admin_budget_budget_investments_path("wrong_budget", investment)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit admin_budget_budget_investments_path(0, investment)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+  end
+
   context "Index" do
 
     scenario "Displaying investments" do

spec/features/admin/budgets_spec.rb

@@ -24,6 +24,29 @@ describe "Admin budgets" do
 
   end
 
+  context "Load" do
+
+    let!(:budget) { create(:budget, slug: "budget_slug") }
+
+    scenario "finds budget by slug" do
+      visit admin_budget_path("budget_slug")
+      expect(page).to have_content(budget.name)
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit admin_budget_path("wrong_budget")
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit admin_budget_path(0)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+  end
+
   context "Index" do
 
     scenario "Displaying no open budgets text" do

spec/features/budgets/ballots_spec.rb

@@ -8,6 +8,55 @@ describe "Ballots" do
   let!(:california) { create(:budget_heading, group: states, name: "California", price: 1000) }
   let!(:new_york)   { create(:budget_heading, group: states, name: "New York", price: 1000000) }
 
+  context "Load" do
+
+    let(:ballot) { create(:budget_ballot, user: user, budget: budget) }
+
+    before do
+      budget.update(slug: "budget_slug")
+      ballot.investments << create(:budget_investment, :selected, heading: california)
+      login_as(user)
+    end
+
+    scenario "finds ballot using budget slug" do
+      visit budget_ballot_path("budget_slug")
+
+      expect(page).to have_content("You have voted one investment")
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit budget_ballot_path("wrong_budget")
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit budget_ballot_path(0)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+  end
+
+  context "Lines Load" do
+
+    let!(:investment) { create(:budget_investment, :selected, heading: california) }
+
+    before do
+      create(:budget_ballot, user: user, budget: budget)
+      budget.update(slug: "budget_slug")
+      login_as(user)
+    end
+
+    scenario "finds ballot lines using budget slug", :js do
+      visit budget_investments_path("budget_slug", states, california)
+      add_to_ballot(investment)
+
+      within("#sidebar") { expect(page).to have_content investment.title }
+    end
+
+  end
+
   context "Voting" do
 
     before do

spec/features/budgets/budgets_spec.rb

@@ -6,6 +6,30 @@ describe "Budgets" do
   let(:level_two_user)     { create(:user, :level_two) }
   let(:allowed_phase_list) { ["balloting", "reviewing_ballots", "finished"] }
 
+  context "Load" do
+
+    before { budget.update(slug: "budget_slug") }
+
+    scenario "finds budget by slug" do
+      visit budget_path("budget_slug")
+
+      expect(page).to have_content budget.name
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit budget_path("wrong_budget")
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit budget_path(0)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+  end
+
   context "Index" do
 
     scenario "Show normal index with links" do

spec/features/budgets/executions_spec.rb

@@ -11,6 +11,22 @@ describe "Executions" do
   let!(:investment4) { create(:budget_investment, :winner,       heading: heading) }
   let!(:investment3) { create(:budget_investment, :incompatible, heading: heading) }
 
+  scenario "finds budget by id or slug" do
+    budget.update(slug: "budget_slug")
+
+    visit budget_executions_path("budget_slug")
+    within(".budgets-stats") { expect(page).to have_content budget.name }
+
+    visit budget_executions_path(budget)
+    within(".budgets-stats") { expect(page).to have_content budget.name }
+
+    visit budget_executions_path("budget_slug")
+    within(".budgets-stats") { expect(page).to have_content budget.name }
+
+    visit budget_executions_path(budget)
+    within(".budgets-stats") { expect(page).to have_content budget.name }
+  end
+
   scenario "only displays investments with milestones" do
     create(:milestone, milestoneable: investment1)
 

spec/features/budgets/groups_spec.rb

@@ -2,8 +2,45 @@ require "rails_helper"
 
 describe "Budget Groups" do
 
-  let(:budget) { create(:budget) }
+  let(:budget) { create(:budget, slug: "budget_slug") }
-  let(:group)  { create(:budget_group, budget: budget) }
+  let!(:group)  { create(:budget_group, slug: "group_slug", budget: budget) }
+
+  context "Load" do
+
+    scenario "finds group using budget slug and group slug" do
+      visit budget_group_path("budget_slug", "group_slug")
+      expect(page).to have_content "Select an option"
+    end
+
+    scenario "finds group using budget id and group id" do
+      visit budget_group_path(budget, group)
+      expect(page).to have_content "Select an option"
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit budget_group_path("wrong_budget", group)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit budget_group_path(0, group)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if group slug is not found" do
+      expect do
+        visit budget_group_path(budget, "wrong_group")
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if group id is not found" do
+      expect do
+        visit budget_group_path(budget, 0)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+  end
 
   context "Show" do
     scenario "Headings are sorted by name" do

spec/features/budgets/investments_spec.rb

@@ -26,6 +26,53 @@ describe "Budget Investments" do
     it_behaves_like "relationable", Budget::Investment
   end
 
+  context "Load" do
+
+    let(:investment) { create(:budget_investment, heading: heading) }
+
+    before do
+      budget.update(slug: "budget_slug")
+      heading.update(slug: "heading_slug")
+    end
+
+    scenario "finds investment using budget slug" do
+      visit budget_investment_path("budget_slug", investment)
+
+      expect(page).to have_content investment.title
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit budget_investment_path("wrong_budget", investment)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit budget_investment_path(0, investment)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "finds investment using heading slug" do
+      visit budget_investment_path(budget, investment, heading_id: "heading_slug")
+
+      expect(page).to have_content investment.title
+    end
+
+    scenario "raises an error if heading slug is not found" do
+      expect do
+        visit budget_investment_path(budget, investment, heading_id: "wrong_heading")
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if heading id is not found" do
+      expect do
+        visit budget_investment_path(budget, investment, heading_id: 0)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+  end
+
   scenario "Index" do
     investments = [create(:budget_investment, heading: heading),
                    create(:budget_investment, heading: heading),
@@ -40,7 +87,7 @@ describe "Budget Investments" do
     investments.each do |investment|
       within("#budget-investments") do
         expect(page).to have_content investment.title
-        expect(page).to have_css("a[href='#{budget_investment_path(budget_id: budget.id, id: investment.id)}']", text: investment.title)
+        expect(page).to have_css("a[href='#{budget_investment_path(budget, id: investment.id)}']", text: investment.title)
         expect(page).not_to have_content(unfeasible_investment.title)
       end
     end
@@ -476,7 +523,7 @@ describe "Budget Investments" do
       investment3 = create(:budget_investment, heading: heading)
       investment4 = create(:budget_investment, :feasible, heading: heading)
 
-      visit budget_investments_path(budget_id: budget.id, heading_id: heading.id, filter: "unfeasible")
+      visit budget_investments_path(budget, heading_id: heading.id, filter: "unfeasible")
 
       within("#budget-investments") do
         expect(page).to have_css(".budget-investment", count: 1)
@@ -810,7 +857,7 @@ describe "Budget Investments" do
 
     scenario "Create with invisible_captcha honeypot field" do
       login_as(author)
-      visit new_budget_investment_path(budget_id: budget.id)
+      visit new_budget_investment_path(budget)
 
       select  heading.name, from: "budget_investment_heading_id"
       fill_in "budget_investment_title", with: "I am a bot"
@@ -822,14 +869,14 @@ describe "Budget Investments" do
 
       expect(page.status_code).to eq(200)
       expect(page.html).to be_empty
-      expect(page).to have_current_path(budget_investments_path(budget_id: budget.id))
+      expect(page).to have_current_path(budget_investments_path(budget))
     end
 
     scenario "Create budget investment too fast" do
       allow(InvisibleCaptcha).to receive(:timestamp_threshold).and_return(Float::INFINITY)
 
       login_as(author)
-      visit new_budget_investment_path(budget_id: budget.id)
+      visit new_budget_investment_path(budget)
 
       select  heading.name, from: "budget_investment_heading_id"
       fill_in "budget_investment_title", with: "I am a bot"
@@ -839,13 +886,13 @@ describe "Budget Investments" do
       click_button "Create Investment"
 
       expect(page).to have_content "Sorry, that was too quick! Please resubmit"
-      expect(page).to have_current_path(new_budget_investment_path(budget_id: budget.id))
+      expect(page).to have_current_path(new_budget_investment_path(budget))
     end
 
     scenario "Create" do
       login_as(author)
 
-      visit new_budget_investment_path(budget_id: budget.id)
+      visit new_budget_investment_path(budget)
 
       select  heading.name, from: "budget_investment_heading_id"
       fill_in "budget_investment_title", with: "Build a skyscraper"
@@ -872,7 +919,7 @@ describe "Budget Investments" do
     scenario "Errors on create" do
       login_as(author)
 
-      visit new_budget_investment_path(budget_id: budget.id)
+      visit new_budget_investment_path(budget)
       click_button "Create Investment"
       expect(page).to have_content error_message
     end
@@ -948,7 +995,7 @@ describe "Budget Investments" do
 
       login_as(author)
 
-      visit new_budget_investment_path(budget_id: budget.id)
+      visit new_budget_investment_path(budget)
 
       select_options = find("#budget_investment_heading_id").all("option").collect(&:text)
       expect(select_options.first).to eq("")
@@ -964,7 +1011,7 @@ describe "Budget Investments" do
 
     investment = create(:budget_investment, heading: heading)
 
-    visit budget_investment_path(budget_id: budget.id, id: investment.id)
+    visit budget_investment_path(budget, id: investment.id)
 
     expect(page).to have_content(investment.title)
     expect(page).to have_content(investment.description)
@@ -984,7 +1031,7 @@ describe "Budget Investments" do
       scenario "Price & explanation is shown when Budget is on published prices phase" do
         Budget::Phase::PUBLISHED_PRICES_PHASES.each do |phase|
           budget.update(phase: phase)
-          visit budget_investment_path(budget_id: budget.id, id: investment.id)
+          visit budget_investment_path(budget, id: investment.id)
 
           expect(page).to have_content(investment.formatted_price)
           expect(page).to have_content(investment.price_explanation)
@@ -1003,7 +1050,7 @@ describe "Budget Investments" do
       scenario "Price & explanation isn't shown when Budget is not on published prices phase" do
         (Budget::Phase::PHASE_KINDS - Budget::Phase::PUBLISHED_PRICES_PHASES).each do |phase|
           budget.update(phase: phase)
-          visit budget_investment_path(budget_id: budget.id, id: investment.id)
+          visit budget_investment_path(budget, id: investment.id)
 
           expect(page).not_to have_content(investment.formatted_price)
           expect(page).not_to have_content(investment.price_explanation)
@@ -1025,7 +1072,7 @@ describe "Budget Investments" do
       scenario "Price & explanation isn't shown for any Budget's phase" do
         Budget::Phase::PHASE_KINDS.each do |phase|
           budget.update(phase: phase)
-          visit budget_investment_path(budget_id: budget.id, id: investment.id)
+          visit budget_investment_path(budget, id: investment.id)
 
           expect(page).not_to have_content(investment.formatted_price)
           expect(page).not_to have_content(investment.price_explanation)
@@ -1044,7 +1091,7 @@ describe "Budget Investments" do
     Setting["feature.community"] = true
 
     investment = create(:budget_investment, heading: heading)
-    visit budget_investment_path(budget_id: budget.id, id: investment.id)
+    visit budget_investment_path(budget, id: investment.id)
     expect(page).to have_content "Access the community"
 
     Setting["feature.community"] = false
@@ -1054,14 +1101,14 @@ describe "Budget Investments" do
     Setting["feature.community"] = false
 
     investment = create(:budget_investment, heading: heading)
-    visit budget_investment_path(budget_id: budget.id, id: investment.id)
+    visit budget_investment_path(budget, id: investment.id)
     expect(page).not_to have_content "Access the community"
   end
 
   scenario "Don't display flaggable buttons" do
     investment = create(:budget_investment, heading: heading)
 
-    visit budget_investment_path(budget_id: budget.id, id: investment.id)
+    visit budget_investment_path(budget, id: investment.id)
 
     expect(page).not_to have_selector ".js-follow"
   end
@@ -1092,7 +1139,7 @@ describe "Budget Investments" do
 
     scenario "Budget in selecting phase" do
       budget.update(phase: "selecting")
-      visit budget_investment_path(budget_id: budget.id, id: investment.id)
+      visit budget_investment_path(budget, id: investment.id)
 
       expect(page).not_to have_content("Unfeasibility explanation")
       expect(page).not_to have_content("Price explanation")
@@ -1120,14 +1167,14 @@ describe "Budget Investments" do
                         heading: heading,
                         unfeasibility_explanation: "The unfeasible explanation")
 
-    visit budget_investment_path(budget_id: budget.id, id: investment.id)
+    visit budget_investment_path(budget, id: investment.id)
 
     expect(page).not_to have_content("Unfeasibility explanation")
     expect(page).not_to have_content("Local government is not competent in this")
     expect(page).not_to have_content("This investment project has been marked as not feasible "\
                                      "and will not go to balloting phase")
 
-    visit budget_investment_path(budget_id: budget.id, id: investment_2.id)
+    visit budget_investment_path(budget, id: investment_2.id)
 
     expect(page).to have_content("Unfeasibility explanation")
     expect(page).to have_content("The unfeasible explanation")
@@ -1147,7 +1194,7 @@ describe "Budget Investments" do
                         group: group,
                         heading: heading)
 
-    visit budget_investment_path(budget_id: budget.id, id: investment.id)
+    visit budget_investment_path(budget, id: investment.id)
 
     expect(page).to have_content("This investment project has been selected for balloting phase")
   end
@@ -1166,13 +1213,13 @@ describe "Budget Investments" do
                         group: group,
                         heading: heading)
 
-    visit budget_investment_path(budget_id: budget.id, id: investment.id)
+    visit budget_investment_path(budget, id: investment.id)
 
     expect(page).not_to have_content("Winning investment project")
 
     budget.update(phase: "finished")
 
-    visit budget_investment_path(budget_id: budget.id, id: investment.id)
+    visit budget_investment_path(budget, id: investment.id)
 
     expect(page).to have_content("Winning investment project")
   end
@@ -1189,7 +1236,7 @@ describe "Budget Investments" do
                         group: group,
                         heading: heading)
 
-    visit budget_investment_path(budget_id: budget.id, id: investment.id)
+    visit budget_investment_path(budget, id: investment.id)
 
     expect(page).to have_content("This investment project has not been selected for balloting phase")
   end
@@ -1205,7 +1252,7 @@ describe "Budget Investments" do
                         group: group,
                         heading: heading)
 
-    visit budget_investment_path(budget_id: budget.id, id: investment.id)
+    visit budget_investment_path(budget, id: investment.id)
 
     within("aside") do
       expect(page).to have_content("Investment project")
@@ -1225,7 +1272,7 @@ describe "Budget Investments" do
                         heading: heading,
                         unfeasibility_explanation: "Local government is not competent in this matter")
 
-    visit budget_investment_path(budget_id: budget.id, id: investment.id)
+    visit budget_investment_path(budget, id: investment.id)
 
     expect(page).not_to have_content("Unfeasibility explanation")
     expect(page).not_to have_content("Local government is not competent in this matter")
@@ -1243,7 +1290,7 @@ describe "Budget Investments" do
                         heading: heading,
                         unfeasibility_explanation: "Local government is not competent in this matter")
 
-    visit budget_investment_path(budget_id: budget.id, id: investment.id)
+    visit budget_investment_path(budget, id: investment.id)
 
     expect(page).not_to have_content("Unfeasibility explanation")
     expect(page).not_to have_content("Local government is not competent in this matter")
@@ -1647,7 +1694,7 @@ describe "Budget Investments" do
       investment3 = create(:budget_investment, :selected,   :feasible, heading: heading, valuation_finished: true)
       investment4 = create(:budget_investment, :selected,   :feasible, heading: heading, valuation_finished: true)
 
-      visit budget_investments_path(budget_id: budget.id, heading_id: heading.id, filter: "unselected")
+      visit budget_investments_path(budget, heading_id: heading.id, filter: "unselected")
 
       within("#budget-investments") do
         expect(page).to have_css(".budget-investment", count: 1)
@@ -1691,7 +1738,7 @@ describe "Budget Investments" do
     scenario "Do not display vote button for unselected investments in index" do
       investment = create(:budget_investment, :unselected, heading: heading)
 
-      visit budget_investments_path(budget_id: budget.id, heading_id: heading.id, filter: "unselected")
+      visit budget_investments_path(budget, heading_id: heading.id, filter: "unselected")
 
       expect(page).to have_content investment.title
       expect(page).not_to have_link("Vote")

spec/features/budgets/results_spec.rb

@@ -52,6 +52,30 @@ describe "Results" do
     end
   end
 
+  scenario "Does not raise error if budget (slug or id) is not found" do
+    visit budget_results_path("wrong budget")
+
+    within(".budgets-stats") do
+      expect(page).to have_content "Participatory budget results"
+    end
+
+    visit budget_results_path(0)
+
+    within(".budgets-stats") do
+      expect(page).to have_content "Participatory budget results"
+    end
+  end
+
+  scenario "Loads budget and heading by slug" do
+    visit budget_results_path(budget.slug, heading.slug)
+
+    expect(page).to have_selector("a.is-active", text: heading.name)
+
+    within("#budget-investments-compatible") do
+      expect(page).to have_content investment1.title
+    end
+  end
+
   scenario "Load first budget heading if not specified" do
     other_heading = create(:budget_heading, group: group)
     other_investment = create(:budget_investment, :winner, heading: other_heading)

spec/features/budgets/stats_spec.rb

@@ -2,14 +2,36 @@ require "rails_helper"
 
 describe "Stats" do
 
-  let(:budget)  { create(:budget) }
+  let(:budget)  { create(:budget, :finished) }
   let(:group)   { create(:budget_group, budget: budget) }
   let(:heading) { create(:budget_heading, group: group, price: 1000) }
 
+  context "Load" do
+
+    before { budget.update(slug: "budget_slug") }
+
+    scenario "finds budget by slug" do
+      visit budget_stats_path("budget_slug")
+
+      expect(page).to have_content budget.name
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit budget_stats_path("wrong_budget")
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit budget_stats_path(0)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+  end
+
   describe "Show" do
     describe "advanced stats" do
-      let(:budget) { create(:budget, :finished) }
-
       scenario "advanced stats enabled" do
         budget.update(advanced_stats_enabled: true)
 

spec/features/management/budget_investments_spec.rb

@@ -3,7 +3,7 @@ require "rails_helper"
 describe "Budget Investments" do
 
   let(:manager) { create(:manager) }
-  let(:budget)  { create(:budget, phase: "selecting", name: "2033") }
+  let(:budget)  { create(:budget, phase: "selecting", name: "2033", slug: "budget_slug") }
   let(:group)   { create(:budget_group, budget: budget, name: "Whole city") }
   let(:heading) { create(:budget_heading, group: group, name: "Health") }
 
@@ -18,6 +18,33 @@ describe "Budget Investments" do
                   { "budget_id": "budget_id" },
                   management = true
 
+  context "Load" do
+
+    let(:investment) { create(:budget_investment, budget: budget) }
+    let(:user)       { create(:user, :level_two) }
+
+    before { login_managed_user(user) }
+
+    scenario "finds investment using budget slug" do
+      visit management_budget_investment_path("budget_slug", investment)
+
+      expect(page).to have_content investment.title
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit management_budget_investment_path("wrong_budget", investment)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit management_budget_investment_path(0, investment)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+  end
+
   context "Create" do
     before { heading.budget.update(phase: "accepting") }
 

spec/features/valuation/budget_investments_spec.rb

@@ -11,6 +11,30 @@ describe "Valuation budget investments" do
     login_as(valuator.user)
   end
 
+  context "Load" do
+
+    before { budget.update(slug: "budget_slug") }
+
+    scenario "finds investment using budget slug" do
+      visit valuation_budget_budget_investments_path("budget_slug")
+
+      expect(page).to have_content budget.name
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit valuation_budget_budget_investments_path("wrong_budget")
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit valuation_budget_budget_investments_path(0)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+  end
+
   scenario "Disabled with a feature flag" do
     Setting["process.budgets"] = nil
     expect{

spec/models/budget/investment_spec.rb

@@ -382,6 +382,30 @@ describe Budget::Investment do
     end
   end
 
+  describe "scoped_filter" do
+
+    let!(:budget)     { create(:budget, slug: "budget_slug") }
+    let!(:group)      { create(:budget_group, budget: budget) }
+    let!(:heading)    { create(:budget_heading, group: group) }
+    let!(:investment) { create(:budget_investment, :feasible, heading: heading) }
+
+    it "finds budget by id or slug" do
+      result = described_class.scoped_filter({budget_id: budget.id}, nil)
+      expect(result.count).to be 1
+      expect(result.first.id).to be investment.id
+
+      result = described_class.scoped_filter({budget_id: "budget_slug"}, nil)
+      expect(result.count).to be 1
+      expect(result.first.id).to be investment.id
+    end
+
+    it "does not raise error if budget is not found" do
+      result = described_class.scoped_filter({budget_id: "wrong_budget"}, nil)
+      expect(result).to be_empty
+    end
+
+  end
+
   describe "scopes" do
     describe "valuation_open" do
       it "returns all investments with false valuation_finished" do