From 802be297739312872291c88ea33cb3529cd02e4a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Wed, 25 Sep 2019 23:23:34 +0200 Subject: [PATCH] Simplify maximum limit of direct messages specs Now the tests are easier to understand: when the limit is 3, if you create 3, the fourth one is invalid. If you create 2, the third one is valid. --- spec/models/direct_message_spec.rb | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/spec/models/direct_message_spec.rb b/spec/models/direct_message_spec.rb index cacb976da..5dda929e2 100644 --- a/spec/models/direct_message_spec.rb +++ b/spec/models/direct_message_spec.rb @@ -36,9 +36,7 @@ describe DirectMessage do it "is not valid if above maximum" do sender = create(:user) - direct_message1 = create(:direct_message, sender: sender) - direct_message2 = create(:direct_message, sender: sender) - direct_message3 = create(:direct_message, sender: sender) + 3.times { create(:direct_message, sender: sender) } direct_message4 = build(:direct_message, sender: sender) expect(direct_message4).not_to be_valid @@ -46,8 +44,7 @@ describe DirectMessage do it "is valid if below maximum" do sender = create(:user) - direct_message1 = create(:direct_message, sender: sender) - direct_message2 = create(:direct_message, sender: sender) + 2.times { create(:direct_message, sender: sender) } direct_message3 = build(:direct_message, sender: sender) expect(direct_message3).to be_valid