consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reduce locales used in remote translations tests

Browse Source 
This way we can reduce the number of locales used in the test
environment as well, while still testing every possible scenario for
remote translations.
This commit is contained in:
Javi Martín
2019-09-09 13:16:02 +02:00
committed by Pierre Mesure
parent 7fc4106780
commit 7f8474ea95
1 changed files with 5 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
spec/features/remote_translations_spec.rb
View File

@@ -5,8 +5,7 @@ describe "Remote Translations" do
before do before do
Setting["feature.remote_translations"] = true Setting["feature.remote_translations"] = true
create(:proposal) create(:proposal)
available_locales_response = ["ar", "de", "en", "es", "fa", "fr", "he", "it", "nl", "pl", available_locales_response = %w[de en es fr pt zh-Hans]
"pt", "sv", "zh-Hans", "zh-Hant"]
expect(RemoteTranslations::Microsoft::AvailableLocales).to receive(:available_locales). expect(RemoteTranslations::Microsoft::AvailableLocales).to receive(:available_locales).
and_return(available_locales_response) and_return(available_locales_response)
end end
@@ -27,18 +26,14 @@ describe "Remote Translations" do
end end
scenario "should display text in English" do scenario "should display text in English" do
available_locales_with_fallback_en = [:ar, :de, :fa, :he, :nl, :pl, :sv] visit root_path(locale: :de)
visit root_path(locale: available_locales_with_fallback_en.sample)
expect(page).to have_css ".remote-translations-button" expect(page).to have_css ".remote-translations-button"
expect(page).to have_content "The content of this page is not available in your language" expect(page).to have_content "The content of this page is not available in your language"
end end
scenario "should display text in English after parse key" do scenario "should display text in English after parse key" do
available_locales_with_fallback_en = [:"zh-CN", :"zh-TW"] visit root_path(locale: :"zh-CN")
visit root_path(locale: available_locales_with_fallback_en.sample)
expect(page).to have_css ".remote-translations-button" expect(page).to have_css ".remote-translations-button"
expect(page).to have_content "The content of this page is not available in your language" expect(page).to have_content "The content of this page is not available in your language"
@@ -53,9 +48,7 @@ describe "Remote Translations" do
end end
scenario "with locale that has :es fallback" do scenario "with locale that has :es fallback" do
available_locales_with_fallback_es = [:es, :fr, :it] visit root_path(locale: :fr)
visit root_path(locale: available_locales_with_fallback_es.sample)
expect(page).to have_css ".remote-translations-button" expect(page).to have_css ".remote-translations-button"
expect(page).to have_content "El contenido de esta página no está disponible en tu idioma" expect(page).to have_content "El contenido de esta página no está disponible en tu idioma"
@@ -72,9 +65,7 @@ describe "Remote Translations" do
end end
scenario "Not display remote translation button when locale is not included in microsoft translate client" do scenario "Not display remote translation button when locale is not included in microsoft translate client" do
not_available_locales = [:val, :gl, :sq] visit root_path(locale: :nl)
visit root_path(locale: not_available_locales.sample)
expect(page).not_to have_css ".remote-translations-button" expect(page).not_to have_css ".remote-translations-button"
end end