From 37c9e6bcdeb46e7b6f016d5b89b7fb816a6490c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Fri, 14 Jun 2024 15:27:42 +0200 Subject: [PATCH 1/2] Update screenshots path in GitHub Actions Since we upgraded to Rails 7.0 in commmit 8596f1539, the screenshots started to be stored in `tmp/capybara`, so the step uploading screenshots wasn't doing anything. --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index baf23d7a4..42eed46cb 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -72,7 +72,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: screenshots - path: tmp/screenshots + path: tmp/capybara/ coveralls: permissions: contents: none From baec41c43d739724c290b5c0fdf4105a37c0994c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Fri, 14 Jun 2024 17:55:27 +0200 Subject: [PATCH 2/2] Fix screenshots in GitHub Action when two jobs fail The upload-artifact action does not support using the same artifact name in different jobs (or in different matrix scenarios) since version 4, which we started using in commit acfaada82. That meant that screenshots were not uploaded correctly when two or more knapsack nodes failed. --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 42eed46cb..dfb173e4a 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -71,7 +71,7 @@ jobs: if: failure() uses: actions/upload-artifact@v4 with: - name: screenshots + name: screenshots-${{ matrix.ci_node_index }} path: tmp/capybara/ coveralls: permissions: