From bb75c03ae01aae0ac21b3d9599b7fa6981ff4b4a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 15 Oct 2020 17:28:40 +0200 Subject: [PATCH 1/2] Remove unneeded line loading knapsack pro tasks This line isn't needed since knapsack_pro version 0.46.0 [1]. [1] https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md#0460 --- Rakefile | 1 - 1 file changed, 1 deletion(-) diff --git a/Rakefile b/Rakefile index 8601435a2..3f060eddd 100644 --- a/Rakefile +++ b/Rakefile @@ -4,7 +4,6 @@ require File.expand_path("../config/application", __FILE__) Rails.application.load_tasks if Rake::Task.tasks.empty? -KnapsackPro.load_tasks if defined?(KnapsackPro) if Rails.env.development? require "github_changelog_generator/task" From 416b4741229dbe313e0b1c857a10e1619650455a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 15 Oct 2020 19:08:24 +0200 Subject: [PATCH 2/2] Avoid timeouts in knapsack PRO The way it's recommended since knapsack_pro version 2.3.0 [1]. [1] https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md#230 --- bin/knapsack_pro_rspec | 1 + 1 file changed, 1 insertion(+) diff --git a/bin/knapsack_pro_rspec b/bin/knapsack_pro_rspec index 9aaf762ad..a3ab9b0ca 100755 --- a/bin/knapsack_pro_rspec +++ b/bin/knapsack_pro_rspec @@ -2,6 +2,7 @@ if [ "$KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC" = "" ]; then KNAPSACK_PRO_ENDPOINT=https://api-disabled-for-fork.knapsackpro.com \ KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC=disabled-for-fork \ + KNAPSACK_PRO_MAX_REQUEST_RETRIES=0 \ bundle exec rake knapsack_pro:rspec # use Regular Mode here always else # Queue Mode - dynamic tests allocation across CI nodes