check if username is available in registration form
This commit is contained in:
@@ -35,6 +35,7 @@
|
||||
//= require users
|
||||
//= require votes
|
||||
//= require annotatable
|
||||
//= require registration_form
|
||||
|
||||
|
||||
var initialize_modules = function() {
|
||||
@@ -48,6 +49,7 @@ var initialize_modules = function() {
|
||||
App.PreventDoubleSubmission.initialize();
|
||||
App.IeAlert.initialize();
|
||||
App.Annotatable.initialize();
|
||||
App.RegistrationForm.initialize();
|
||||
};
|
||||
|
||||
$(function(){
|
||||
|
||||
25
app/assets/javascripts/registration_form.js.coffee
Normal file
25
app/assets/javascripts/registration_form.js.coffee
Normal file
@@ -0,0 +1,25 @@
|
||||
App.RegistrationForm =
|
||||
|
||||
initialize: ->
|
||||
|
||||
registrationForm = $("form#new_user[action=\"/users\"]")
|
||||
usernameInput = $("input#user_username")
|
||||
|
||||
clearUsernameMessage = ->
|
||||
$("small").remove()
|
||||
|
||||
showUsernameMessage = (response) ->
|
||||
klass = if response.available then "error no-error" else "error error"
|
||||
usernameInput.after $("<small class=\"#{klass}\" style=\"margin-top: -16px;\">#{response.message}</small>")
|
||||
|
||||
validateUsername = (username) ->
|
||||
request = $.post "/user/registrations/check_username?username=#{username}"
|
||||
request.done (response) ->
|
||||
showUsernameMessage(response)
|
||||
|
||||
|
||||
if registrationForm.length > 0
|
||||
usernameInput.on "focusout", ->
|
||||
clearUsernameMessage()
|
||||
username = usernameInput.val();
|
||||
validateUsername(username) if username != ""
|
||||
@@ -843,6 +843,11 @@ span.error, small.error {
|
||||
color: $alert-color;
|
||||
}
|
||||
|
||||
span.error, small.no-error {
|
||||
background: $success-bg;
|
||||
color: $success-color;
|
||||
}
|
||||
|
||||
.error small.error {
|
||||
background: $alert-bg;
|
||||
color: $alert-color;
|
||||
|
||||
@@ -36,6 +36,14 @@ class Users::RegistrationsController < Devise::RegistrationsController
|
||||
end
|
||||
end
|
||||
|
||||
def check_username
|
||||
if User.find_by_username params[:username]
|
||||
render json: {available: false, message: t("devise_views.users.registrations.new.username_is_not_available")}
|
||||
else
|
||||
render json: {available: true, message: t("devise_views.users.registrations.new.username_is_available")}
|
||||
end
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
def sign_up_params
|
||||
|
||||
@@ -71,6 +71,8 @@ en:
|
||||
organization_signup_link: "Sign up here"
|
||||
terms: "By registering you accept the %{terms}"
|
||||
terms_link: "terms and conditions of use"
|
||||
username_is_available: "The username chosen is available."
|
||||
username_is_not_available: "The username chosen is not available."
|
||||
success:
|
||||
title: "Modify your email"
|
||||
thank_you_html: "Thank you for registering for the website. You must now <b>confirm your email address</b>."
|
||||
|
||||
@@ -71,6 +71,8 @@ es:
|
||||
organization_signup_link: "Regístrate aquí"
|
||||
terms: "Al registrarte aceptas las %{terms}"
|
||||
terms_link: "condiciones de uso"
|
||||
username_is_available: "El nombre de usuario elegido está disponible."
|
||||
username_is_not_available: "El nombre de usuario elegido no está disponible."
|
||||
success:
|
||||
title: "Revisa tu correo"
|
||||
thank_you_html: "Gracias por registrarte en la web. Ahora debes <b>confirmar tu correo</b>."
|
||||
|
||||
@@ -19,7 +19,7 @@ Rails.application.routes.draw do
|
||||
|
||||
devise_scope :user do
|
||||
patch '/user/confirmation', to: 'users/confirmations#update', as: :update_user_confirmation
|
||||
|
||||
post '/user/registrations/check_username', to: 'users/registrations#check_username'
|
||||
get 'users/sign_up/success', to: 'users/registrations#success'
|
||||
get 'users/registrations/delete_form', to: 'users/registrations#delete_form'
|
||||
delete 'users/registrations', to: 'users/registrations#delete'
|
||||
|
||||
34
spec/controllers/users/registrations_controller_spec.rb
Normal file
34
spec/controllers/users/registrations_controller_spec.rb
Normal file
@@ -0,0 +1,34 @@
|
||||
require 'rails_helper'
|
||||
|
||||
describe Users::RegistrationsController do
|
||||
|
||||
describe "POST check_username" do
|
||||
|
||||
before(:each) do
|
||||
@request.env["devise.mapping"] = Devise.mappings[:user]
|
||||
end
|
||||
|
||||
context "when username is available" do
|
||||
it "should return true with no error message" do
|
||||
post :check_username, username: "available username"
|
||||
|
||||
data = JSON.parse response.body, symbolize_names: true
|
||||
expect(data[:available]).to be true
|
||||
expect(data[:message]).to eq I18n.t("devise_views.users.registrations.new.username_is_available")
|
||||
end
|
||||
end
|
||||
|
||||
context "when username is not available" do
|
||||
it "should return true with no error message" do
|
||||
user = create(:user)
|
||||
post :check_username, username: user.username
|
||||
|
||||
data = JSON.parse response.body, symbolize_names: true
|
||||
expect(data[:available]).to be false
|
||||
expect(data[:message]).to eq I18n.t("devise_views.users.registrations.new.username_is_not_available")
|
||||
end
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
end
|
||||
27
spec/features/registration_form_spec.rb
Normal file
27
spec/features/registration_form_spec.rb
Normal file
@@ -0,0 +1,27 @@
|
||||
require 'rails_helper'
|
||||
|
||||
feature 'Registration form' do
|
||||
|
||||
scenario 'username is not available', :js do
|
||||
user = create(:user)
|
||||
|
||||
visit new_user_registration_path
|
||||
expect(page).to_not have_content I18n.t("devise_views.users.registrations.new.username_is_not_available")
|
||||
|
||||
fill_in "user_username", with: user.username
|
||||
check 'user_terms_of_service'
|
||||
|
||||
expect(page).to have_content I18n.t("devise_views.users.registrations.new.username_is_not_available")
|
||||
end
|
||||
|
||||
scenario 'username is available', :js do
|
||||
visit new_user_registration_path
|
||||
expect(page).to_not have_content I18n.t("devise_views.users.registrations.new.username_is_available")
|
||||
|
||||
fill_in "user_username", with: "available username"
|
||||
check 'user_terms_of_service'
|
||||
|
||||
expect(page).to have_content I18n.t("devise_views.users.registrations.new.username_is_available")
|
||||
end
|
||||
|
||||
end
|
||||
Reference in New Issue
Block a user