Use a switch to enable/disable homepage features

So it's consistent with the way we enable/disable other features.

app/components/admin/settings/featured_settings_form_component.rb

@@ -1,10 +1,12 @@
 class Admin::Settings::FeaturedSettingsFormComponent < ApplicationComponent
-  attr_reader :feature, :tab
+  attr_reader :feature, :tab, :describedby
+  alias_method :describedby?, :describedby
   delegate :enabled?, to: :feature
 
-  def initialize(feature, tab: nil)
+  def initialize(feature, tab: nil, describedby: true)
     @feature = feature
     @tab = tab
+    @describedby = describedby
   end
 
   private
@@ -20,7 +22,7 @@ class Admin::Settings::FeaturedSettingsFormComponent < ApplicationComponent
     def options
       {
         "aria-labelledby": dom_id(feature, :title),
-        "aria-describedby": dom_id(feature, :description),
+        "aria-describedby": (dom_id(feature, :description) if describedby?),
         "aria-pressed": enabled?
       }
     end

app/views/admin/homepage/_feed.html.erb

@@ -1,6 +1,6 @@
 <div id="<%= dom_id(feed) %>" class="small-12 medium-6 large-4 column end">
   <div class="callout">
-    <h3><%= t("admin.homepage.feeds.#{feed.kind}") %></h3>
+    <h3 id="<%= dom_id(feed.setting, :title) %>"><%= t("admin.homepage.feeds.#{feed.kind}") %></h3>
 
     <%= render "setting", setting: feed.setting %>
 

app/views/admin/homepage/_setting.html.erb

@@ -1,10 +1 @@
-<div id="<%= dom_id(setting) %>">
+<%= render Admin::Settings::FeaturedSettingsFormComponent.new(setting, describedby: false) %>
-  <%= form_for(setting, url: admin_setting_path(setting), method: :put) do |f| %>
-
-    <%= f.hidden_field :value,
-                        value: (setting.enabled? ? "" : "active") %>
-
-    <%= f.submit(t("admin.settings.index.features.#{setting.enabled? ? "disable" : "enable"}"),
-          class: "button #{setting.enabled? ? "hollow alert" : "success"}") %>
-  <% end %>
-</div>

app/views/admin/homepage/show.html.erb

@@ -38,7 +38,7 @@
 
 <div class="small-12 medium-6 large-4 column end">
   <div class="callout">
-    <h3 class="inline-block"><%= t("settings.#{@recommendations.key}") %></h3>
+    <h3 id="<%= dom_id(@recommendations, :title) %>" class="inline-block"><%= t("settings.#{@recommendations.key}") %></h3>
     <%= render "setting", setting: @recommendations %>
   </div>
 </div>

config/i18n-tasks.yml

@@ -160,7 +160,6 @@ ignore_unused:
   - "admin.legislation.draft_versions.*.submit_button"
   - "admin.legislation.questions.*.submit_button"
   - "admin.hidden_comments.index.hidden_*"
-  - "admin.settings.index.features.*"
   - "admin.polls.*.submit_button"
   - "admin.booths.*.submit_button"
   - "admin.admin_notifications.*.submit_button"

config/locales/en/admin.yml

@@ -1299,8 +1299,6 @@ en:
         feature_flags: Features
         features:
           enabled: "Enabled"
-          enable: "Enable"
-          disable: "Disable"
         map:
           title: Map configuration
           help: Here you can customize the way the map is displayed to users. Drag map marker or click anywhere over the map, set desired zoom and click button "Update".

config/locales/es/admin.yml

@@ -1298,8 +1298,6 @@ es:
         feature_flags: Funcionalidades
         features:
           enabled: "Activada"
-          enable: "Activar"
-          disable: "Desactivar"
         map:
           title: Configuración del mapa
           help: Aquí puedes personalizar la manera en la que se muestra el mapa a los usuarios. Arrastra el marcador o pulsa sobre cualquier parte del mapa, ajusta el zoom y pulsa el botón 'Actualizar'.

spec/components/admin/settings/featured_settings_form_component_spec.rb

@@ -11,12 +11,20 @@ describe Admin::Settings::FeaturedSettingsFormComponent do
     expect(page).to have_css "button[aria-labelledby='title_setting_#{setting.id}']"
   end
 
-  it "includes an aria-describedby attribute" do
+  describe "aria-describedby attribute" do
+    it "is rendered by default" do
       render_inline component
 
       expect(page).to have_css "button[aria-describedby='description_setting_#{setting.id}']"
     end
 
+    it "is not rendered when the describedby option is false" do
+      render_inline Admin::Settings::FeaturedSettingsFormComponent.new(setting, describedby: false)
+
+      expect(page).not_to have_css "[aria-describedby]"
+    end
+  end
+
   describe "aria-pressed attribute" do
     it "is true when the setting is enabled" do
       setting.update!(value: "active")

spec/system/admin/homepage/homepage_spec.rb

@@ -33,7 +33,7 @@ describe "Homepage", :admin do
 
       within("#widget_feed_#{proposals_feed.id}") do
         select "1", from: "widget_feed_limit"
-        click_button "Enable"
+        click_button "No"
       end
 
       visit root_path
@@ -52,7 +52,7 @@ describe "Homepage", :admin do
       visit admin_homepage_path
       within("#widget_feed_#{debates_feed.id}") do
         select "2", from: "widget_feed_limit"
-        click_button "Enable"
+        click_button "No"
       end
 
       visit root_path
@@ -73,12 +73,12 @@ describe "Homepage", :admin do
 
       within("#widget_feed_#{proposals_feed.id}") do
         select "3", from: "widget_feed_limit"
-        click_button "Enable"
+        click_button "No"
       end
 
       within("#widget_feed_#{debates_feed.id}") do
         select "3", from: "widget_feed_limit"
-        click_button "Enable"
+        click_button "No"
       end
 
       visit root_path
@@ -100,7 +100,7 @@ describe "Homepage", :admin do
       visit admin_homepage_path
       within("#widget_feed_#{processes_feed.id}") do
         select "3", from: "widget_feed_limit"
-        click_button "Enable"
+        click_button "No"
       end
 
       visit root_path
@@ -153,8 +153,8 @@ describe "Homepage", :admin do
     create(:proposal, tag_list: "Sport")
 
     visit admin_homepage_path
-    within("#setting_#{user_recommendations.id}") do
+    within("#edit_setting_#{user_recommendations.id}") do
-      click_button "Enable"
+      click_button "No"
     end
 
     expect(page).to have_content "Value updated"