From 777fb55399817450ecd0bb8de86f60581924db7c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sun, 20 Oct 2019 01:20:20 +0200 Subject: [PATCH] Don't try to save invalid resources We were saving the resource after checking it was valid, but it will always return false if the model isn't valid. --- lib/remote_translations/caller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/remote_translations/caller.rb b/lib/remote_translations/caller.rb index ed49601e1..3b069a4e9 100644 --- a/lib/remote_translations/caller.rb +++ b/lib/remote_translations/caller.rb @@ -24,10 +24,10 @@ class RemoteTranslations::Caller def destroy_remote_translation if resource.valid? remote_translation.destroy + resource.save! else remote_translation.update(error_message: resource.errors.messages) end - resource.save end def resource