Use Rails 5 conventions in migrations and models

We forgot to add these changes to pull requests which were in
development before we upgraded to Rails 5.

We're also moving the rubocop rules to the basic files, so we're
notified when we inherit from `ActiveRecord::Base`.

.rubocop.yml

@@ -93,18 +93,9 @@ Performance/UnfreezeString:
 Performance/UriDefaultParser:
   Enabled: true
 
-Rails/ActionFilter:
-  Enabled: true
-
 Rails/ActiveSupportAliases:
   Enabled: true
 
-Rails/ApplicationJob:
-  Enabled: true
-
-Rails/ApplicationRecord:
-  Enabled: true
-
 Rails/Blank:
   Enabled: true
 

.rubocop_basic.yml

@@ -38,6 +38,15 @@ Lint/UselessAssignment:
 Metrics/LineLength:
   Max: 110
 
+Rails/ActionFilter:
+  Enabled: true
+
+Rails/ApplicationJob:
+  Enabled: true
+
+Rails/ApplicationRecord:
+  Enabled: true
+
 RSpec/NotToNot:
   Enabled: true
 

app/models/budget/investment/change_log.rb

@@ -1,4 +1,4 @@
-class Budget::Investment::ChangeLog < ActiveRecord::Base
+class Budget::Investment::ChangeLog < ApplicationRecord
   belongs_to :author, -> { with_hidden }, class_name: "User", foreign_key: "author_id", required: false
 
   validates :old_value, presence: true

app/models/download_setting.rb

@@ -1,4 +1,4 @@
-class DownloadSetting < ActiveRecord::Base
+class DownloadSetting < ApplicationRecord
   validates :name_model, presence: true
   validates :name_field, presence: true
 

db/migrate/20190312100543_create_download_settings.rb

@@ -1,4 +1,4 @@
-class CreateDownloadSettings < ActiveRecord::Migration
+class CreateDownloadSettings < ActiveRecord::Migration[4.2]
   def change
     create_table :download_settings do |t|
       t.string :name_model, null: false

db/migrate/20190321144328_add_config_to_download_settings.rb

@@ -1,4 +1,4 @@
-class AddConfigToDownloadSettings < ActiveRecord::Migration
+class AddConfigToDownloadSettings < ActiveRecord::Migration[4.2]
   def change
     add_column :download_settings, :config, :integer, default: 0, null: false
 

db/migrate/20190408083819_add_actions_to_valuators.rb

@@ -1,4 +1,4 @@
-class AddActionsToValuators < ActiveRecord::Migration
+class AddActionsToValuators < ActiveRecord::Migration[4.2]
   def change
     add_column :valuators, :can_comment, :boolean, default: true
     add_column :valuators, :can_edit_dossier, :boolean, default: true

db/migrate/20190423084112_create_budget_investment_change_logs.rb

@@ -1,4 +1,4 @@
-class CreateBudgetInvestmentChangeLogs < ActiveRecord::Migration
+class CreateBudgetInvestmentChangeLogs < ActiveRecord::Migration[4.2]
   def change
     create_table :budget_investment_change_logs do |t|
       t.integer :investment_id

db/migrate/20190429214633_add_date_of_birth_to_signatures.rb

@@ -1,4 +1,4 @@
-class AddDateOfBirthToSignatures < ActiveRecord::Migration
+class AddDateOfBirthToSignatures < ActiveRecord::Migration[4.2]
   def change
     add_column :signatures, :date_of_birth, :date
   end

db/migrate/20190429214851_rename_document_numbers_to_required_fields_to_verify_in_signature_sheets.rb

@@ -1,4 +1,4 @@
-class RenameDocumentNumbersToRequiredFieldsToVerifyInSignatureSheets < ActiveRecord::Migration
+class RenameDocumentNumbersToRequiredFieldsToVerifyInSignatureSheets < ActiveRecord::Migration[4.2]
   def change
     rename_column :signature_sheets, :document_numbers, :required_fields_to_verify
   end

db/migrate/20190430003908_add_postal_code_to_signatures.rb

@@ -1,4 +1,4 @@
-class AddPostalCodeToSignatures < ActiveRecord::Migration
+class AddPostalCodeToSignatures < ActiveRecord::Migration[4.2]
   def change
     add_column :signatures, :postal_code, :string
   end

db/schema.rb

@@ -1460,10 +1460,10 @@ ActiveRecord::Schema.define(version: 20190607160900) do
   end
 
   create_table "signature_sheets", force: :cascade do |t|
-    t.integer  "signable_id"
     t.string   "signable_type"
-    t.boolean  "processed",        default: false
+    t.integer  "signable_id"
     t.text     "required_fields_to_verify"
+    t.boolean  "processed",                 default: false
     t.integer  "author_id"
     t.datetime "created_at"
     t.datetime "updated_at"