From 73166e164b2acd6f9523ab95b313a8b7517b680c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Mon, 7 Oct 2024 14:00:35 +0200
Subject: [PATCH] Simplify HTML for an investment row

Since we define the `data-field` element, we can style each element
individually with CSS.

I'm not sure whether these styles make sense, though. For instance, why
is "Supports" aligned to the center, since it's a number? For now, we're
leaving it as it was.
---
 .../admin/budget_investments/investments.scss | 15 +++++++++++++
 .../budget_investments/row_component.html.erb | 22 +++++++++----------
 2 files changed, 26 insertions(+), 11 deletions(-)
 create mode 100644 app/assets/stylesheets/admin/budget_investments/investments.scss

diff --git a/app/assets/stylesheets/admin/budget_investments/investments.scss b/app/assets/stylesheets/admin/budget_investments/investments.scss
new file mode 100644
index 000000000..479c69fe9
--- /dev/null
+++ b/app/assets/stylesheets/admin/budget_investments/investments.scss
@@ -0,0 +1,15 @@
+.admin .admin-budget-investments {
+  td {
+    &[data-field=supports],
+    &[data-field=valuation_finished],
+    &[data-field=visible_to_valuators],
+    &[data-field=selected],
+    &[data-field=incompatible] {
+      text-align: center;
+    }
+
+    &:not([data-field=id], [data-field=title], [data-field=supports]) {
+      font-size: $small-font-size;
+    }
+  }
+}
diff --git a/app/components/admin/budget_investments/row_component.html.erb b/app/components/admin/budget_investments/row_component.html.erb
index 0ddd47c38..b707b56bc 100644
--- a/app/components/admin/budget_investments/row_component.html.erb
+++ b/app/components/admin/budget_investments/row_component.html.erb
@@ -7,41 +7,41 @@
     <%= link_to investment.title, investment_path, target: "_blank" %>
   </td>
 
-  <td class="text-center" data-field="supports">
+  <td data-field="supports">
     <%= investment.total_votes %>
   </td>
 
-  <td class="small" data-field="admin">
+  <td data-field="admin">
     <%= administrator_info %>
   </td>
 
-  <td class="small" data-field="author">
+  <td data-field="author">
     <%= investment.author.name %>
   </td>
 
-  <td class="small" data-field="valuator">
+  <td data-field="valuator">
     <%= valuators_info %>
   </td>
 
-  <td class="small" data-field="geozone">
+  <td data-field="geozone">
     <%= investment.heading.name %>
   </td>
 
-  <td class="small" data-field="feasibility">
+  <td data-field="feasibility">
     <%= t("admin.budget_investments.index.feasibility.#{investment.feasibility}") %>
   </td>
 
   <% if budget.show_money? %>
-    <td class="small" data-field="price">
+    <td data-field="price">
       <%= investment.formatted_price %>
     </td>
   <% end %>
 
-  <td class="small text-center" data-field="valuation_finished">
+  <td data-field="valuation_finished">
     <%= investment.valuation_finished? ? t("shared.yes") : t("shared.no") %>
   </td>
 
-  <td class="small text-center" data-field="visible_to_valuators">
+  <td data-field="visible_to_valuators">
     <% if can?(:admin_update, investment) %>
       <%= form_for [:admin, budget, investment], remote: true, format: :json do |f| %>
           <%= f.check_box :visible_to_valuators,
@@ -54,7 +54,7 @@
     <% end %>
   </td>
 
-  <td id="selection" class="small text-center" data-field="selected">
+  <td id="selection" data-field="selected">
     <% if investment.selected? %>
         <%= link_to_if can?(:toggle_selection, investment),
                        t("admin.budget_investments.index.selected"),
@@ -92,7 +92,7 @@
   </td>
 
   <% if params[:advanced_filters]&.include?("selected") %>
-    <td class="small text-center" data-field="incompatible">
+    <td data-field="incompatible">
       <%= investment.incompatible? ? t("shared.yes") : t("shared.no") %>
     </td>
   <% end %>