From 71e758f71c6b6a383562a60c690129540b739af6 Mon Sep 17 00:00:00 2001 From: taitus Date: Mon, 18 Nov 2024 13:13:31 +0100 Subject: [PATCH] Remove redundant ".loading-bar.complete" In the imageable_attach_new_file method used in these tests the: > expect(page).to have_css ".loading-bar.complete" is already being checked, so there is no need to verify it twice. --- spec/system/nested_imageable_spec.rb | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/spec/system/nested_imageable_spec.rb b/spec/system/nested_imageable_spec.rb index 3b6585cbe..849f82e7b 100644 --- a/spec/system/nested_imageable_spec.rb +++ b/spec/system/nested_imageable_spec.rb @@ -94,12 +94,6 @@ describe "Nested imageable" do end end - scenario "Should update loading bar style after valid file upload" do - imageable_attach_new_file(file_fixture("clippy.jpg")) - - expect(page).to have_css ".loading-bar.complete" - end - scenario "Should update loading bar style after invalid file upload" do imageable_attach_new_file(file_fixture("logo_header.png"), false) @@ -172,8 +166,6 @@ describe "Nested imageable" do imageable_attach_new_file(file_fixture("clippy.jpg")) - expect(page).to have_css ".loading-bar.complete" - click_button submit_button_text expect(page).to have_content notice_text @@ -184,8 +176,6 @@ describe "Nested imageable" do imageable_attach_new_file(file_fixture("clippy.jpg")) - expect(page).to have_css ".loading-bar.complete" - click_button submit_button_text expect(page).to have_content notice_text