consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #2903 from consul/backport-refactor-translatable-specs

Browse Source 
[Backport] Refactor translatable specs
This commit is contained in:
Raimond Garcia
2018-09-17 23:05:06 +02:00
committed by GitHub
parent ea72cd058b 0552616764
commit 71a537b4db
9 changed files with 272 additions and 367 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/controllers/notifications_controller.rb
View File

@@ -36,19 +36,11 @@ class NotificationsController < ApplicationController
end
private
def linkable_resource_path(notification)
case notification.linkable_resource.class.name
when "Budget::Investment"
budget_investment_path @notification.linkable_resource.budget, @notification.linkable_resource
when "Topic"
community_topic_path @notification.linkable_resource.community, @notification.linkable_resource
if notification.linkable_resource.is_a?(AdminNotification)
notification.linkable_resource.link || notifications_path
else
if @notification.linkable_resource.is_a?(AdminNotification)
@notification.linkable_resource.link || notifications_path
else
url_for @notification.linkable_resource
end
polymorphic_hierarchy_path(notification.linkable_resource)
end
end

17
app/helpers/comments_helper.rb
View File

@@ -41,22 +41,7 @@ module CommentsHelper
end
def commentable_path(comment)
commentable = comment.commentable
case comment.commentable_type
when "Budget::Investment"
budget_investment_path(commentable.budget_id, commentable)
when "Legislation::Question"
legislation_process_question_path(commentable.process, commentable)
when "Legislation::Annotation"
legislation_process_draft_version_annotation_path(commentable.draft_version.process, commentable.draft_version, commentable)
when "Topic"
community_topic_path(commentable.community, commentable)
when "Legislation::Proposal"
legislation_process_proposal_path(commentable.legislation_process_id, commentable)
else
commentable
end
polymorphic_hierarchy_path(comment.commentable)
end
def user_level_class(comment)