Do not call initialize_modules after every ajax call
We were calling initialize_modules after every ajax call only to apply the application javascript to new elements added though ajax calls, this is not always needed because some ajax calls do not add new elements to the user interface so there is no new elements to initialize. This technique was working fine in most cases but was causing different kind of problems at some pages where some elements where being unnecessarily reinitiliazed causing the execution of the element associated scripts as many times as the element was initialized. This fix should relief a little bit of work to users browsers. After this change we had to fix some pieces of javascript: Regarding LegistationAnnotatable module, since we are not re-initializing Annotator app we cannot destroy it so now we only need to insert the new annotation into annotator interface to keep it properly updated. Regarding Comments module, we do not need anymore the initialization check because this code only will be fired once now we do not launch application initialization after ajax calls. Also, when a new comment is created its added to the DOM through AJAX and include some elements that needs javascript initialization to work. By using "Delegated event handlers" [1] new comments will be initialized automatically when added. [1] https://api.jquery.com/on/#direct-and-delegated-events
This commit is contained in:
@@ -173,5 +173,4 @@ $(function() {
|
||||
|
||||
$(document).ready(initialize_modules);
|
||||
$(document).on("page:load", initialize_modules);
|
||||
$(document).on("ajax:complete", initialize_modules);
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user