refactors debate and proposal controllers

This commit is contained in:
rgarcia
2015-09-28 19:23:27 +02:00
parent 6426bd3a29
commit 708a41ee1c
3 changed files with 111 additions and 128 deletions

View File

@@ -1,64 +1,16 @@
class DebatesController < ApplicationController
include Commentable
include FlagActions
before_action :parse_tag_filter, only: :index
before_action :parse_search_terms, only: :index
before_action :parse_tag_filter, only: :index
before_action :authenticate_user!, except: [:index, :show]
has_orders %w{hot_score confidence_score created_at most_commented random}, only: :index
load_and_authorize_resource
respond_to :html, :js
def index
@debates = @search_terms.present? ? Debate.search(@search_terms) : Debate.all
@debates = @debates.tagged_with(@tag_filter) if @tag_filter
@debates = @debates.page(params[:page]).for_render.send("sort_by_#{@current_order}")
@tag_cloud = Debate.tag_counts.order(debates_count: :desc, name: :asc).limit(20)
set_debate_votes(@debates)
end
def show
set_debate_votes(@debate)
@commentable = @debate
@root_comments = @debate.comments.roots.recent.page(params[:page]).per(10).for_render
@comments = @root_comments.inject([]){|all, root| all + Comment.descendants_of(root).for_render}
@all_visible_comments = @root_comments + @comments
set_comment_flags(@all_visible_comments)
end
def new
@debate = Debate.new
load_featured_tags
end
def create
@debate = Debate.new(debate_params)
@debate.author = current_user
if @debate.save_with_captcha
ahoy.track :debate_created, debate_id: @debate.id
redirect_to @debate, notice: t('flash.actions.create.notice', resource_name: 'Debate')
else
load_featured_tags
render :new
end
end
def edit
load_featured_tags
end
def update
@debate.assign_attributes(debate_params)
if @debate.save_with_captcha
redirect_to @debate, notice: t('flash.actions.update.notice', resource_name: 'Debate')
else
load_featured_tags
render :edit
end
end
def vote
@debate.register_vote(current_user, params[:value])
set_debate_votes(@debate)
@@ -70,17 +22,4 @@ class DebatesController < ApplicationController
params.require(:debate).permit(:title, :description, :tag_list, :terms_of_service, :captcha, :captcha_key)
end
def load_featured_tags
@featured_tags = ActsAsTaggableOn::Tag.where(featured: true)
end
def parse_tag_filter
if params[:tag].present?
@tag_filter = params[:tag] if ActsAsTaggableOn::Tag.named(params[:tag]).exists?
end
end
def parse_search_terms
@search_terms = params[:search] if params[:search].present?
end
end