From 7053b17e6469d9afe71466b16fd4e33459af5357 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 20 May 2021 00:08:46 +0200 Subject: [PATCH] Simplify setting border on active menu elements Since we are using the same color as the text color in both the public and admin areas, we can omit the border color completely. Since now admin elements get the exact same border, we can remove this border so they'll inherit the same border as used in the public area. --- app/assets/stylesheets/admin.scss | 1 - app/assets/stylesheets/layout.scss | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/app/assets/stylesheets/admin.scss b/app/assets/stylesheets/admin.scss index 994da0dcc..007fa2d41 100644 --- a/app/assets/stylesheets/admin.scss +++ b/app/assets/stylesheets/admin.scss @@ -291,7 +291,6 @@ $table-header: #ecf1f6; } .is-active { - border-bottom: 2px solid $admin-color; color: $admin-color; font-weight: bold; } diff --git a/app/assets/stylesheets/layout.scss b/app/assets/stylesheets/layout.scss index 98e3d9254..441358ceb 100644 --- a/app/assets/stylesheets/layout.scss +++ b/app/assets/stylesheets/layout.scss @@ -235,7 +235,7 @@ a { &.is-active { @include brand-text; - border-bottom: 2px solid $brand; + border-bottom: 2px solid; padding-bottom: rem-calc(1); } @@ -272,7 +272,7 @@ a { &.is-active { @include brand-text; - border-bottom: 2px solid $brand; + border-bottom: 2px solid; } }