From 50ef23205f63241129ba72d2aadbab0514e4099d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juanjo=20Baza=CC=81n?= <jjbazan@gmail.com>
Date: Thu, 8 Sep 2016 12:42:28 +0200
Subject: [PATCH 1/4] avoids loading featured proposals if voting notice

---
 app/controllers/proposals_controller.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/controllers/proposals_controller.rb b/app/controllers/proposals_controller.rb
index 898ad9949..ee241c49b 100644
--- a/app/controllers/proposals_controller.rb
+++ b/app/controllers/proposals_controller.rb
@@ -27,8 +27,8 @@ class ProposalsController < ApplicationController
 
   def index_customization
     load_retired
-    load_featured
     load_proposal_ballots
+    load_featured if @proposal_ballots.blank?
   end
 
   def vote

From 974c4d6d705de1e0921dc745cacc5468ea6c026f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= <jjbazan@gmail.com>
Date: Thu, 8 Sep 2016 12:43:06 +0200
Subject: [PATCH 2/4] adds specs for proposal ballots

---
 .../_featured_successfull_proposal.html.erb   |  2 +-
 app/views/proposals/index.html.erb            |  2 +-
 app/views/proposals/show.html.erb             | 20 +++----
 spec/features/proposal_ballots_spec.rb        | 58 +++++++++++++++++++
 spec/support/common_actions.rb                |  5 ++
 5 files changed, 75 insertions(+), 12 deletions(-)
 create mode 100644 spec/features/proposal_ballots_spec.rb

diff --git a/app/views/proposal_ballots/_featured_successfull_proposal.html.erb b/app/views/proposal_ballots/_featured_successfull_proposal.html.erb
index 97754ce9c..3cc18a992 100644
--- a/app/views/proposal_ballots/_featured_successfull_proposal.html.erb
+++ b/app/views/proposal_ballots/_featured_successfull_proposal.html.erb
@@ -1,3 +1,3 @@
-<div id="<%= dom_id(proposal) %>" class="proposal-sucessfull">
+<div id="<%= dom_id(proposal) %>_next_voting" class="proposal-sucessfull">
   <h3><%= link_to proposal.title, proposal_ballots_path %></h3>
 </div>
diff --git a/app/views/proposals/index.html.erb b/app/views/proposals/index.html.erb
index 93574c1ad..5dee606d0 100644
--- a/app/views/proposals/index.html.erb
+++ b/app/views/proposals/index.html.erb
@@ -32,7 +32,7 @@
       <% end %>
 
       <% if @proposal_ballots.present? %>
-        <div class="row featured-proposals-ballot-banner margin-bottom">
+        <div id="next-voting" class="row featured-proposals-ballot-banner margin-bottom">
           <div class="small-12 column padding">
             <div class="icon-successfull"></div>
             <h2>
diff --git a/app/views/proposals/show.html.erb b/app/views/proposals/show.html.erb
index 06db46216..f19a21f71 100644
--- a/app/views/proposals/show.html.erb
+++ b/app/views/proposals/show.html.erb
@@ -102,19 +102,19 @@
       <aside class="small-12 medium-3 column">
         <div class="sidebar-divider"></div>
         <h3><%= t("votes.supports") %></h3>
-        <% if @proposal.successfull? %>
-          <p>
-            <%= t("proposal_ballots.successfull",
-                voting: link_to(t("proposal_ballots.voting"), proposal_ballots_path)).html_safe %>
-          </p>
-        <% else %>
-          <div class="text-center">
-            <div id="<%= dom_id(@proposal) %>_votes">
+        <div id="<%= dom_id(@proposal) %>_votes">
+          <% if @proposal.successfull? %>
+            <p>
+              <%= t("proposal_ballots.successfull",
+                  voting: link_to(t("proposal_ballots.voting"), proposal_ballots_path)).html_safe %>
+            </p>
+          <% else %>
+            <div class="text-center">
              <%= render 'votes',
                         { proposal: @proposal, vote_url: vote_proposal_path(@proposal, value: 'yes') } %>
             </div>
-          </div>
-        <% end %>
+          <% end %>
+        </div>
 
         <div id="social-share" class="sidebar-divider"></div>
         <h3><%= t("proposals.show.share") %></h3>
diff --git a/spec/features/proposal_ballots_spec.rb b/spec/features/proposal_ballots_spec.rb
new file mode 100644
index 000000000..e7bf310b1
--- /dev/null
+++ b/spec/features/proposal_ballots_spec.rb
@@ -0,0 +1,58 @@
+# coding: utf-8
+require 'rails_helper'
+
+feature 'Proposal ballots' do
+
+  scenario 'Banner shows in proposal index' do
+    create_featured_proposals
+
+    visit proposals_path
+    expect(page).to_not have_css("#next-voting")
+    expect(page).to have_css("#featured-proposals")
+
+    create_successfull_proposals
+
+    visit proposals_path
+
+    expect(page).to have_css("#next-voting")
+    expect(page).to_not have_css("#featured-proposals")
+  end
+
+  scenario 'Successfull proposals do not show support buttons in index' do
+    successfull_proposals = create_successfull_proposals
+
+    visit proposals_path
+
+    successfull_proposals.each do |proposal|
+      within("#proposal_#{proposal.id}_votes") do
+        expect(page).to_not have_css(".supports")
+        expect(page).to have_content "This proposal has reached the required supports"
+      end
+    end
+  end
+
+  scenario 'Successfull proposals do not show support buttons in show' do
+    successfull_proposals = create_successfull_proposals
+
+    successfull_proposals.each do |proposal|
+      visit proposal_path(proposal)
+      within("#proposal_#{proposal.id}_votes") do
+        expect(page).to_not have_css(".supports")
+        expect(page).to have_content "This proposal has reached the required supports"
+      end
+    end
+  end
+
+  scenario 'Successfull proposals are listed in the proposal ballots index' do
+    successfull_proposals = create_successfull_proposals
+
+    visit proposal_ballots_path
+
+    successfull_proposals.each do |proposal|
+      expect(page).to have_content(proposal.title)
+      expect(page).to have_content(proposal.question)
+    end
+  end
+
+end
+
diff --git a/spec/support/common_actions.rb b/spec/support/common_actions.rb
index 60d6641bf..8eaa49d4b 100644
--- a/spec/support/common_actions.rb
+++ b/spec/support/common_actions.rb
@@ -192,6 +192,11 @@ module CommonActions
      create(:debate, :with_confidence_score, cached_votes_up: 80)]
   end
 
+  def create_successfull_proposals
+    [create(:proposal, title: "Winter is coming", question: "Do you speak it?", cached_votes_up: Proposal.votes_needed_for_success + 100),
+     create(:proposal, title: "Fire and blood", question: "You talking to me?", cached_votes_up: Proposal.votes_needed_for_success + 1)]
+  end
+
   def tag_names(tag_cloud)
     tag_cloud.tags.map(&:name)
   end

From 11a5ed15eacbe03ac30f589a5d40bb9bec285a13 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= <jjbazan@gmail.com>
Date: Thu, 8 Sep 2016 15:45:29 +0200
Subject: [PATCH 3/4] adds question marks to seed data

---
 db/dev_seeds.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/db/dev_seeds.rb b/db/dev_seeds.rb
index 61b5f5060..d9d6d2483 100644
--- a/db/dev_seeds.rb
+++ b/db/dev_seeds.rb
@@ -149,7 +149,7 @@ tags = Faker::Lorem.words(25)
   description = "<p>#{Faker::Lorem.paragraphs.join('</p><p>')}</p>"
   proposal = Proposal.create!(author: author,
                               title: Faker::Lorem.sentence(3).truncate(60),
-                              question: Faker::Lorem.sentence(3),
+                              question: Faker::Lorem.sentence(3) + "?",
                               summary: Faker::Lorem.sentence(3),
                               responsible_name: Faker::Name.name,
                               external_url: Faker::Internet.url,
@@ -168,7 +168,7 @@ tags = ActsAsTaggableOn::Tag.where(kind: 'category')
   description = "<p>#{Faker::Lorem.paragraphs.join('</p><p>')}</p>"
   proposal = Proposal.create!(author: author,
                               title: Faker::Lorem.sentence(3).truncate(60),
-                              question: Faker::Lorem.sentence(3),
+                              question: Faker::Lorem.sentence(3) + "?",
                               summary: Faker::Lorem.sentence(3),
                               responsible_name: Faker::Name.name,
                               external_url: Faker::Internet.url,

From e330b704c043a79a397e03cef04818663895f04c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= <jjbazan@gmail.com>
Date: Thu, 8 Sep 2016 17:06:16 +0200
Subject: [PATCH 4/4] removes half-baked feature archived proposals is a
 separate issue now

---
 app/models/proposal.rb | 1 -
 config/locales/en.yml  | 1 -
 config/locales/es.yml  | 1 -
 3 files changed, 3 deletions(-)

diff --git a/app/models/proposal.rb b/app/models/proposal.rb
index cddcdcbf8..4c3cc9e40 100644
--- a/app/models/proposal.rb
+++ b/app/models/proposal.rb
@@ -44,7 +44,6 @@ class Proposal < ActiveRecord::Base
   scope :sort_by_random,           -> { reorder("RANDOM()") }
   scope :sort_by_relevance,        -> { all }
   scope :sort_by_flags,            -> { order(flags_count: :desc, updated_at: :desc) }
-  scope :archived,                 -> { where("proposals.created_at <= ?", 1.year.ago)}
   scope :last_week,                -> { where("proposals.created_at >= ?", 7.days.ago)}
   scope :retired,                  -> { where.not(retired_at: nil) }
   scope :not_retired,              -> { where(retired_at: nil) }
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 8373771cf..56aa19bbe 100755
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -302,7 +302,6 @@ en:
         hot_score: most active
         most_commented: most commented
         relevance: relevance
-        archived: Archived
       retired_proposals: Retired proposals
       retired_proposals_link: "Proposals retired by the author"
       retired_links:
diff --git a/config/locales/es.yml b/config/locales/es.yml
index d7736c4e5..657c4c0d0 100755
--- a/config/locales/es.yml
+++ b/config/locales/es.yml
@@ -302,7 +302,6 @@ es:
         hot_score: Más activas hoy
         most_commented: Más comentadas
         relevance: Más relevantes
-        archived: Archivadas
       retired_proposals: Propuestas retiradas
       retired_proposals_link: "Propuestas retiradas por sus autores"
       retired_links: