From 6f4dc11dc4c254241ebd0a5d0a7dc05c62d967d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sat, 2 Nov 2019 00:36:56 +0100 Subject: [PATCH] Remove validations in investment changelog entries If we validate the presence of the old value and the new value, changes in optional fields will not be stored if either the old value or the new value are blank. --- app/models/budget/investment.rb | 2 +- app/models/budget/investment/change_log.rb | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/app/models/budget/investment.rb b/app/models/budget/investment.rb index 9a6fcedde..28f52023d 100644 --- a/app/models/budget/investment.rb +++ b/app/models/budget/investment.rb @@ -413,7 +413,7 @@ class Budget log.investment_id = self.id log.new_value = self.send field log.old_value = self.send "#{field}_was" - !log.save + log.save! end end end diff --git a/app/models/budget/investment/change_log.rb b/app/models/budget/investment/change_log.rb index fe5839b14..5b5123ae0 100644 --- a/app/models/budget/investment/change_log.rb +++ b/app/models/budget/investment/change_log.rb @@ -5,8 +5,6 @@ class Budget::Investment::ChangeLog < ApplicationRecord inverse_of: :budget_investment_change_logs, required: false - validates :old_value, presence: true - validates :new_value, presence: true validates :field, presence: true scope :by_investment, ->(investment_id) { where(investment_id: investment_id) }