From 6f219beff0e67aa45bf0de0d7c1abbe5b347a560 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 27 Jul 2021 19:32:36 +0200 Subject: [PATCH] Remove unused parameter in imageable tests method --- spec/shared/system/nested_imageable.rb | 44 ++++--------------- spec/system/admin/budget_phases_spec.rb | 5 +-- .../admin/legislation/processes_spec.rb | 2 +- .../questions/answers/images/images_spec.rb | 3 +- spec/system/legislation/proposals_spec.rb | 2 +- 5 files changed, 13 insertions(+), 43 deletions(-) diff --git a/spec/shared/system/nested_imageable.rb b/spec/shared/system/nested_imageable.rb index 4ab48c6a1..57c2329ec 100644 --- a/spec/shared/system/nested_imageable.rb +++ b/spec/shared/system/nested_imageable.rb @@ -47,10 +47,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p do_login_for user visit send(path, arguments) - imageable_attach_new_file( - imageable_factory_name, - Rails.root.join("spec/fixtures/files/clippy.jpg") - ) + imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg")) expect_image_has_title("clippy.jpg") end @@ -75,10 +72,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p do_login_for user visit send(path, arguments) - imageable_attach_new_file( - imageable_factory_name, - Rails.root.join("spec/fixtures/files/clippy.jpg") - ) + imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg")) expect(page).to have_selector ".loading-bar.complete" end @@ -87,11 +81,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p do_login_for user visit send(path, arguments) - imageable_attach_new_file( - imageable_factory_name, - Rails.root.join("spec/fixtures/files/logo_header.png"), - false - ) + imageable_attach_new_file(Rails.root.join("spec/fixtures/files/logo_header.png"), false) expect(page).to have_selector ".loading-bar.errors" end @@ -100,10 +90,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p do_login_for user visit send(path, arguments) - imageable_attach_new_file( - imageable_factory_name, - Rails.root.join("spec/fixtures/files/clippy.jpg") - ) + imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg")) expect_image_has_cached_attachment(".jpg") end @@ -112,11 +99,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p do_login_for user visit send(path, arguments) - imageable_attach_new_file( - imageable_factory_name, - Rails.root.join("spec/fixtures/files/logo_header.png"), - false - ) + imageable_attach_new_file(Rails.root.join("spec/fixtures/files/logo_header.png"), false) expect_image_has_cached_attachment("") end @@ -141,10 +124,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p do_login_for user visit send(path, arguments) - imageable_attach_new_file( - imageable_factory_name, - Rails.root.join("spec/fixtures/files/clippy.jpg") - ) + imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg")) within "#nested-image .image" do click_link "Remove image" @@ -171,10 +151,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p visit send(path, arguments) send(fill_resource_method_name) if fill_resource_method_name - imageable_attach_new_file( - imageable_factory_name, - Rails.root.join("spec/fixtures/files/clippy.jpg") - ) + imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg")) expect(page).to have_selector ".loading-bar.complete" @@ -188,10 +165,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p visit send(path, arguments) send(fill_resource_method_name) if fill_resource_method_name - imageable_attach_new_file( - imageable_factory_name, - Rails.root.join("spec/fixtures/files/clippy.jpg") - ) + imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg")) expect(page).to have_selector ".loading-bar.complete" @@ -255,7 +229,7 @@ def imageable_redirected_to_resource_show_or_navigate_to end end -def imageable_attach_new_file(_imageable_factory_name, path, success = true) +def imageable_attach_new_file(path, success = true) click_link "Add image" within "#nested-image" do image = find(".image") diff --git a/spec/system/admin/budget_phases_spec.rb b/spec/system/admin/budget_phases_spec.rb index b4b7f4a7a..5893a8aea 100644 --- a/spec/system/admin/budget_phases_spec.rb +++ b/spec/system/admin/budget_phases_spec.rb @@ -46,10 +46,7 @@ describe "Admin budget phases" do scenario "shows successful notice when updating the phase with a valid image" do visit edit_admin_budget_budget_phase_path(budget, budget.current_phase) - imageable_attach_new_file( - "budget_phase_image", - Rails.root.join("spec/fixtures/files/clippy.jpg") - ) + imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg")) click_on "Save changes" diff --git a/spec/system/admin/legislation/processes_spec.rb b/spec/system/admin/legislation/processes_spec.rb index b16a7e5c5..d19a3a16c 100644 --- a/spec/system/admin/legislation/processes_spec.rb +++ b/spec/system/admin/legislation/processes_spec.rb @@ -175,7 +175,7 @@ describe "Admin collaborative legislation", :admin do fill_in "End", with: base_date + 5.days end - imageable_attach_new_file(create(:image), Rails.root.join("spec/fixtures/files/clippy.jpg")) + imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg")) click_button "Create process" diff --git a/spec/system/admin/poll/questions/answers/images/images_spec.rb b/spec/system/admin/poll/questions/answers/images/images_spec.rb index 398680c2c..a31c4af8a 100644 --- a/spec/system/admin/poll/questions/answers/images/images_spec.rb +++ b/spec/system/admin/poll/questions/answers/images/images_spec.rb @@ -32,14 +32,13 @@ describe "Images", :admin do scenario "Add image to answer" do answer = create(:poll_question_answer) - image = create(:image) visit admin_answer_images_path(answer) expect(page).not_to have_css("img[title='clippy.jpg']") expect(page).not_to have_content("clippy.jpg") visit new_admin_answer_image_path(answer) - imageable_attach_new_file(image, Rails.root.join("spec/fixtures/files/clippy.jpg")) + imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg")) click_button "Save image" expect(page).to have_css("img[title='clippy.jpg']") diff --git a/spec/system/legislation/proposals_spec.rb b/spec/system/legislation/proposals_spec.rb index d615cd8fc..cfeac71fa 100644 --- a/spec/system/legislation/proposals_spec.rb +++ b/spec/system/legislation/proposals_spec.rb @@ -146,7 +146,7 @@ describe "Legislation Proposals" do fill_in "Proposal title", with: "Legislation proposal with image" fill_in "Proposal summary", with: "Including an image on a legislation proposal" - imageable_attach_new_file(create(:image), Rails.root.join("spec/fixtures/files/clippy.jpg")) + imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg")) check "legislation_proposal_terms_of_service" click_button "Create proposal"