Enable RSpec/DescribeClass rubocop rspec cop & fix issues

Manually fixes all issues & "stashed" false positives at .rubocop_todo.yml

Read about the cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribeClass

.rubocop.yml

@@ -51,3 +51,6 @@ Capybara/FeatureMethods:
 
 RSpec/ContextWording:
   Enabled: false
+
+RSpec/DescribeClass:
+  Enabled: true

.rubocop_todo.yml

@@ -783,3 +783,17 @@ Style/SafeNavigation:
 Style/WordArray:
   EnforcedStyle: percent
   MinSize: 8
+
+# Offense count: 9
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/customization_engine_spec.rb'
+    - 'spec/i18n_spec.rb'
+    - 'spec/lib/acts_as_paranoid_aliases_spec.rb'
+    - 'spec/lib/cache_spec.rb'
+    - 'spec/lib/graphql_spec.rb'
+    - 'spec/lib/tasks/communities_spec.rb'
+    - 'spec/lib/tasks/dev_seed_spec.rb'
+    - 'spec/lib/tasks/settings_spec.rb'
+    - 'spec/models/abilities/organization_spec.rb'
+    - 'spec/views/welcome/index.html.erb_spec.rb'

spec/controllers/concerns/has_filters_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe 'HasFilters' do
+describe HasFilters do
 
   class FakeController < ActionController::Base; end
 

spec/controllers/concerns/has_orders_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe 'HasOrders' do
+describe HasOrders do
 
   class FakeController < ActionController::Base; end
 

spec/customization_engine_spec.rb

@@ -3,7 +3,7 @@ require 'rails_helper'
 # This module tests functionality related with custom application files
 # TODO test models, controllers, etc...
 
-describe 'CustomizationEngine' do
+describe 'Customization Engine' do
 
   let(:test_key) { I18n.t('account.show.change_credentials_link') }
   let!(:default_path) { I18n.load_path }

spec/lib/acts_as_taggable_on_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe 'ActsAsTaggableOn' do
+describe ActsAsTaggableOn do
 
   describe 'Tagging' do
     describe "when tagging debates or proposals" do

spec/lib/graphql_spec.rb

@@ -35,7 +35,7 @@ def extract_fields(response, collection_name, field_chain)
   end.compact
 end
 
-describe 'ConsulSchema' do
+describe 'Consul Schema' do
   let(:user) { create(:user) }
   let(:proposal) { create(:proposal, author: user) }
 

spec/models/abilities/administrator_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 require 'cancan/matchers'
 
-describe "Abilities::Administrator" do
+describe Abilities::Administrator do
   subject(:ability) { Ability.new(user) }
   let(:user) { administrator.user }
   let(:administrator) { create(:administrator) }

spec/models/abilities/common_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 require 'cancan/matchers'
 
-describe "Abilities::Common" do
+describe Abilities::Common do
   subject(:ability) { Ability.new(user) }
   let(:geozone)     { create(:geozone)  }
 

spec/models/abilities/everyone_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 require 'cancan/matchers'
 
-describe "Abilities::Everyone" do
+describe Abilities::Everyone do
   subject(:ability) { Ability.new(user) }
 
   let(:user) { nil }

spec/models/abilities/moderator_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 require 'cancan/matchers'
 
-describe "Abilities::Moderator" do
+describe Abilities::Moderator do
   subject(:ability) { Ability.new(user) }
   let(:user) { moderator.user }
   let(:moderator) { create(:moderator) }

spec/models/abilities/organization_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 require 'cancan/matchers'
 
-describe "Abilities::Organization" do
+describe 'Abilities::Organization' do
   subject(:ability) { Ability.new(user) }
   let(:user) { organization.user }
   let(:organization) { create(:organization) }

spec/models/abilities/valuator_spec.rb

@@ -1,7 +1,7 @@
 require 'rails_helper'
 require 'cancan/matchers'
 
-describe "Abilities::Valuator" do
+describe Abilities::Valuator do
   subject(:ability) { Ability.new(user) }
   let(:user) { valuator.user }
   let(:valuator) { create(:valuator) }

spec/models/budget/ballot/line_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe "Budget::Ballot::Line" do
+describe Budget::Ballot::Line do
 
   let(:budget){ create(:budget) }
   let(:group){ create(:budget_group, budget: budget) }

spec/models/budget/investment/milestone_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe "Budget::Investment::Milestone" do
+describe Budget::Investment::Milestone do
 
   describe "Validations" do
     let(:milestone) { build(:budget_investment_milestone) }

spec/models/letter_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe 'Verification::Letter' do
+describe Verification::Letter do
 
   let(:user) { create(:user) }
 

spec/models/poll/booth_assignment_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe :booth_assignment do
+describe Poll::BoothAssignment do
   let(:poll){create(:poll)}
   let(:booth){create(:poll_booth)}
   let(:booth1){create(:poll_booth)}

spec/models/poll/booth_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe :booth do
+describe Poll::Booth do
 
   let(:booth) { build(:poll_booth) }
 

spec/models/poll/officer_assignment_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe :officer_assignment do
+describe Poll::OfficerAssignment do
   it "should log user data on creation" do
     user = create(:user, username: "Larry Bird", email: "larry@lege.nd")
     officer = create(:poll_officer, user: user)

spec/models/poll/officer_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe :officer do
+describe Poll::Officer do
 
   describe "#voting_days_assigned_polls" do
     it "should return all polls with this officer assigned during voting days" do

spec/models/poll/shift_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe :shift do
+describe Poll::Shift do
   let(:poll) { create(:poll) }
   let(:booth) { create(:poll_booth) }
   let(:user) { create(:user, username: "Ana", email: "ana@example.com") }

spec/models/poll/voter_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe :voter do
+describe Poll::Voter do
 
   let(:poll) { create(:poll) }
   let(:booth) { create(:poll_booth) }

spec/models/vote_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-describe 'Vote' do
+describe Vote do
 
   describe '#for_debates' do
     it 'does not returns votes for other votables' do

spec/views/welcome/index.html.erb_spec.rb

@@ -1,6 +1,6 @@
 require "rails_helper"
 
-RSpec.describe "welcome/index" do
+RSpec.describe "welcome#index" do
 
   it 'Display images on orbit carrousel when we have defined image_default' do
     debate = create(:debate)