Fixes #140

Adds a new setting that allows defining what is considered a successful
proposal.

app/controllers/admin/settings_controller.rb

@@ -1,4 +1,5 @@
 class Admin::SettingsController < Admin::BaseController
+  helper_method :successful_proposal_setting, :successful_proposals
 
   def index
     all_settings = Setting.all.group_by { |s| s.type }
@@ -11,20 +12,27 @@ class Admin::SettingsController < Admin::BaseController
   def update
     @setting = Setting.find(params[:id])
     @setting.update(settings_params)
-    redirect_to request.referer, notice: t("admin.settings.flash.updated")
+    redirect_to request.referer, notice: t('admin.settings.flash.updated')
   end
 
   def update_map
-    Setting["map_latitude"] = params[:latitude].to_f
+    Setting['map_latitude'] = params[:latitude].to_f
-    Setting["map_longitude"] = params[:longitude].to_f
+    Setting['map_longitude'] = params[:longitude].to_f
-    Setting["map_zoom"] = params[:zoom].to_i
+    Setting['map_zoom'] = params[:zoom].to_i
-    redirect_to admin_settings_path, notice: t("admin.settings.index.map.flash.update")
+    redirect_to admin_settings_path, notice: t('admin.settings.index.map.flash.update')
   end
 
   private
 
-    def settings_params
+  def settings_params
-      params.require(:setting).permit(:value)
+    params.require(:setting).permit(:value)
-    end
+  end
 
-end
+  def successful_proposal_setting
+    Setting.find_by(key: 'proposals.successful_proposal_id')
+  end
+
+  def successful_proposals
+    Proposal.successful
+  end
+end

app/models/setting.rb

@@ -6,15 +6,11 @@ class Setting < ActiveRecord::Base
   scope :banner_img, -> { where("key ilike ?", "banner-img.%")}
 
   def type
-    if feature_flag?
+    return 'feature' if feature_flag?
-      'feature'
+    return 'banner-style' if banner_style?
-    elsif banner_style?
+    return 'banner-img' if banner_img?
-      'banner-style'
+    return 'proposals' if proposals?
-    elsif banner_img?
+    'common'
-      'banner-img'
-    else
-      'common'
-    end
   end
 
   def feature_flag?
@@ -33,6 +29,10 @@ class Setting < ActiveRecord::Base
     key.start_with?('banner-img.')
   end
 
+  def proposals?
+    key.start_with?('proposals.')
+  end
+
   class << self
     def [](key)
       where(key: key).pluck(:value).first.presence

app/views/admin/settings/_filter_subnav.html.erb

@@ -28,4 +28,8 @@
       <%= t("admin.settings.index.map.title") %>
     <% end %>
   </li>
+
+  <li class="tabs-title" id="proposals-tab">
+    <%= link_to t('admin.settings.index.proposals.title'), '#tab-proposals' %>
+  </li>
 </ul>

app/views/admin/settings/_proposals.html.erb

@@ -0,0 +1,21 @@
+<h2><%= t('admin.settings.index.proposals.title') %></h2>
+
+<table>
+  <tbody>
+    <tr>
+      <td class="small-12 medium-4">
+        <strong><%= t("settings.#{successful_proposal_setting.key}") %></strong>
+      </td>
+      <td class="small-12 medium-8">
+        <%= form_for(successful_proposal_setting, url: admin_setting_path(successful_proposal_setting), html: { id: "edit_#{dom_id(successful_proposal_setting)}"}) do |f| %>
+          <div class="small-12 medium-6 large-9 column">
+            <%= f.select :value, successful_proposals.collect { |p| [p.title, p.id] }, { include_blank: true, label: false }, label: false, id: dom_id(successful_proposal_setting) %>
+          </div>
+          <div class="small-12 medium-6 large-3 column">
+            <%= f.submit(t('admin.settings.index.update_setting'), class: "button hollow expanded") %>
+          </div>
+        <% end %>
+      </td>
+    </tr>
+  </tbody>
+</table>

app/views/admin/settings/index.html.erb

@@ -21,4 +21,8 @@
   <div class="tabs-panel" id="tab-map-configuration">
     <%= render "map_configuration" %>
   </div>
+
+  <div class="tabs-panel" id="tab-proposals">
+    <%= render "proposals" %>
+  </div>
 </div>

config/locales/en/admin.yml

@@ -982,6 +982,8 @@ en:
             update: Map configuration updated succesfully.
           form:
             submit: Update
+        proposals:
+          title: Proposal related settings
     shared:
       booths_search:
         button: Search

config/locales/en/settings.yml

@@ -62,4 +62,6 @@ en:
     meta_keywords: "Keywords (SEO)"
     verification_offices_url: Verification offices URL
     min_age_to_participate: Minimum age needed to participate
-    proposal_improvement_path: Proposal improvement info internal link
+    proposal_improvement_path: Proposal improvement info internal link
+    proposals:
+      successful_proposal_id: Successful proposal

config/locales/es/admin.yml

@@ -982,6 +982,8 @@ es:
             update: La configuración del mapa se ha guardado correctamente.
           form:
             submit: Actualizar
+        proposals:
+          title: Ajustes para propuestas
     shared:
       booths_search:
         button: Buscar

config/locales/es/settings.yml

@@ -63,3 +63,5 @@ es:
     verification_offices_url: URL oficinas verificación
     min_age_to_participate: Edad mínima para participar
     proposal_improvement_path: Link a información para mejorar propuestas
+    proposals:
+      successful_proposal_id: Propuesta exitosa

db/seeds.rb

@@ -132,3 +132,5 @@ Setting['feature.homepage.widgets.feeds.proposals'] = true
 Setting['feature.homepage.widgets.feeds.debates'] = true
 Setting['feature.homepage.widgets.feeds.processes'] = true
 
+# Proposals
+Setting['proposals.successful_proposal_id'] = nil

lib/tasks/proposal_actions.rake

@@ -12,4 +12,9 @@ namespace :proposal_actions do
       )
     end
   end 
+
+  desc 'Initialize successful proposal id setting'
+  task initialize_successful_proposal_id: :environment do
+    Setting['proposals.successful_proposal_id'] = nil
+  end
 end