From 6d6c067296a4bd1d221c15074b286f39caee953a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Sat, 12 Oct 2024 22:15:45 +0200
Subject: [PATCH] Use an empty alt attribute for decorative images

This way people using screen readers will know that the image is a
decorative one.
---
 app/views/dashboard/mailer/forward.html.erb | 4 ++--
 app/views/dashboard/mailing/index.html.erb  | 4 ++--
 app/views/dashboard/poster/index.html.erb   | 6 +++---
 app/views/dashboard/poster/index.pdf.erb    | 6 +++---
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/app/views/dashboard/mailer/forward.html.erb b/app/views/dashboard/mailer/forward.html.erb
index 553ce766a..3f85b7850 100644
--- a/app/views/dashboard/mailer/forward.html.erb
+++ b/app/views/dashboard/mailer/forward.html.erb
@@ -5,9 +5,9 @@
     <tbody>
       <tr>
         <td style="background: #0300ff; padding: 50px; padding-top:40px; text-align: left;">
-          <%= image_tag "quote_before_white.png", style: "max-width: 40px; vertical-align: top;" %>
+          <%= image_tag "quote_before_white.png", alt: "", style: "max-width: 40px; vertical-align: top;" %>
           <h1 style="color: #fff; font-size: 60px; line-height: 90px; display: inline;"><%= @proposal.title %></h1>
-          <%= image_tag "quote_after_white.png", style: "max-width: 40px; vertical-align: top;" %>
+          <%= image_tag "quote_after_white.png", alt: "", style: "max-width: 40px; vertical-align: top;" %>
           <h2 style="color: #fff; font-size: 40px; line-height: 60px"><%= sanitize(t("dashboard.mailer.forward.subtitle")) %></h2>
         </td>
       </tr>
diff --git a/app/views/dashboard/mailing/index.html.erb b/app/views/dashboard/mailing/index.html.erb
index 713f85935..0f3c6c44b 100644
--- a/app/views/dashboard/mailing/index.html.erb
+++ b/app/views/dashboard/mailing/index.html.erb
@@ -2,9 +2,9 @@
 <div class="row expanded">
   <div class="small-12 medium-9 column dashboard-mail-preview">
     <div class="mail-header text-left">
-      <%= image_tag "quote_before_white.png" %>
+      <%= image_tag "quote_before_white.png", alt: "" %>
       <h1 class="inline"><%= proposal.title %></h1>
-      <%= image_tag "quote_after_white.png" %>
+      <%= image_tag "quote_after_white.png", alt: "" %>
       <h2><%= sanitize(t("dashboard.mailer.forward.subtitle")) %></h2>
     </div>
 
diff --git a/app/views/dashboard/poster/index.html.erb b/app/views/dashboard/poster/index.html.erb
index bbd988356..e8e7112cd 100644
--- a/app/views/dashboard/poster/index.html.erb
+++ b/app/views/dashboard/poster/index.html.erb
@@ -6,7 +6,7 @@
         <h1>
           <%= t("dashboard.poster.index.poster_title") %>
           <br>
-          <%= image_tag("finger.png") %>
+          <%= image_tag("finger.png", alt: "") %>
           <%= t("dashboard.poster.index.poster_subtitle") %>
         </h1>
         <p class="intro">
@@ -25,9 +25,9 @@
         </div>
         <div class="poster-content">
           <h2><%= t("dashboard.poster.index.support") %></h2>
-            <%= image_tag "quote_before_blue.png" %>
+            <%= image_tag "quote_before_blue.png", alt: "" %>
             <h3><%= proposal.title %></h3>
-            <%= image_tag "quote_after_blue.png" %>
+            <%= image_tag "quote_after_blue.png", alt: "" %>
           <p class="poster-footer">
             <%= sanitize(t("dashboard.poster.index.footer", link: proposal_url(proposal))) %>
           </p>
diff --git a/app/views/dashboard/poster/index.pdf.erb b/app/views/dashboard/poster/index.pdf.erb
index 7c4eaebe1..9a8b0e383 100644
--- a/app/views/dashboard/poster/index.pdf.erb
+++ b/app/views/dashboard/poster/index.pdf.erb
@@ -11,7 +11,7 @@
     <h1>
       <strong><%= t("dashboard.poster.index.poster_title") %>
       <br>
-      <%= wicked_pdf_image_tag("finger.png") %>
+      <%= wicked_pdf_image_tag("finger.png", alt: "") %>
       <%= t("dashboard.poster.index.poster_subtitle") %>
       </strong>
     </h1>
@@ -30,9 +30,9 @@
     </div>
     <div class="poster-content">
       <h2 class="text-center"><strong><%= t("dashboard.poster.index.support") %></strong></h2>
-      <%= wicked_pdf_image_tag "quote_before_blue.png" %>
+      <%= wicked_pdf_image_tag "quote_before_blue.png", alt: "" %>
       <h3><strong><%= proposal.title %></strong></h3>
-      <%= wicked_pdf_image_tag "quote_after_blue.png" %>
+      <%= wicked_pdf_image_tag "quote_after_blue.png", alt: "" %>
       <p class="poster-footer">
         <%= sanitize(t("dashboard.poster.index.footer", link: proposal_url(proposal))) %>
       </p>