From 6c68e9f8e77ba6e651bb5800039e45f247a4eb9e Mon Sep 17 00:00:00 2001 From: decabeza Date: Fri, 9 Feb 2018 18:16:07 +0100 Subject: [PATCH] Fixes specs --- config/i18n-tasks.yml | 1 + config/locales/en/user_groups.yml | 5 +---- config/locales/es/user_groups.yml | 3 --- spec/features/admin/valuator_groups_spec.rb | 18 +++++++++--------- spec/features/admin/valuators_spec.rb | 8 ++++---- 5 files changed, 15 insertions(+), 20 deletions(-) diff --git a/config/i18n-tasks.yml b/config/i18n-tasks.yml index f2a7c41a3..41bf3e604 100644 --- a/config/i18n-tasks.yml +++ b/config/i18n-tasks.yml @@ -42,6 +42,7 @@ data: - config/locales/%{locale}/documents.yml - config/locales/%{locale}/images.yml - config/locales/%{locale}/guides.yml + - config/locales/%{locale}/user_groups.yml # Locale files to write new keys to, based on a list of key pattern => file rules. Matched from top to bottom: # `i18n-tasks normalize -p` will force move the keys according to these rules diff --git a/config/locales/en/user_groups.yml b/config/locales/en/user_groups.yml index a3246df92..6b44b5495 100644 --- a/config/locales/en/user_groups.yml +++ b/config/locales/en/user_groups.yml @@ -1,9 +1,6 @@ en: user_group: - zero: There are 0 groups of valuators - one: There is 1 group de valuators - other: There are '%{count}' groups of valuators notice: created: "User group created successfully" updated: "User group updated successfully" - destroyed: "User group destroyed successfully" + destroyed: "User group deleted successfully" diff --git a/config/locales/es/user_groups.yml b/config/locales/es/user_groups.yml index 18d8114c9..5f4d690cf 100644 --- a/config/locales/es/user_groups.yml +++ b/config/locales/es/user_groups.yml @@ -1,8 +1,5 @@ es: user_group: - zero: Hay 0 grupos de evaluadores - one: Hay 1 grupo de evaluadores - other: Hay '%{count}' grupos de evaluadores notice: created: "Grupo de usuarios creado correctamente" updated: "Grupo de usuarios actualizado correctamente" diff --git a/spec/features/admin/valuator_groups_spec.rb b/spec/features/admin/valuator_groups_spec.rb index 6ac10e59c..9b888dfc8 100644 --- a/spec/features/admin/valuator_groups_spec.rb +++ b/spec/features/admin/valuator_groups_spec.rb @@ -29,14 +29,14 @@ feature "Valuator groups", :focus do scenario "Create" do visit admin_valuators_path - click_link "Grupos de evaluadores" - click_link "Nuevo" + click_link "Valuator Groups" + click_link "Create valuators group" fill_in "valuator_group_name", with: "Health" - click_button "Create Valuator group" + click_button "Create valuators group" expect(page).to have_content "User group created successfully" - #expect(page).to have_content "There are 1 groups of valuators" + expect(page).to have_content "There is 1 valuator group" expect(page).to have_content "Health" end @@ -47,20 +47,20 @@ feature "Valuator groups", :focus do click_link "Edit" fill_in "valuator_group_name", with: "Health and Sports" - click_button "Update Valuator group" + click_button "Save valuators group" expect(page).to have_content "User group updated successfully" expect(page).to have_content "Health and Sports" end - scenario "Destroy" do + scenario "Delete" do group = create(:valuator_group) visit admin_valuator_groups_path - click_link "Destroy" + click_link "Delete" - expect(page).to have_content "User group destroyed successfully" - expect(page).to have_content "There are 0 groups of users" + expect(page).to have_content "User group deleted successfully" + expect(page).to have_content "There are no valuator groups" end pending "When we change the group of a Valuator we should also change the valuator_assignments" diff --git a/spec/features/admin/valuators_spec.rb b/spec/features/admin/valuators_spec.rb index bac000c6d..47ee1c255 100644 --- a/spec/features/admin/valuators_spec.rb +++ b/spec/features/admin/valuators_spec.rb @@ -41,7 +41,7 @@ feature 'Admin valuators', :focus do visit edit_admin_valuator_path(@valuator) fill_in 'valuator_description', with: 'Valuator for health' - click_button "Update Evaluador" + click_button "Update valuator" expect(page).to have_content "Valuator updated successfully" expect(page).to have_content @valuator.email @@ -113,7 +113,7 @@ feature 'Admin valuators', :focus do visit edit_admin_valuator_path(valuator) select "Health", from: "valuator_valuator_group_id" - click_button "Update Evaluador" + click_button "Update valuator" expect(page).to have_content "Valuator updated successfully" expect(page).to have_content "Health" @@ -127,7 +127,7 @@ feature 'Admin valuators', :focus do visit edit_admin_valuator_path(valuator) select "Economy", from: "valuator_valuator_group_id" - click_button "Update Evaluador" + click_button "Update valuator" expect(page).to have_content "Valuator updated successfully" expect(page).to have_content "Economy" @@ -140,7 +140,7 @@ feature 'Admin valuators', :focus do visit edit_admin_valuator_path(valuator) select "", from: "valuator_valuator_group_id" - click_button "Update Evaluador" + click_button "Update valuator" expect(page).to have_content "Valuator updated successfully" expect(page).to_not have_content "Health"